aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM with two minor nits.
================
Comment at: lib/AST/ASTImporter.cpp:5563-5564
@@ +5562,4 @@
+ const TemplateArgumentLoc *FromArgArray = E->getTemplateArgs();
+ for (unsigned i = 0, e = E->getNumTemplateArgs(); i < e; i++) {
+ const TemplateArgumentLoc &FromLoc = FromArgArray[i];
+ bool Error = false;
----------------
Any particular reason not to use a range-based for loop over
`template_arguments()`?
================
Comment at: lib/AST/ASTImporter.cpp:6283
@@ +6282,3 @@
+
+
+Expr *ASTNodeImporter::VisitCXXNewExpr(CXXNewExpr *CE) {
----------------
Spurious newline.
https://reviews.llvm.org/D14326
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
