Author: ericwf
Date: Thu Jun 30 01:59:29 2016
New Revision: 274214
URL: http://llvm.org/viewvc/llvm-project?rev=274214&view=rev
Log:
Update status of already completed Oulu issues.
* P0163r0: Implemented in r273839.
* LWG 2309: pthread_mutex_lock only returns this error if certain debug flags
Author: hokein
Date: Thu Jun 30 02:50:01 2016
New Revision: 274217
URL: http://llvm.org/viewvc/llvm-project?rev=274217&view=rev
Log:
[ASTMatcher] Add a node matcher for EnumType.
Reviewers: aaron.ballman
Subscribers: cfe-commits, klimek
Differential Revision: http://reviews.llvm.org/D21860
Mod
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274217: [ASTMatcher] Add a node matcher for EnumType.
(authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D21860?vs=62277&id=62340#toc
Repository:
rL LLVM
http://reviews.llvm.org/
m_zuckerman added a comment.
No problem
http://reviews.llvm.org/D21836
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mzuckerm
Date: Thu Jun 30 03:05:46 2016
New Revision: 274218
URL: http://llvm.org/viewvc/llvm-project?rev=274218&view=rev
Log:
[Clang][Intrinsics][AVX512][BuiltIn] adding intrinsics for vrangesd instruction
set
Differential Revision: http://reviews.llvm.org/D21734
Modified:
cfe/trun
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274218: [Clang][Intrinsics][AVX512][BuiltIn] adding
intrinsics for vrangesd… (authored by mzuckerm).
Changed prior to commit:
http://reviews.llvm.org/D21734?vs=61907&id=62342#toc
Repository:
rL LLVM
On 29 Jun 2016, at 23:07, Richard Smith via cfe-dev
wrote:
>
> Yes, those are real problems, but it's not reasonable for us to keep the
> default at C++98/03 forever. GCC has already taken the plunge here, so a lot
> of open-source code that doesn't work in C++11 onwards already explicitly
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274220: AMDGPU: Set amdgpu_kernel calling convention for
OpenCL kernels. (authored by nhaustov).
Changed prior to commit:
http://reviews.llvm.org/D21367?vs=62198&id=62343#toc
Repository:
rL LLVM
htt
Author: d0k
Date: Thu Jun 30 04:17:46 2016
New Revision: 274221
URL: http://llvm.org/viewvc/llvm-project?rev=274221&view=rev
Log:
Enable opencl driver tests, which never ran.
Then mark it as XFAIL because it always fails. I'll let OpenCL people
figure this out.
Modified:
cfe/trunk/test/Drive
The opencl.cl test never ran due to a lit misconfiguration (see
r274221). Now that's fixed but the test doesn't pass, so I marked it
as XFAIL. Can you take a look?
On Wed, Jun 29, 2016 at 9:39 PM, Yaxun Liu via cfe-commits
wrote:
> Author: yaxunl
> Date: Wed Jun 29 14:39:32 2016
> New Revision: 2
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D21637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ioeric added a comment.
Ping
http://reviews.llvm.org/D21601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added a comment.
Ping
http://reviews.llvm.org/D21602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dpolukhin
Date: Thu Jun 30 04:40:38 2016
New Revision: 274222
URL: http://llvm.org/viewvc/llvm-project?rev=274222&view=rev
Log:
[GCC] PR23529 Mangler part of attrbute abi_tag support
Original patch by Stefan Bühler http://reviews.llvm.org/D12834
Difference between original and this one:
rmaprath added a subscriber: rmaprath.
rmaprath added a comment.
Small side question: so how are `__m_` and `__cv_` initialized in this setup?
is it that `pthread_mutex_lock()` and the like would be able to handle an
un-initialized blob of memory (in a thread-safe way)? Because I don't see a
ca
EricWF added a comment.
In http://reviews.llvm.org/D21637#471151, @rmaprath wrote:
> Small side question: so how are `__m_` and `__cv_` initialized in this setup?
> is it that `pthread_mutex_lock()` and the like would be able to handle an
> un-initialized blob of memory (in a thread-safe way)?
rmaprath added a comment.
In http://reviews.llvm.org/D21637#471154, @EricWF wrote:
> In http://reviews.llvm.org/D21637#471151, @rmaprath wrote:
>
> > Small side question: so how are `__m_` and `__cv_` initialized in this
> > setup? is it that `pthread_mutex_lock()` and the like would be able to
Author: dpolukhin
Date: Thu Jun 30 06:15:52 2016
New Revision: 274223
URL: http://llvm.org/viewvc/llvm-project?rev=274223&view=rev
Log:
Fix CodeGenCXX/mangle-abi-tag.cpp on clang-ppc64le-linux bot
Modified:
cfe/trunk/test/CodeGenCXX/mangle-abi-tag.cpp
Modified: cfe/trunk/test/CodeGenCXX/mang
john.brawn added a comment.
Ping
Repository:
rL LLVM
http://reviews.llvm.org/D21385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:234
@@ +233,3 @@
+ std::string MinimizedFilePath = minimizeInclude(
+ ((FilePath[0] == '"' || FilePath[0] == '<') ? FilePath
+ : "\"" + File
ioeric updated this revision to Diff 62352.
ioeric added a comment.
- Always handle error.
http://reviews.llvm.org/D21602
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/tool/ClangIncludeFixer.cpp
unittests/clang-tidy/ClangTidyTest.h
unittests/include-
On Tue, Mar 22, 2016 at 1:09 AM, Justin Lebar via cfe-commits
wrote:
> Author: jlebar
> Date: Mon Mar 21 19:09:25 2016
> New Revision: 264008
>
> URL: http://llvm.org/viewvc/llvm-project?rev=264008&view=rev
> Log:
> [sema] [CUDA] Use std algorithms in EraseUnwantedCUDAMatchesImpl.
>
> Summary: NFC
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274224: [AVX512][BUILTIN][vpermilps][intrinsics] Fixing two
incorrect IMM check. (authored by mzuckerm).
Changed prior to commit:
http://reviews.llvm.org/D21836?vs=62212&id=62353#toc
Repository:
rL L
Author: mzuckerm
Date: Thu Jun 30 07:12:20 2016
New Revision: 274224
URL: http://llvm.org/viewvc/llvm-project?rev=274224&view=rev
Log:
[AVX512][BUILTIN][vpermilps][intrinsics] Fixing two incorrect IMM check.
Differential Revision: http://reviews.llvm.org/D21836
Modified:
cfe/trunk/lib/Sema/
On Thu, Jun 30, 2016 at 06:37:59AM +, Eric Fiselier wrote:
> EricWF requested changes to this revision.
> EricWF added a comment.
> This revision now requires changes to proceed.
>
> C++03 does not support default member initializers but libc++ provides both
> of these classes an extensions i
hokein updated this revision to Diff 62354.
hokein added a comment.
enumType is already in ASTMatcher now.
http://reviews.llvm.org/D21833
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-using-decls.cpp
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D21833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
murrayc updated this revision to Diff 62355.
murrayc marked an inline comment as done.
murrayc added a comment.
Same as previous patch, but with a tiny suggested whitespace corretion.
http://reviews.llvm.org/D20857
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ExplicitOper
murrayc added a comment.
I'd still be perfectly happy if just the simple check for implicit operator
bool was accepted.
http://reviews.llvm.org/D20857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
bcraig added a comment.
In http://reviews.llvm.org/D21803#470564, @joerg wrote:
> On the topic of __cxa_thread_atexit, was it ever specified how it interacts
> with things like thread cancellation?
I don't think it's officially specified anywhere. C++ threads don't have a
cancel method. The
Author: nhaustov
Date: Thu Jun 30 04:06:33 2016
New Revision: 274220
URL: http://llvm.org/viewvc/llvm-project?rev=274220&view=rev
Log:
AMDGPU: Set amdgpu_kernel calling convention for OpenCL kernels.
Summary:
Summary:
Change Clang calling convention SpirKernel to OpenCLKernel.
Set calling convent
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274222: [GCC] PR23529 Mangler part of attrbute abi_tag
support (authored by dpolukhin).
Changed prior to commit:
http://reviews.llvm.org/D18035?vs=62213&id=62344#toc
Repository:
rL LLVM
http://revie
vbyakovl updated this revision to Diff 62345.
http://reviews.llvm.org/D21678
Files:
llvm/tools/clang/lib/Sema/SemaExpr.cpp
llvm/tools/clang/test/Sema/shift.c
Index: llvm/tools/clang/lib/Sema/SemaExpr.cpp
===
--- llvm/tools/clang
DmitryPolukhin added a comment.
Richard, thank you for the review!
I decided to commit this patch without waiting for GCC response to
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71712 (that is last compatibility
issues in comparison with GCC6) so more people could test Clang implementation
of
elram updated this revision to Diff 62339.
http://reviews.llvm.org/D21637
Files:
include/__mutex_base
Index: include/__mutex_base
===
--- include/__mutex_base
+++ include/__mutex_base
@@ -34,16 +34,20 @@
class _LIBCPP_TYPE_VIS
mboehme created this revision.
mboehme added a reviewer: klimek.
mboehme added a subscriber: cfe-commits.
CFG generation is expected to fail in this case, but it should not crash.
Also added a test that reproduces the crash.
http://reviews.llvm.org/D21895
Files:
lib/Analysis/CFG.cpp
unittes
klimek added inline comments.
Comment at: unittests/Analysis/CFGTest.cpp:49
@@ +48,3 @@
+ std::vector Args = {"-std=c++11"};
+ ASSERT_TRUE(tooling::runToolOnCodeWithArgs(Factory->create(), Code, Args));
+}
I think we want to assert that we at least found func on
Author: marshall
Date: Thu Jun 30 10:11:53 2016
New Revision: 274235
URL: http://llvm.org/viewvc/llvm-project?rev=274235&view=rev
Log:
Implement LWG#2436: 'Comparators for associative containers should always be
CopyConstructible'
Added:
libcxx/trunk/test/std/containers/associative/map/map.
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D21705
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm Doing this in CodeGen seems right.
http://reviews.llvm.org/D21337
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Author: marshall
Date: Thu Jun 30 10:28:38 2016
New Revision: 274236
URL: http://llvm.org/viewvc/llvm-project?rev=274236&view=rev
Log:
Implement LWG#2441: 'Exact-width atomic typedefs should be provided'
Modified:
libcxx/trunk/include/atomic
libcxx/trunk/test/std/atomics/atomics.types.gen
We will take a look. Thanks.
Sam
-Original Message-
From: Benjamin Kramer [mailto:benny@gmail.com]
Sent: Thursday, June 30, 2016 5:27 AM
To: Liu, Yaxun (Sam) ; Shi, Aaron (en ye)
; anastasia.stul...@arm.com
Cc: cfe-commits
Subject: Re: r274150 - [OpenCL] Allow -cl-std and other sta
mboehme updated this revision to Diff 62374.
http://reviews.llvm.org/D21895
Files:
lib/Analysis/CFG.cpp
unittests/Analysis/CFGTest.cpp
unittests/Analysis/CMakeLists.txt
unittests/CMakeLists.txt
Index: unittests/CMakeLists.txt
==
mboehme marked an inline comment as done.
mboehme added a comment.
http://reviews.llvm.org/D21895
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Thu Jun 30 10:50:55 2016
New Revision: 274241
URL: http://llvm.org/viewvc/llvm-project?rev=274241&view=rev
Log:
Implement LWG#2596: 'vector::data() should use addressof'
Modified:
libcxx/trunk/test/std/containers/sequences/vector/vector.data/data.pass.cpp
libcxx/tr
Author: marshall
Date: Thu Jun 30 11:03:50 2016
New Revision: 274243
URL: http://llvm.org/viewvc/llvm-project?rev=274243&view=rev
Log:
Implement LWG#2684: 'priority_queue lacking comparator typedef'. We already did
this, just added tests
Modified:
libcxx/trunk/test/std/containers/container.
Anastasia updated this revision to Diff 62376.
Anastasia added a comment.
- Fixed style issues
- Added warning diagnostics for conversions of integer types
http://reviews.llvm.org/D20249
Files:
include/clang/AST/Type.h
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
incl
dimitry added inline comments.
Comment at: src/cxa_thread_atexit.cpp:46
@@ +45,3 @@
+ pthread_key_delete(key_);
+}
+
bcraig wrote:
> dimitry wrote:
> > run_dtors() is called when/if libc++.so gets unloaded... but only for the
> > thread calling dlclose()
Anastasia marked 12 inline comments as done.
Comment at: lib/CodeGen/CGBuiltin.cpp:2180-2181
@@ +2179,4 @@
+}
+// Could have events and/or vaargs.
+if (NumArgs >= 5) {
+ if (E->getArg(3)->getType()->isBlockPointerType()) {
bader wrote:
> [Style] M
Hahnfeld added a comment.
Hi Carlo,
I think these tests are not yet committed, right?
Thanks,
Jonas
Repository:
rL LLVM
http://reviews.llvm.org/D18286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: lib/Basic/Cuda.cpp:8-19
@@ +7,14 @@
+
+const char *CudaVersionToString(CudaVersion V) {
+ switch (V) {
+ case CudaVersion::UNKNOWN:
+return "unknown";
+ cas
Anastasia added a subscriber: Anastasia.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8595
@@ -8594,3 +8594,3 @@
-/// \brief Return the resulting type when an OpenCL vector is shifted
+/// \brief Return the resulting type when an vector is shifted
///by a scalar o
bruening added inline comments.
Comment at: docs/CSI.rst:75
@@ +74,3 @@
+ % clang++ -c -O3 -g -fcsi -emit-llvm bar.cpp -o bar.o
+ % clang++ foo.o bar.o my-tool.o libclang_rt.csi-x86_64.a -fuse-ld=gold -flto
-lrt -ldl -o foo
+
See below: the sanitizers pass the
weimingz added a comment.
In http://reviews.llvm.org/D21706#471091, @EricWF wrote:
> Please make the changes in the above comment.
Sure. I'm working on it. Just got interrupted/distracted by other tasks time to
time. :(
http://reviews.llvm.org/D21706
__
Author: rnk
Date: Thu Jun 30 12:41:27 2016
New Revision: 274245
URL: http://llvm.org/viewvc/llvm-project?rev=274245&view=rev
Log:
Port some more debug info tests on Windows
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-line.cpp
cfe/trunk/test/CodeGenCXX/debug-info-namespace.cpp
cfe/t
jlebar added a comment.
> But I think this is a reasonable workaround until such an API can be provided.
Should I take that as an LG, or are we waiting for someone else to approve this?
http://reviews.llvm.org/D21810
___
cfe-commits mailing list
c
Author: rnk
Date: Thu Jun 30 12:41:31 2016
New Revision: 274246
URL: http://llvm.org/viewvc/llvm-project?rev=274246&view=rev
Log:
[codeview] Emit qualified display names if -gline-tables-only is on
When -gmlt is on, we don't emit namespace or class scope information,
and the CodeView emission cod
hokein added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:234
@@ +233,3 @@
+ std::string MinimizedFilePath = minimizeInclude(
+ ((FilePath[0] == '"' || FilePath[0] == '<') ? FilePath
+ : "\"" + FileP
Author: marshall
Date: Thu Jun 30 12:52:51 2016
New Revision: 274252
URL: http://llvm.org/viewvc/llvm-project?rev=274252&view=rev
Log:
Implement LWG#2688: 'clamp misses preconditions and has extraneous condition on
result'. We already did this, just added tests
Modified:
libcxx/trunk/test/st
hokein updated this revision to Diff 62383.
hokein marked 4 inline comments as done.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D21603
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/SymbolIndexManager.cpp
include-fix
Author: marshall
Date: Thu Jun 30 12:49:36 2016
New Revision: 274250
URL: http://llvm.org/viewvc/llvm-project?rev=274250&view=rev
Log:
Temporarily XFAIL the incomplete type tests for GCC while I figure out why
adding a static_assert in r274235 broken them
Modified:
libcxx/trunk/test/std/cont
David and Paul,
Do you think I should enable this behavior for DWARF as well? We only emit
a DW_TAG_subprogram when a function is inlined or contains inlined
functions, which might not be that many. IIRC Paul did something similar
with DW_AT_linkage_name, and the object file size cost wasn't that
Author: marshall
Date: Thu Jun 30 12:59:01 2016
New Revision: 274253
URL: http://llvm.org/viewvc/llvm-project?rev=274253&view=rev
Log:
Mark issues 2667, 2669, 2670, 2671, 2673 as complete. These issues are wording
clarifications; no code changes required.
Modified:
libcxx/trunk/www/cxx1z_sta
Author: marshall
Date: Thu Jun 30 13:05:19 2016
New Revision: 274255
URL: http://llvm.org/viewvc/llvm-project?rev=274255&view=rev
Log:
Mark issues 2550, 2551, 2555, 2685, 2698 as complete. These issues are wording
clarifications; no code changes required.
Modified:
libcxx/trunk/www/cxx1z_sta
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D21810#471486, @jlebar wrote:
> > But I think this is a reasonable workaround until such an API can be
> > provided.
>
>
> Should I take that as an LG, or are
Author: jlebar
Date: Thu Jun 30 13:12:25 2016
New Revision: 274257
URL: http://llvm.org/viewvc/llvm-project?rev=274257&view=rev
Log:
Don't instantiate a full host toolchain in ASTMatchersTest.
Summary:
This test was stat()'ing large swaths of /usr/lib hundreds of times, as
every invocation of mat
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274257: Don't instantiate a full host toolchain in
ASTMatchersTest. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D21810?vs=62132&id=62385#toc
Repository:
rL LLVM
http://rev
tavianator updated this revision to Diff 62386.
tavianator added a comment.
Fixed some corner cases regarding destruction order and very-late-initialized
thread_locals. Explicitly documented the known limitations compared to
__cxa_thread_atexit_impl().
http://reviews.llvm.org/D21803
Files:
tavianator marked 3 inline comments as done.
tavianator added a comment.
In http://reviews.llvm.org/D21803#470448, @bcraig wrote:
> What that means for this implementation is that I think that
> _cxa_thread_atexit is allowed to be called during run_dtors. If running the
> dtor for a thread loc
tavianator updated this revision to Diff 62388.
tavianator added a comment.
Added missing __dso_handle declaration.
http://reviews.llvm.org/D21803
Files:
cmake/config-ix.cmake
src/CMakeLists.txt
src/cxa_thread_atexit.cpp
test/CMakeLists.txt
test/cxa_thread_atexit_test.pass.cpp
test/
Author: rsmith
Date: Thu Jun 30 13:36:34 2016
New Revision: 274260
URL: http://llvm.org/viewvc/llvm-project?rev=274260&view=rev
Log:
PR28373: fix crash-on-invalid if the condition of an if-statement fails
typo-correction.
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
cfe/trunk/test/SemaCXX/c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274261: [CUDA] Give templated device functions internal
linkage, templated kernels… (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D21337?vs=60728&id=62391#toc
Repository:
rL
Author: jlebar
Date: Thu Jun 30 13:41:33 2016
New Revision: 274261
URL: http://llvm.org/viewvc/llvm-project?rev=274261&view=rev
Log:
[CUDA] Give templated device functions internal linkage, templated kernels
external linkage.
Summary:
This lets LLVM perform IPO over these functions. In particul
tavianator updated this revision to Diff 62394.
tavianator added a comment.
Fix copy-pasta that result in an infinite loop.
http://reviews.llvm.org/D21803
Files:
cmake/config-ix.cmake
src/CMakeLists.txt
src/cxa_thread_atexit.cpp
test/CMakeLists.txt
test/cxa_thread_atexit_test.pass.cpp
rsmith added a comment.
There are a few missing pieces here:
1. Analysis/CFG.cpp needs to be taught to build a correct CFG for these. You
can test this with an example like 'if (bool b; b)' which should give a
-Wuninitialized warning.
2. AST/ExprConstant.cpp needs to be taught to perform consta
carlo.bertolli added a comment.
Hi
Yes, the purpose of these patches was to check correctness of code gen for the
related clauses when targeting nvptx exclusively.
Since I wrote these tests, the base support changed to generate same code on
host and any device type, and it seemed to me that the
jlebar marked an inline comment as done.
Comment at: lib/Basic/Cuda.cpp:8-19
@@ +7,14 @@
+
+const char *CudaVersionToString(CudaVersion V) {
+ switch (V) {
+ case CudaVersion::UNKNOWN:
+return "unknown";
+ case CudaVersion::CUDA_70:
+return "7.0";
+ case CudaVersion::C
bcraig added inline comments.
Comment at: src/cxa_thread_atexit.cpp:47
@@ +46,3 @@
+ void run_dtors(void* ptr) {
+if (pthread_setspecific(dtors, ptr) != 0) {
+ abort_message("pthread_setspecific() failed during thread_local
destruction");
Why are we doi
Seems this commit broke a builder,
http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6
http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/26133
http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/26134
TEST 'Clang-Unit ::
ASTMatchers/ASTMatchersTests/Declaratio
tavianator added inline comments.
Comment at: src/cxa_thread_atexit.cpp:47
@@ +46,3 @@
+ void run_dtors(void* ptr) {
+if (pthread_setspecific(dtors, ptr) != 0) {
+ abort_message("pthread_setspecific() failed during thread_local
destruction");
bcraig wro
bcraig added a comment.
Also, can you add test cases for a lot of these things? I don't expect test
cases for the DSO side of things, but a lot of the tricky atexit cases should
be covered.
http://reviews.llvm.org/D21803
___
cfe-commits mailing l
tra added inline comments.
Comment at: lib/Driver/Driver.cpp:1026-1028
@@ -1024,4 +1025,5 @@
} else if (CudaDeviceAction *CDA = dyn_cast(A)) {
-os << '"'
- << (CDA->getGpuArchName() ? CDA->getGpuArchName() : "(multiple archs)")
+os << '"' << (CDA->getGpuArch() !=
jlebar marked an inline comment as done.
Comment at: lib/Driver/Driver.cpp:1026-1028
@@ -1024,4 +1025,5 @@
} else if (CudaDeviceAction *CDA = dyn_cast(A)) {
-os << '"'
- << (CDA->getGpuArchName() ? CDA->getGpuArchName() : "(multiple archs)")
+os << '"' << (CDA->ge
Author: rsmith
Date: Thu Jun 30 15:24:30 2016
New Revision: 274267
URL: http://llvm.org/viewvc/llvm-project?rev=274267&view=rev
Log:
Fix typo-correction crash if a typo occurs within the operand of a
function-style cast to a non-dependent type which is then used in an invalid
way. We'd lose the "t
Author: jlebar
Date: Thu Jun 30 15:29:29 2016
New Revision: 274269
URL: http://llvm.org/viewvc/llvm-project?rev=274269&view=rev
Log:
Fix ASTMatchersNodeTest to work on Windows.
It was failing because it had an explicit check for whether we're on
Windows.
There are a few other similar explicit ch
On Thu, Jun 30, 2016 at 2:02 AM, David Chisnall wrote:
> On 29 Jun 2016, at 23:07, Richard Smith via cfe-dev <
> cfe-...@lists.llvm.org> wrote:
> >
> > Yes, those are real problems, but it's not reasonable for us to keep the
> default at C++98/03 forever. GCC has already taken the plunge here, so
rsmith added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:438
@@ -426,1 +437,3 @@
+}
EmitAnyExprToMem(E, Object, Qualifiers(), /*IsInit*/true);
+if (Size) {
Seems like you should push the cleanup before you emit the initializer; the
cleanup sh
tra added inline comments.
Comment at: lib/Driver/Driver.cpp:1026-1028
@@ -1024,4 +1025,5 @@
} else if (CudaDeviceAction *CDA = dyn_cast(A)) {
-os << '"'
- << (CDA->getGpuArchName() ? CDA->getGpuArchName() : "(multiple archs)")
+os << '"' << (CDA->getGpuArch() !=
erik.pilkington updated this revision to Diff 62405.
erik.pilkington added a comment.
This new patch addresses all of Richard's comments.
http://reviews.llvm.org/D21619
Files:
include/clang/Sema/Initialization.h
include/clang/Sema/Sema.h
lib/Sema/SemaStmt.cpp
test/CXX/drs/dr15xx.cpp
t
Interestingly all the clang tests pass with that whole line commented
out. So something *really* seems missing here.
Thank you for finding this.
On Thu, Jun 30, 2016 at 5:08 AM, Benjamin Kramer wrote:
> On Tue, Mar 22, 2016 at 1:09 AM, Justin Lebar via cfe-commits
> wrote:
>> Author: jlebar
>>
jlebar updated this revision to Diff 62409.
jlebar added a comment.
Address Art's review.
http://reviews.llvm.org/D21867
Files:
include/clang/Basic/Cuda.h
include/clang/Driver/Action.h
lib/Basic/CMakeLists.txt
lib/Basic/Cuda.cpp
lib/Basic/Targets.cpp
lib/Driver/Action.cpp
lib/Driv
jlebar marked 4 inline comments as done.
jlebar added a comment.
http://reviews.llvm.org/D21867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
http://reviews.llvm.org/D21619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Thank you, fix in r274269.
On Thu, Jun 30, 2016 at 12:57 PM, Yaron Keren wrote:
> Seems this commit broke a builder,
> http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6
>
> http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/26133
> http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/bui
Author: ericwf
Date: Thu Jun 30 15:46:58 2016
New Revision: 274274
URL: http://llvm.org/viewvc/llvm-project?rev=274274&view=rev
Log:
Fix C++03 build.
Modified:
libcxx/trunk/test/std/containers/unord/unord.map/unord.map.cnstr/compare_copy_constructible.fail.cpp
libcxx/trunk/test/std/cont
brzycki created this revision.
brzycki added reviewers: abdulras, rengolin, jmolloy.
brzycki added subscribers: cfe-commits, sebpop, evandro.
Herald added subscribers: rengolin, aemerson.
The GNU profiling support indicates that the interface is `_mcount` rather than
`mcount` on GLIBC Linux for A
Author: spatel
Date: Thu Jun 30 16:02:40 2016
New Revision: 274278
URL: http://llvm.org/viewvc/llvm-project?rev=274278&view=rev
Log:
fix typo; NFC
Modified:
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe
sebpop added a comment.
LGTM.
http://reviews.llvm.org/D21907
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Thu Jun 30 17:05:45 2016
New Revision: 274285
URL: http://llvm.org/viewvc/llvm-project?rev=274285&view=rev
Log:
Fix static assert problem on gcc; remove XFAILs that I put in in r274250
Modified:
libcxx/trunk/include/__hash_table
libcxx/trunk/include/__tree
libcx
timshen updated this revision to Diff 62433.
timshen added a comment.
Done. Added a new testcase to ensure the correct behavior with exceptions
turned on.
http://reviews.llvm.org/D20499
Files:
lib/CodeGen/CGCleanup.cpp
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFu
1 - 100 of 147 matches
Mail list logo
