Re: [PATCH] D20499: [Temporary, Lifetime] Add lifetime marks for temporaries

[Richard Smith via cfe-commits]

rsmith added inline comments.

================
Comment at: lib/CodeGen/CGExpr.cpp:438
@@ -426,1 +437,3 @@
+    }
     EmitAnyExprToMem(E, Object, Qualifiers(), /*IsInit*/true);
+    if (Size) {
----------------
Seems like you should push the cleanup before you emit the initializer; the 
cleanup should run if the initializer throws.


http://reviews.llvm.org/D20499



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits