atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
mprobst marked an inline comment as done.
Comment at: lib/Format/SortJavaScriptImports.cpp:77
@@ +76,3 @@
+return false;
+ // NB: empty URLs sort *last* (for export {...};).
+ if (LHS.URL.empty() != RHS.URL.empty())
djasper wrote:
> NB?
"Nota bene". Seems to
mprobst updated this revision to Diff 57438.
mprobst marked an inline comment as done.
mprobst added a comment.
- extract TokenAnalyzer.h and SortJavaScriptImports.h/cpp
- clean up imports/
- includes
- address review comments
- pull out implementations from header files.
- support side effect imp
mprobst updated this revision to Diff 57440.
mprobst marked an inline comment as done.
mprobst added a comment.
- review comments
http://reviews.llvm.org/D20198
Files:
include/clang/Format/Format.h
lib/Format/CMakeLists.txt
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/For
Hi ,
Yes, I saw the thread.
We have an internal discussion on this subject.
Regards,
Michael Zuckerman
From: tha...@google.com [mailto:tha...@google.com] On Behalf Of Nico Weber
Sent: Monday, May 16, 2016 22:06
To: Zuckerman, Michael
Cc: cfe-commits
Subject: Re: r269680 - [Clang][AVX512] complet
Hi guys,
I just wanted to check up on this patch. I heard I could just reply to this
mail and see if I could 'ping' anyone in this regard. Hope it's OK.
Best regards,
Mads Ravn
On Thu, May 12, 2016 at 6:11 PM Mads Ravn wrote:
> Hi,
>
> I have fixed the things you mentioned now. I have attached
rogfer01 updated this revision to Diff 57451.
rogfer01 added a comment.
Update test from mrasext to mras
http://reviews.llvm.org/D20283
Files:
lib/Driver/Tools.cpp
test/Driver/aarch64-ras.c
test/Driver/arm-ras.c
Index: test/Driver/arm-ras.c
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269754: [Mips] Set mips32 as default CPU for MIPS32 Android
(authored by petarj).
Changed prior to commit:
http://reviews.llvm.org/D20313?vs=57423&id=57454#toc
Repository:
rL LLVM
http://reviews.llv
Author: petarj
Date: Tue May 17 05:46:10 2016
New Revision: 269754
URL: http://llvm.org/viewvc/llvm-project?rev=269754&view=rev
Log:
[Mips] Set mips32 as default CPU for MIPS32 Android
Change default CPU for MIPS32 Android. Now it is mips32 (rev1).
Differential Revision: http://reviews.llvm.org/
rmaprath created this revision.
rmaprath added reviewers: jroelofs, bcraig.
rmaprath added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
This is a follow-up to D20119.
`unwind_phase1` and `unwind_phase2` allocate their own copies of `unw_cursor_t`
buffers on the stack. This can
igorb created this revision.
igorb added reviewers: m_zuckerman, AsafBadouh, delena.
igorb added a subscriber: cfe-commits.
igorb set the repository for this revision to rL LLVM.
[Clang][AVX512][intrinsics] Fix vperm{w|d|q|ps|pd} intrinsics. Index is first
argument to buildin function.
Reposit
Hi,
The below commit enables all OpenCL extensions for the SPIR target by default.
This incorrect, as SPIR allows you to specify which extensions are
enabled/disabled its metadata. This means that any SPIR generated by Clang may
now be rejected by specific OpenCL platforms, because they might
Anastasia added a comment.
Looking good already! I just have one general concern about committing 16K
lines of code with no tests. But perhaps testing all the declarations isn't an
option actually.
Could we at least have a test that includes the header and makes sure it's
compiled successfully
Hi,
The below commit is, as it enables half arguments and returns by default for
OpenCL, while this is actually an extension that might not be supported on all
platforms. I think that this part of the commit should be reverted:
> --- cfe/trunk/lib/Frontend/CompilerInvocation.cpp (original)
> ++
courbet updated this revision to Diff 57462.
courbet added a comment.
Use iterator_range instead of ArrayRef for overridden_methods
http://reviews.llvm.org/D19324
Files:
docs/LibASTMatchersReference.html
include/clang/AST/ASTContext.h
include/clang/AST/DeclCXX.h
include/clang/ASTMatcher
Author: d0k
Date: Tue May 17 07:35:18 2016
New Revision: 269758
URL: http://llvm.org/viewvc/llvm-project?rev=269758&view=rev
Log:
[include-fixer] Make the "extend to the right" hack support typos without
nested names in the front.
This handles cases where the initial namespace is unknown.
Modif
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, with one minor nit. Thank you for working on this!
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724
@@ +3723,3 @@
+ bool Matched = false;
+ for (
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:39
@@ +38,3 @@
+
+ // FIXME: Add paren matching so we can parse more complex throw statements,
+ // e.g., (examples provided by Aaron Ballman):
@alexfh, what are your feel
pekka.jaaskelainen added a comment.
LGTM, FWIW.
http://reviews.llvm.org/D20249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath created this revision.
rmaprath added reviewers: mclow.lists, EricWF, bcraig.
rmaprath added a subscriber: cfe-commits.
This patch builds on the work done under D19412 where all `pthread`
dependencies were refactored under a separate thread-support API.
The current patch enables buildin
rmaprath abandoned this revision.
rmaprath added a comment.
Superseded by http://reviews.llvm.org/D20328.
http://reviews.llvm.org/D19415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
rengolin requested changes to this revision.
rengolin added a comment.
This revision now requires changes to proceed.
Please, re-submit this change once the documents have been made public.
Feel free to submit the assembly test to LLVM, using llc, on their own.
cheers,
--renato
===
Author: hokein
Date: Tue May 17 08:38:18 2016
New Revision: 269762
URL: http://llvm.org/viewvc/llvm-project?rev=269762&view=rev
Log:
[find-all-symbols] Ignore anonymous enum declarations.
Modified:
clang-tools-extra/trunk/include-fixer/find-all-symbols/FindAllSymbols.cpp
clang-tools-extr
hokein updated this revision to Diff 57472.
hokein added a comment.
Rebase.
http://reviews.llvm.org/D19816
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbols.cpp
include-fixer/find-all-symbols/FindAllSymbols.h
include-fixer/find-all-symbol
courbet added a comment.
Thanks. Could please you submit this for me ?
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724
@@ +3723,3 @@
+ bool Matched = false;
+ for (const auto *Overridden : Node.overridden_methods()) {
+BoundNodesTreeBuilder OverriddenBuilder(*Buil
courbet updated this revision to Diff 57473.
courbet added a comment.
cometics
http://reviews.llvm.org/D19324
Files:
docs/LibASTMatchersReference.html
include/clang/AST/ASTContext.h
include/clang/AST/DeclCXX.h
include/clang/ASTMatchers/ASTMatchers.h
lib/AST/ASTContext.cpp
lib/AST/De
ioeric created this revision.
ioeric added reviewers: bkramer, hokein.
ioeric added a subscriber: cfe-commits.
[clang-include-fixer] Added Vim integration for clang-include-fixer.
http://reviews.llvm.org/D20329
Files:
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/tool/clang-include-
bkramer added inline comments.
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:51
@@ +50,3 @@
+cl::opt
+VimMode("vim",
+cl::desc("Run the tool on a potentially unsaved buffer from Vim"),
This isn't really specific to vim, we should name it dif
Author: filcab
Date: Tue May 17 09:07:43 2016
New Revision: 269765
URL: http://llvm.org/viewvc/llvm-project?rev=269765&view=rev
Log:
Revert "[X86] Add immediate range checks for many of the builtins."
This reverts commit r269619.
Modified:
cfe/trunk/lib/Sema/SemaChecking.cpp
cfe/trunk/te
hokein added inline comments.
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:51
@@ +50,3 @@
+cl::opt
+VimMode("vim",
+cl::desc("Run the tool on a potentially unsaved buffer from Vim"),
bkramer wrote:
> This isn't really specific to vim, we sh
klimek added inline comments.
Comment at: include/clang/Format/Format.h:855
@@ -854,1 +854,3 @@
+// \brief Returns a string representation of ``Language`` for debugging.
+inline StringRef getLanguageName(FormatStyle::LanguageKind Language) {
s/for debugging/.
Or
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG with nit to fix.
Comment at: include-fixer/find-all-symbols/FindAllSymbols.h:44-45
@@ -41,2 +43,4 @@
- explicit FindAllSymbols(ResultReporter *Reporter) : Reporter(Repor
Author: cameron314
Date: Tue May 17 09:34:53 2016
New Revision: 269769
URL: http://llvm.org/viewvc/llvm-project?rev=269769&view=rev
Log:
[PCH] Fixed bug with preamble invalidation when overridden files change
When remapped files were changed, they would not always cause the preamble's
PCH to be
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269769: [PCH] Fixed bug with preamble invalidation when
overridden files change (authored by cameron314).
Changed prior to commit:
http://reviews.llvm.org/D20137?vs=57367&id=57477#toc
Repository:
rL
yaxunl updated this revision to Diff 57478.
yaxunl marked 8 inline comments as done.
yaxunl added a comment.
Revised as Anastasia suggested.
http://reviews.llvm.org/D19932
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/CGBuiltin.cpp
lib/Se
jroelofs added a comment.
Just one question, otherwise LGTM:
Comment at: src/UnwindCursor.hpp:580
@@ -579,3 +605,1 @@
_isSignalFrame(false) {
- static_assert(sizeof(UnwindCursor) < sizeof(unw_cursor_t),
-"UnwindCursor<> does not fit in unw_cursor_t");
---
Author: marshall
Date: Tue May 17 09:52:19 2016
New Revision: 269772
URL: http://llvm.org/viewvc/llvm-project?rev=269772&view=rev
Log:
Implement P0030R1: Introduce a 3-Argument Overload to std::hypot
Modified:
libcxx/trunk/include/cmath
libcxx/trunk/test/std/numerics/c.math/cmath.pass.cpp
alexfh added inline comments.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:24
@@ +23,3 @@
+AST_MATCHER(CallExpr, hasUnresolvedLookupExpr) {
+ return isa(Node.getCallee());
+}
I think, we should use a node matcher for `UnresolvedLookupExpr` and instead
u
Author: marshall
Date: Tue May 17 09:58:09 2016
New Revision: 269773
URL: http://llvm.org/viewvc/llvm-project?rev=269773&view=rev
Log:
Add some checking so that the TEST_HAS_XXX macros match up with the
_LIBCPP_NO_HAS_XXX macros. No functional change
Modified:
libcxx/trunk/test/libcxx/selfte
rmaprath added inline comments.
Comment at: src/UnwindCursor.hpp:580
@@ -579,3 +605,1 @@
_isSignalFrame(false) {
- static_assert(sizeof(UnwindCursor) < sizeof(unw_cursor_t),
-"UnwindCursor<> does not fit in unw_cursor_t");
jroelofs wrote:
>
Hello,
>>> CUDA? In any case, I don't see how the restriction helps users, and the
>>> attribute at the IR level has a well-defined meaning regardless. If a user
>>> were to have a use case, they'd simply find the restriction arbitrary and
>>> frustrating.
>>
>> Yes, CUDA was already considere
ioeric updated this revision to Diff 57484.
ioeric marked 4 inline comments as done.
ioeric added a comment.
- Changed VimMode to STDINMode, and made clang-include-fixer return insertion
line number in this mode.
- Added -db, -input options into Vim integration.
http://reviews.llvm.org/D20329
ioeric added inline comments.
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:51
@@ +50,3 @@
+cl::opt
+VimMode("vim",
+cl::desc("Run the tool on a potentially unsaved buffer from Vim"),
hokein wrote:
> bkramer wrote:
> > This isn't really spec
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D20296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
rmaprath updated this revision to Diff 57487.
rmaprath added a comment.
Addressing review comments from @jroelofs:
- Moved the assertion in `libunwind.cpp` back to `UnwindCursor.cpp` where it
really belogs.
@jroelofs: I just realized that, with this new native-only build of
`libunwind`, users
dcoughlin added a comment.
Thanks for the patch! This looks like it will catch some nasty bugs.
My comments (inline) are mostly nits. But two are more substantial: (1) you
should add a path note where the self-assignment assumption is made explaining
the assumption to the user and (2) the poten
Is it possible to write a test for this?
On Tue, May 17, 2016 at 10:34 AM, Cameron Desrochers via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: cameron314
> Date: Tue May 17 09:34:53 2016
> New Revision: 269769
>
> URL: http://llvm.org/viewvc/llvm-project?rev=269769&view=rev
> Log:
>
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D19816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 57490.
hokein added a comment.
Add comments.
http://reviews.llvm.org/D19816
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbols.cpp
include-fixer/find-all-symbols/FindAllSymbols.h
include-fixer/find-all-
Author: hokein
Date: Tue May 17 11:48:49 2016
New Revision: 269779
URL: http://llvm.org/viewvc/llvm-project?rev=269779&view=rev
Log:
[find-all-symbols] Add IWYU private pragma support.
Reviewers: djasper, klimek
Subscribers: kimgr, cfe-commits, bkramer, ioeric
Differential Revision: http://revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269779: [find-all-symbols] Add IWYU private pragma support.
(authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D19816?vs=57493&id=57495#toc
Repository:
rL LLVM
http://reviews.llv
hokein updated this revision to Diff 57493.
hokein added a comment.
Rebase.
http://reviews.llvm.org/D19816
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbols.cpp
include-fixer/find-all-symbols/FindAllSymbols.h
include-fixer/find-all-symbol
Author: rnk
Date: Tue May 17 11:50:45 2016
New Revision: 269780
URL: http://llvm.org/viewvc/llvm-project?rev=269780&view=rev
Log:
Tentatively enable -Wcast-calling-convention by default
In Chrome, this would have found two true positives around CreateThread
if we hadn't already fixed them while r
Cool, r269780. Let's see if anyone finds any bugs or false positives.
On Mon, May 16, 2016 at 4:10 PM, Nico Weber wrote:
> After this tweak, Chromium builds cleanly with the new warning enabled.
> Maybe it's time to turn it on by default.
>
> On Wed, May 11, 2016 at 1:43 PM, Reid Kleckner via cfe
hokein updated this revision to Diff 57496.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D20326
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-using-decls.cpp
==
hokein marked an inline comment as done.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:24
@@ +23,3 @@
+AST_MATCHER(CallExpr, hasUnresolvedLookupExpr) {
+ return isa(Node.getCallee());
+}
alexfh wrote:
> I think, we should use a node matcher for `Unresolve
Author: rnk
Date: Tue May 17 11:54:40 2016
New Revision: 269781
URL: http://llvm.org/viewvc/llvm-project?rev=269781&view=rev
Log:
Fix calling convention test
Modified:
cfe/trunk/test/Sema/callingconv-cast.c
Modified: cfe/trunk/test/Sema/callingconv-cast.c
URL:
http://llvm.org/viewvc/llvm-pr
mprobst added a comment.
PTAL.
Comment at: lib/Format/SortJavaScriptImports.cpp:45-46
@@ +44,4 @@
+
+struct JsImportExport {
+ bool IsExport;
+ // JS imports are sorted into these categories, in order.
klimek wrote:
> klimek wrote:
> > This is really weird - a
mprobst updated this revision to Diff 57497.
mprobst marked 8 inline comments as done.
mprobst added a comment.
- address review comments
http://reviews.llvm.org/D20198
Files:
include/clang/Format/Format.h
lib/Format/CMakeLists.txt
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Fo
On Mon, May 16, 2016 at 3:53 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Mon May 16 17:53:19 2016
> New Revision: 269717
>
> URL: http://llvm.org/viewvc/llvm-project?rev=269717&view=rev
> Log:
> Switch from SmallVector to TinyPtrVector for the li
t.p.northover added a subscriber: t.p.northover.
t.p.northover added a comment.
I don't think we need to wait until the document is public, necessarily. The
entire AArch64 backend went in before the encodings were public outside ARM
(except maybe in binutils source?) and releasing specifications
rengolin added a comment.
In http://reviews.llvm.org/D20325#432086, @t.p.northover wrote:
> I don't think we need to wait until the document is public, necessarily. The
> entire AArch64 backend went in before the encodings were public outside ARM
> (except maybe in binutils source?) and releasi
Author: vedantk
Date: Tue May 17 12:26:02 2016
New Revision: 269786
URL: http://llvm.org/viewvc/llvm-project?rev=269786&view=rev
Log:
[clang-tidy] Skip misc-macro-parentheses for namespaces (Fix PR27400)
If a use of a macro argument is preceded by the `namespace` keyword, do
not warn that the use
> On May 17, 2016, at 2:59 AM, Mads Ravn wrote:
>
> Hi guys,
>
> I just wanted to check up on this patch. I heard I could just reply to this
> mail and see if I could 'ping' anyone in this regard. Hope it's OK.
Sorry for the delay! This looks good. Committed as r269786.
thanks,
vedant
>
>
rengolin added inline comments.
Comment at: include/clang/Basic/BuiltinsARM.def:55
@@ -54,3 +54,3 @@
BUILTIN(__builtin_arm_mrc2, "UiUIiUIiUIiUIiUIi", "")
-BUILTIN(__builtin_arm_cdp, "vUiUiUiUiUiUi", "")
-BUILTIN(__builtin_arm_cdp2, "vUiUiUiUiUiUi", "")
+BUILTIN(__builtin_arm_cdp,
Author: rnk
Date: Tue May 17 12:33:31 2016
New Revision: 269787
URL: http://llvm.org/viewvc/llvm-project?rev=269787&view=rev
Log:
Fix line numbers in calling convention test
Modified:
cfe/trunk/test/Sema/callingconv-cast.c
Modified: cfe/trunk/test/Sema/callingconv-cast.c
URL:
http://llvm.or
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:39
@@ +38,3 @@
+
+ // FIXME: Add paren matching so we can parse more complex throw statements,
+ // e.g., (examples provided by Aaron Ballman):
aaron.ballman wrote:
> @alexfh,
jlebar added a comment.
Friendly ping. This is a big help with some Tensorflow benchmarks.
http://reviews.llvm.org/D19990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Tue May 17 12:44:40 2016
New Revision: 269789
URL: http://llvm.org/viewvc/llvm-project?rev=269789&view=rev
Log:
Implement LWG2576: istream_iterator and ostream_iterator should use
std::addressof
Modified:
libcxx/trunk/include/iterator
libcxx/trunk/www/cxx1z_status.
aaron.ballman added a comment.
The patch is missing semantic test cases. I would like to see tests of the
attribute being accepted, as well as rejected because the subject was
incorrect, args were provided, etc.
Also, I believe there are attributes which this attribute should not be
combined w
Author: mren
Date: Tue May 17 13:04:38 2016
New Revision: 269794
URL: http://llvm.org/viewvc/llvm-project?rev=269794&view=rev
Log:
NFC: simplify logic.
Modified:
cfe/trunk/lib/Lex/HeaderSearch.cpp
Modified: cfe/trunk/lib/Lex/HeaderSearch.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trun
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Thanks, lgtm!
http://reviews.llvm.org/D20171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269796: clang-rename: avoid StringRef members in
USRLocFindingASTVisitor (authored by vmiklos).
Changed prior to commit:
http://reviews.llvm.org/D20296?vs=57385&id=57503#toc
Repository:
rL LLVM
http
Author: vmiklos
Date: Tue May 17 13:17:16 2016
New Revision: 269796
URL: http://llvm.org/viewvc/llvm-project?rev=269796&view=rev
Log:
clang-rename: avoid StringRef members in USRLocFindingASTVisitor
Even if this is defined in the .cpp file and only used as part of the
function (so here it's safe)
ashi1 added a comment.
Xiuli, are you OK with this patch?
http://reviews.llvm.org/D17578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:24
@@ +23,3 @@
+// FIXME: Add a node matcher for UnresolvedLookupExpr in ASTMatcher.
+AST_MATCHER(CallExpr, hasUnresolvedLookupExpr) {
+
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thank you!
Comment at: clang-tidy/utils/Matchers.h:20
@@ -19,1 +19,3 @@
+AST_MATCHER_P(Expr, ignoringImplicit,
+ ast_matchers::internal::Matcher, InnerMatch
aaron.ballman added inline comments.
Comment at: clang-tidy/utils/Matchers.h:20
@@ -19,1 +19,3 @@
+AST_MATCHER_P(Expr, ignoringImplicit,
+ ast_matchers::internal::Matcher, InnerMatcher) {
alexfh wrote:
> Consider moving this to ASTMatchers.h in a fo
Author: yrnkrn
Date: Tue May 17 14:01:16 2016
New Revision: 269801
URL: http://llvm.org/viewvc/llvm-project?rev=269801&view=rev
Log:
Teach clang to look for libcxx in /usr/local/include/c++ on Linux
As The default CMAKE install prefix is /usr/local (
https://cmake.org/cmake/help/v3.0/variable/CM
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: docs/clang-tidy/checks/bugprone-bool-to-integer-conversion.rst:43
@@ +42,3 @@
+
+This is because z and ``true`` will be implicitly converted to int by
promotion.
+To get rid of t
rsmith added inline comments.
Comment at: include/clang/Basic/BuiltinsNVPTX.def:569-603
@@ -568,1 +568,37 @@
+// __ldg. This is not implemented as a builtin by nvcc.
+BUILTIN(__nvvm_ldg_c, "ccC*", "")
+BUILTIN(__nvvm_ldg_s, "ssC*", "")
+BUILTIN(__nvvm_ldg_i, "iiC*", "")
+BUILTI
ahatanak created this revision.
ahatanak added reviewers: mclow.lists, EricWF, howard.hinnant.
ahatanak added a subscriber: cfe-commits.
The end pointer should point to one past the end of the newly allocated buffer.
Without this fix, asan reports an error when the following code is compiled and
Author: etienneb
Date: Tue May 17 14:36:09 2016
New Revision: 269804
URL: http://llvm.org/viewvc/llvm-project?rev=269804&view=rev
Log:
[clang-tidy] Lift common matchers to utils namespace
Summary:
This patch is lifting matchers used by more than one checkers
to the common namespace.
Reviewers: a
Author: jvesely
Date: Tue May 17 14:44:01 2016
New Revision: 269807
URL: http://llvm.org/viewvc/llvm-project?rev=269807&view=rev
Log:
math: Use single precision fmax in sp path
Fixes fdim piglit on Turks
v2: use CL fmax instead of __builtin
Signed-off-by: Jan Vesely
Reviewed-by: Tom Stellard
Test coverage?
On Tue, May 17, 2016 at 10:44 AM, Marshall Clow via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: marshall
> Date: Tue May 17 12:44:40 2016
> New Revision: 269789
>
> URL: http://llvm.org/viewvc/llvm-project?rev=269789&view=rev
> Log:
> Implement LWG2576: istream_itera
Author: ericwf
Date: Tue May 17 14:52:32 2016
New Revision: 269812
URL: http://llvm.org/viewvc/llvm-project?rev=269812&view=rev
Log:
Add test for r269789
Modified:
libcxx/trunk/test/std/iterators/stream.iterators/istream.iterator/istream.iterator.ops/arrow.pass.cpp
Modified:
libcxx/trunk/t
I added a test for operator->() in r269812. Marshall and I discussed
offline about how not all parts of this change are testable (and hence not
meaningful) but that's what the standard says to do.
On Tue, May 17, 2016 at 1:51 PM, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
If some parts are not testable & as you say, not meaningful, then it seems
OK to just not implement them & file a DR on the standard, no?
On Tue, May 17, 2016 at 1:00 PM, Eric Fiselier wrote:
> I added a test for operator->() in r269812. Marshall and I discussed
> offline about how not all parts
The difference between "operator&" and "addressof" is inconsequential when
user defined overloads of "operator&" can't be found, which is the case for
the changes in the stream iterator constructors. We might as well keep it
consistent though. I don't see any value changing it back to use
"operato
yaxunl added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7820
@@ +7819,3 @@
+def err_opencl_function_not_supported : Error<
+ "this function is not supported in this version of CL">;
+def err_opencl_enqueue_kernel_incorrect_args : Error<
--
On Tue, May 17, 2016 at 10:17 AM, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Mon, May 16, 2016 at 3:53 PM, Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rsmith
>> Date: Mon May 16 17:53:19 2016
>> New Revision: 269717
>>
>> URL: http
Woops. I was incorrect. It seems that user defined "operator&" overloads
can be found in the constructor. From the LWG issue:
> Note that {i,o}stream_type are specializations of basic_{i,o}stream, but
the constructors might still pick up an overloaded & via the traits
template parameter.
At least
Or maybe I'm still wrong. I tried using a custom traits class to hijack ADL
for "operator&" but it doesn't seem to work.
Sorry for the spam.
/Eric
On Tue, May 17, 2016 at 2:25 PM, Eric Fiselier wrote:
> Woops. I was incorrect. It seems that user defined "operator&" overloads
> can be found in
rsmith added a comment.
Please also add some testcases for the corresponding case for a friend function
template:
template void f();
template struct A {
template void f() {}
};
template struct B {
template void f() {}
};
A a;
B b; // ill-formed
Comment at
Cool :) don't the sweat the time. I was just a little excited. Small patch
but it's nice to get started somewhere.
Best regards,
Mads Ravn
> On May 17, 2016, at 2:59 AM, Mads Ravn wrote:
>
> Hi guys,
>
> I just wanted to check up on this patch. I heard I could just reply to
this mail and see if
kzhuravl created this revision.
kzhuravl added a reviewer: arsenm.
kzhuravl added subscribers: whchung, cfe-commits.
Herald added a reviewer: tstellarAMD.
Herald added a subscriber: kzhuravl.
http://reviews.llvm.org/D20336
Files:
include/clang/Driver/Options.td
test/Driver/amdgpu-features.c
Author: ericwf
Date: Tue May 17 16:01:20 2016
New Revision: 269838
URL: http://llvm.org/viewvc/llvm-project?rev=269838&view=rev
Log:
Test hijacking ADL for operator& in the stream iterator constructors.
Modified:
libcxx/trunk/test/std/iterators/stream.iterators/ostream.iterator/ostream.itera
OK, I think I figured it out. I added tests for the ostream_iterator
constructors in r269838.
I'll follow that up with tests for the istream_iterator constructors, but
my current test is failing for reasons beyond me.
/Eric
On Tue, May 17, 2016 at 2:36 PM, Eric Fiselier wrote:
> Or maybe I'm st
alexfh added a comment.
In http://reviews.llvm.org/D19105#427046, @Prazek wrote:
> In http://reviews.llvm.org/D19105#426903, @alexfh wrote:
>
> > returning a bool from a function that is declared to return a typedef to an
> > integral type that contains `bool` in its name (e.g. `LLVMBool`), and
kzhuravl retitled this revision from "[AMDGPU] Remove individual debugger
options" to "[AMDGPU] Remove individual debugger options + update features".
kzhuravl updated this revision to Diff 57518.
kzhuravl added a comment.
Update features
http://reviews.llvm.org/D20336
Files:
include/clang/D
1 - 100 of 155 matches
Mail list logo
