alexfh requested changes to this revision.
This revision now requires changes to proceed.

================
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:24
@@ +23,3 @@
+// FIXME: Add a node matcher for UnresolvedLookupExpr in ASTMatcher.
+AST_MATCHER(CallExpr, hasUnresolvedLookupExpr) {
+  return isa<UnresolvedLookupExpr>(Node.getCallee());
----------------
Sorry for being unclear. Please change this to the node matcher in this patch. 
You can move the matcher to the ASTMatchers.h as a follow-up. 
`hasUnresolvedLookupExpr` is not in line with the matchers design: the 
`CallExpr` node has no property `UnresolvedLookupExpr`. You'll also be able to 
bind the `UnresolvedLookupExpr` to an identifier and make the code in `check()` 
slightly shorter.


http://reviews.llvm.org/D20326



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to