Re: [PATCH] D20279: [clang-tidy] Cleanups utils files

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D20279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D19815: Support '#pragma once' in headers when using PCH

wristow updated this revision to Diff 57320. wristow added a comment. Simplified he implementation, by using the existing `TUKind` field. http://reviews.llvm.org/D19815 Files: llvm/tools/clang/lib/Lex/Pragma.cpp llvm/tools/clang/test/PCH/Inputs/pragma-once.h llvm/tools/clang/test/PCH/prag

Re: [PATCH] D20243: [PCH] Disable inclusion of timestamps when generating pch files on windows.

pgousseau added a comment. In http://reviews.llvm.org/D20243#429811, @probinson wrote: > Please make sure the test files have newlines at the end. > "touch-pragma-once.cpp" should probably be named something like > "pragma-once-timestamp.cpp". Will fix thanks! http://reviews.llvm.org/D20243

Re: [PATCH] D20243: [PCH] Disable inclusion of timestamps when generating pch files on windows.

pgousseau updated this revision to Diff 57324. pgousseau added a comment. Add newlines and change test's name following Paul's comments. http://reviews.llvm.org/D20243 Files: lib/Frontend/FrontendActions.cpp lib/Serialization/ASTReader.cpp test/PCH/Inputs/pragma-once2-pch.h test/PCH/Inp

[PATCH] D20283: Add ras/noras flag to enable/disable RAS in clang

rogfer01 created this revision. rogfer01 added a reviewer: rsmith. rogfer01 added a subscriber: cfe-commits. Herald added a subscriber: aemerson. RAS extensions are part of ARMv8.2. This patch enables +ras +noras to AArch64 in clang. http://reviews.llvm.org/D20283 Files: lib/Driver/Tools.cpp

Re: r269398 - Add support for derived class special members hiding functions brought in from

The reduced reproducer: https://llvm.org/bugs/show_bug.cgi?id=27754 On 14/05/16 01:23, Richard Smith wrote: Update: Vassil and I have dug into this a bit offline. It looks like the root cause is a likely-pre-existing bug where we somehow import a default constructor for a class from a module but

r269649 - [Clang][AVX512] completing missing intrinsics [vsqrt|vrsqrt|vrcp14 ].

Author: mzuckerm Date: Mon May 16 06:42:01 2016 New Revision: 269649 URL: http://llvm.org/viewvc/llvm-project?rev=269649&view=rev Log: [Clang][AVX512] completing missing intrinsics [vsqrt|vrsqrt|vrcp14 ]. Differential Revision: http://reviews.llvm.org/D20068 Modified: cfe/trunk/lib/Headers/

Re: [PATCH] D20089: Adding a TargetParser for AArch64

jojo added a comment. Dear Bradley,Renato Sorry for late reply,I have been on leave the last three days. Thank you very much for your review and suggestons.I will re pondering the changes. Repository: rL LLVM http://reviews.llvm.org/D20089 ___

Re: [PATCH] D20088: Using AArch64TargetParser in clang

jojo added a comment. Dear Bradley,Renato Sorry for late reply,I have been on leave the last three days. Thank you very much for your review and suggestons.I will re pondering the changes. Repository: rL LLVM http://reviews.llvm.org/D20088 ___

Re: [PATCH] D16989: Change interpretation of function definition in friend declaration of template class.

Any feedback? Thanks, --Serge 2016-05-03 22:40 GMT+06:00 Serge Pavlov : > 2016-04-26 0:55 GMT+06:00 Richard Smith : > >> rsmith added inline comments. >> >> >> Comment at: lib/Sema/SemaDecl.cpp:8611-8612 >> @@ -8609,3 +8610,4 @@ >> } else { >> - // This needs to happen

r269651 - [mips] Add test for the dynamic linker when using the mips64el-fedora-linux triple.

Author: vkalintiris Date: Mon May 16 06:53:51 2016 New Revision: 269651 URL: http://llvm.org/viewvc/llvm-project?rev=269651&view=rev Log: [mips] Add test for the dynamic linker when using the mips64el-fedora-linux triple. We should use the musl linker only when there's no environment specified a

RE: r269411 - [mips] Consult triple's vendor field before using musl's interpreter.

Thanks for pointing that out. Test Added in r269651. - Vasileios From: Daniel Sanders Sent: 13 May 2016 17:33 To: Vasileios Kalintiris; cfe-commits@lists.llvm.org Subject: RE: r269411 - [mips] Consult triple's vendor field before using musl's interpreter.

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin added a comment. Ping?.. http://reviews.llvm.org/D17815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20037: Make __FreeBSD_cc_version predefined macro configurable at build time

dim added a subscriber: cfe-commits. dim added a comment. Belatedly adding cfe-commits. http://reviews.llvm.org/D20037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19667: [ubsan] Minimize size of data for type_mismatch

filcab updated this revision to Diff 57342. filcab added a comment. Minor update which never sets an AlignVal to 0. http://reviews.llvm.org/D19667 Files: lib/CodeGen/CGExpr.cpp test/CodeGen/catch-undef-behavior.c Index: test/CodeGen/catch-undef-behavior.c ==

Re: [PATCH] D20171: Support for MSVS default calling convention options (/Gd, /Gz, /Gv, /Gr)

a.makarov updated this revision to Diff 57344. a.makarov added a comment. I've updated the patch. Please take a look. http://reviews.llvm.org/D20171 Files: include/clang/Basic/LangOptions.def include/clang/Basic/LangOptions.h include/clang/Driver/CC1Options.td include/clang/Driver/CLCom

Re: [patch] Don't use appending linkage for embeded bitcode

+ auto Used = collectUsedGlobalVariables(*M, UsedGlobals, true); Please use an explicit type instead of auto. You deleted the assert I think this is fine otherwise. Cheers, Rafael On 13 May 2016 at 20:00, Steven Wu wrote: > >> On May 13, 2016, at 3:56 PM, Duncan P. N. Exon Smith >> wro

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

bittnerbarni updated this revision to Diff 57346. http://reviews.llvm.org/D20196 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/InefficientStringAdditionCheck.cpp clang-tidy/performance/InefficientStringAdditionCheck.h clang-tidy/performance/PerformanceTidyModule.cpp

[clang-tools-extra] r269656 - [clang-tidy] Cleanups utils files

Author: etienneb Date: Mon May 16 09:34:20 2016 New Revision: 269656 URL: http://llvm.org/viewvc/llvm-project?rev=269656&view=rev Log: [clang-tidy] Cleanups utils files Summary: Cleanup some code by using appropriate APIs. Some coding style cleanups. There is no behavior changes. - Function `I

Re: [PATCH] D19667: [ubsan] Minimize size of data for type_mismatch

filcab updated this revision to Diff 57350. filcab added a comment. Added a version field. http://reviews.llvm.org/D19667 Files: lib/CodeGen/CGExpr.cpp test/CodeGen/catch-undef-behavior.c Index: test/CodeGen/catch-undef-behavior.c ===

Re: [PATCH] D20052: Add new ASTMatcher that matches dynamic exception specifications.

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. I'm not keen on the new direction this patch has taken. `hasDynamicExceptionSpec(isThrow())` is quite novel. What is the problem you are trying to solve with this? ==

Re: [PATCH] D19841: [clang-tidy] Lift common matchers to utils namespace

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. LGTM! http://reviews.llvm.org/D19841 ___ cfe-commits mailing list cfe-commits@lists.

Re: [PATCH] D20052: Add new ASTMatcher that matches dynamic exception specifications.

hintonda added a comment. Great, unless() was what I was missing. I'll refactor along those lines. As for what I'm trying to achieve, I want a set containing "throw()" and another set containing "throw(something)". If there's a cleaner way to achieve that with an existing matcher, please let

Re: [PATCH] D20266: [Modules] Use vfs for (recursive) directory iteration

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D20052: Add new ASTMatcher that matches dynamic exception specifications.

aaron.ballman added a comment. In http://reviews.llvm.org/D20052#430903, @hintonda wrote: > Great, unless() was what I was missing. I'll refactor along those lines. > > As for what I'm trying to achieve, I want a set containing "throw()" and > another set containing "throw(something)". If ther

Re: [PATCH] D20052: Add new ASTMatcher that matches dynamic exception specifications.

hintonda added a comment. Great, that's exactly what I needed. I'll revert back to the previous version. http://reviews.llvm.org/D20052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

Re: [PATCH] D20254: [Clang] Fix some Clang-tidy modernize-use-bool-literals warnings; other minor fixes.

hans added a comment. I'd leave out the blank lines between DEF_TRAVERSE_STMTs, but the rest looks good. Comment at: include/clang/AST/RecursiveASTVisitor.h:2014 @@ -2002,2 +2013,3 @@ DEF_TRAVERSE_STMT(ObjCAutoreleasePoolStmt, {}) + DEF_TRAVERSE_STMT(CXXForRangeStmt, { --

Re: [PATCH] D20052: Add new ASTMatcher that matches dynamic exception specifications.

hintonda updated this revision to Diff 57356. hintonda added a comment. Revert back to previous version. http://reviews.llvm.org/D20052 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTMatchers

[PATCH] D20287: [Coverage] Ensure that the hash for a used function is non-zero.

ikudrin created this revision. ikudrin added reviewers: bogner, davidxl, vsk. ikudrin added a subscriber: cfe-commits. A valid function might not have any statement which affects the hash value, so the hash for that function was zero. The hash value for an unused function is also zero, so the lo

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

hintonda updated this revision to Diff 57357. hintonda added a comment. - Revert back to previous version of the matcher and use Aaron's syntax with allOf and unless to achieve the same results -- much simpler. http://reviews.llvm.org/D18575 Files: clang-tidy/modernize/CMakeLists.txt clang

Re: [PATCH] D20287: [Coverage] Ensure that the hash for a used function is non-zero.

ikudrin added a comment. The motivation sample (using llvm-cov with http://reviews.llvm.org/D20286 applied): $ cat > sample.h << EOF inline int sample_func(int A) { return A; } EOF $ cat > dummy.cpp << EOF #include "sample.h" EOF $ cat > sample.cpp << EOF #include "sample.h

Re: [PATCH] D20192: [Sema] Fix bug to do with lookup of template friend function in namespace

meadori added a subscriber: meadori. meadori added a comment. I see failure when running the Clang test suite with this patch: Command Output (stderr): -- error: 'error' diagnostics expected but not seen: File /Users/meadori/Code/src/llvm/llvm-mainline/tools/clang/test/SemaTemplate/fr

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

yaxunl added inline comments. Comment at: lib/Headers/opencl-c.h:17051 @@ +17050,3 @@ +#define CLK_SUCCESS 0 +#define CLK_ENQUEUE_FAILURE -101 +#define CLK_INVALID_QUEUE -102 Anastas

Re: [PATCH] D20287: [Coverage] Ensure that the hash for a used function is non-zero.

ikudrin added a comment. Does anyone known, why we need dummy coverage mapping records for unused functions? How are they used? Isn't it better to remove these dummy records to prevent confusion with the real ones? http://reviews.llvm.org/D20287 _

Re: [PATCH] D20052: Add new ASTMatcher that matches dynamic exception specifications.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Okay, back to looking good. :-) I will commit on your behalf, since I'm back to somewhere with source access again. http://reviews.llvm.org/D20052 ___

Re: [PATCH] D20052: Add new ASTMatcher that matches dynamic exception specifications.

hintonda added a comment. Great, thanks again. This has been a great learning experience. http://reviews.llvm.org/D20052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17416: [libcxx] Reorganize locale extension fallbacks. NFCI

mclow.lists added a comment. A couple of packaging comments. In general, this looks fine to me - still waiting on someone from Android to chime in. -- I'll ping Dan. Comment at: include/support/xlocale/__posix_l_fallback.h:13 @@ +12,3 @@ +// extended locale support for libc's

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

jprice added inline comments. Comment at: lib/Headers/opencl-c.h:17051 @@ +17050,3 @@ +#define CLK_SUCCESS 0 +#define CLK_ENQUEUE_FAILURE -101 +#define CLK_INVALID_QUEUE -102 yaxunl

r269661 - [Modules] Use vfs for (recursive) directory iteration

Author: bruno Date: Mon May 16 11:46:01 2016 New Revision: 269661 URL: http://llvm.org/viewvc/llvm-project?rev=269661&view=rev Log: [Modules] Use vfs for (recursive) directory iteration Clang performs directory walk while searching headers inside modules by using the ::sys::fs instead of ::vfs. T

Re: r269572 - Warn when a reference is bound to an empty l-value (dereferenced null pointer).

On Sat, May 14, 2016 at 10:44 AM, Nick Lewycky via cfe-commits wrote: > > Author: nicholas > Date: Sat May 14 12:44:14 2016 > New Revision: 269572 > > URL: http://llvm.org/viewvc/llvm-project?rev=269572&view=rev > Log: > Warn when a reference is bound to an empty l-value (dereferenced null > poin

r269662 - Add the hasDynamicExceptionSpec() AST matcher to match function declarations that have a dynamic exception specification.

Author: aaronballman Date: Mon May 16 11:49:01 2016 New Revision: 269662 URL: http://llvm.org/viewvc/llvm-project?rev=269662&view=rev Log: Add the hasDynamicExceptionSpec() AST matcher to match function declarations that have a dynamic exception specification. Patch by Don Hinton. Modified:

Re: [PATCH] D20052: Add new ASTMatcher that matches dynamic exception specifications.

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the work on this! I've commit in r269662 http://reviews.llvm.org/D20052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

rmaprath added a comment. Ping. http://reviews.llvm.org/D20119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r269663 - Add a couple of _LIBCPP_ASSERT calls. No functional change.

Author: marshall Date: Mon May 16 11:55:32 2016 New Revision: 269663 URL: http://llvm.org/viewvc/llvm-project?rev=269663&view=rev Log: Add a couple of _LIBCPP_ASSERT calls. No functional change. Modified: libcxx/trunk/include/future Modified: libcxx/trunk/include/future URL: http://llvm.org

Re: [PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)

cameron314 added inline comments. Comment at: lib/Frontend/ASTUnit.cpp:1402-1406 @@ +1401,7 @@ + +vfs::Status Status; +if (FileMgr->getNoncachedStatValue(RB.first, Status)) { + AnyFileChanged = true; + break; +} + rsmith w

[libcxx] r269665 - Add a test for uniqueptr having either NULL and nullptr

Author: marshall Date: Mon May 16 11:57:15 2016 New Revision: 269665 URL: http://llvm.org/viewvc/llvm-project?rev=269665&view=rev Log: Add a test for uniqueptr having either NULL and nullptr Modified: libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.cto

Re: r269572 - Warn when a reference is bound to an empty l-value (dereferenced null pointer).

Hans Wennborg wrote: On Sat, May 14, 2016 at 10:44 AM, Nick Lewycky via cfe-commits wrote: Author: nicholas Date: Sat May 14 12:44:14 2016 New Revision: 269572 URL: http://llvm.org/viewvc/llvm-project?rev=269572&view=rev Log: Warn when a reference is bound to an empty l-value (dereferenced n

[libcxx] r269669 - Remove C++11 feature macros in tests. Use TEST_STD_VER instead.

Author: ericwf Date: Mon May 16 12:05:14 2016 New Revision: 269669 URL: http://llvm.org/viewvc/llvm-project?rev=269669&view=rev Log: Remove C++11 feature macros in tests. Use TEST_STD_VER instead. Modified: libcxx/trunk/test/libcxx/utilities/meta/is_referenceable.pass.cpp libcxx/trunk/tes

r269670 - [OpenCL] Add supported OpenCL extensions to target info.

Author: yaxunl Date: Mon May 16 12:06:34 2016 New Revision: 269670 URL: http://llvm.org/viewvc/llvm-project?rev=269670&view=rev Log: [OpenCL] Add supported OpenCL extensions to target info. Add supported OpenCL extensions to target info. It serves as default values to save the users of the burde

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

yaxunl added inline comments. Comment at: lib/Headers/opencl-c.h:17051 @@ +17050,3 @@ +#define CLK_SUCCESS 0 +#define CLK_ENQUEUE_FAILURE -101 +#define CLK_INVALID_QUEUE -102 jprice

Re: [PATCH] D17416: [libcxx] Reorganize locale extension fallbacks. NFCI

danalbert accepted this revision. danalbert added a comment. This revision is now accepted and ready to land. LGTM. Sorry for the delay in response. http://reviews.llvm.org/D17416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

Re: [PATCH] D20287: [Coverage] Ensure that the hash for a used function is non-zero.

davidxl added a comment. Strictly speaking, this patch requires a version bump of the indexed format. The profile reader also needs to adjust the FunctionHash computation (either using 0 or simple function hash) based on the version of the profile data. Check with Justin/vsk to see if it is imp

r269671 - [PS4] Change the names of some "environmental" things to what our

Author: probinson Date: Mon May 16 12:22:25 2016 New Revision: 269671 URL: http://llvm.org/viewvc/llvm-project?rev=269671&view=rev Log: [PS4] Change the names of some "environmental" things to what our licensees actually see in the toolchain we deliver to them. This will reduce the set of local p

Re: [PATCH] D20192: [Sema] Fix bug to do with lookup of template friend function in namespace

erik.pilkington added a comment. Very weird, the test suite runs fine on my machine. Looks like the expected line for the diagnostics on your run is always one more than the line of the actual diagnostic. Could you please update your build to top-of-trunk, reapply the patch, and run the suite a

Re: r269572 - Warn when a reference is bound to an empty l-value (dereferenced null pointer).

On Mon, May 16, 2016 at 10:03 AM, Nick Lewycky wrote: > Hans Wennborg wrote: >> >> On Sat, May 14, 2016 at 10:44 AM, Nick Lewycky via cfe-commits >> wrote: >>> >>> >>> Author: nicholas >>> Date: Sat May 14 12:44:14 2016 >>> New Revision: 269572 >>> >>> URL: http://llvm.org/viewvc/llvm-project?re

[PATCH] D20291: [ms] Reintroduce feature guards in intrinsic headers in Microsoft mode

thakis created this revision. thakis added a reviewer: hans. thakis added a subscriber: cfe-commits. Visual Studio's C++ standard library headers include intrin.h, so the intrinsic headers get included a lot more often in Microsoft mode then elsewhere. The AVX512 intrinsics are a lot of code (0.

Re: [PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)

cameron314 updated the summary for this revision. cameron314 updated this revision to Diff 57367. cameron314 added a comment. This version of the patch takes into account potential changes between filenames and their unique IDs between parses. http://reviews.llvm.org/D20137 Files: lib/Fronte

Re: [patch] Don't use appending linkage for embeded bitcode

> On May 16, 2016, at 6:52 AM, Rafael Espíndola > wrote: > > + auto Used = collectUsedGlobalVariables(*M, UsedGlobals, true); > > Please use an explicit type instead of auto. Sure. > > You deleted the assert Are you referring to the assertion that llvm.embedded.module has no uses. I adde

Re: [PATCH] D20291: [ms] Reintroduce feature guards in intrinsic headers in Microsoft mode

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D20291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

Re: [PATCH] D20291: [ms] Reintroduce feature guards in intrinsic headers in Microsoft mode

thakis closed this revision. thakis added a comment. r269675, thanks! http://reviews.llvm.org/D20291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r269675 - [ms] Reintroduce feature guards in intrinsic headers in Microsoft mode

Author: nico Date: Mon May 16 13:14:07 2016 New Revision: 269675 URL: http://llvm.org/viewvc/llvm-project?rev=269675&view=rev Log: [ms] Reintroduce feature guards in intrinsic headers in Microsoft mode Visual Studio's C++ standard library headers include intrin.h, so the intrinsic headers get inc

[PATCH] clang-tidy: Bug 27731 - modernize-pass-by-value suggest using std::move for types that perform copies on move

Hi, I hereby attach a patch to fix bug no. 27731: https://llvm.org/bugs/show_bug.cgi?id=27731 Best regards, Mads Ravn Index: clang-tidy/modernize/PassByValueCheck.cpp === --- clang-tidy/modernize/PassByValueCheck.cpp (revision 269603

Re: [PATCH] D20192: [Sema] Fix bug to do with lookup of template friend function in namespace

meadori added a comment. Hmmm, it works on trunk r269671. Not sure what happened before. http://reviews.llvm.org/D20192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [patch] Don't use appending linkage for embeded bitcode

LGTM On 16 May 2016 at 14:03, Steven Wu wrote: > >> On May 16, 2016, at 6:52 AM, Rafael Espíndola >> wrote: >> >> + auto Used = collectUsedGlobalVariables(*M, UsedGlobals, true); >> >> Please use an explicit type instead of auto. > > Sure. > >> >> You deleted the assert > > Are you referring t

r269679 - Change embed-bitcode linkage type

Author: steven_wu Date: Mon May 16 13:54:58 2016 New Revision: 269679 URL: http://llvm.org/viewvc/llvm-project?rev=269679&view=rev Log: Change embed-bitcode linkage type Embedded bitcode should have private linkage instead of appending or external. Otherwise, it will cause link failure due to dup

Re: [patch] Don't use appending linkage for embeded bitcode

Thanks! Committed in r269679 Steven > On May 16, 2016, at 11:54 AM, Rafael Espíndola > wrote: > > LGTM > > On 16 May 2016 at 14:03, Steven Wu wrote: >> >>> On May 16, 2016, at 6:52 AM, Rafael Espíndola >>> wrote: >>> >>> + auto Used = collectUsedGlobalVariables(*M, UsedGlobals, true); >

r269680 - [Clang][AVX512] completing missing intrinsics for [vpabs] instruction set

Author: mzuckerm Date: Mon May 16 13:57:24 2016 New Revision: 269680 URL: http://llvm.org/viewvc/llvm-project?rev=269680&view=rev Log: [Clang][AVX512] completing missing intrinsics for [vpabs] instruction set Differential Revision: http://reviews.llvm.org/D20069 Modified: cfe/trunk/lib/Heade

Re: r269680 - [Clang][AVX512] completing missing intrinsics for [vpabs] instruction set

Hi Michael, have you see then trhead "The intrinsics headers (especially avx512) are too big. What to do about it?"? Can you maybe comment on it? Thanks, Nico On Mon, May 16, 2016 at 2:57 PM, Michael Zuckerman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: mzuckerm > Date: Mon M

[PATCH] D20296: clang-rename: avoid StringRef members in USRLocFindingASTVisitor

vmiklos created this revision. vmiklos added reviewers: klimek, cfe-commits. Even if this is defined in the .cpp file and only used as part of the function (so here it's safe), usually storing StringRefs in the class is dangerous, so don't do so. http://reviews.llvm.org/D20296 Files: clang-ren

Re: [PATCH] D20277: [clang-tidy] UnnecessaryValueParamCheck - suggest std::move() if non-const value parameter can be moved.

sbenza added inline comments. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:83 @@ +82,3 @@ + if (!IsConstQualified) { +auto Matches = utils::decl_ref_expr::allDeclRefExprs( +*Param, *Function->getBody(), *Result.Context); We should

Re: [PATCH] D19909: [Attr] Add support for the `ms_hook_prologue` attribute.

cdavis5x updated this revision to Diff 57389. cdavis5x added a comment. - Use Sanjoy's `patchable-function` attribute. - Add documentation for this new attribute. http://reviews.llvm.org/D19909 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td lib/CodeGen/TargetInfo.cpp

Re: [PATCH] D19909: [Attr] Add support for the `ms_hook_prologue` attribute.

cdavis5x marked an inline comment as done. Comment at: include/clang/Basic/Attr.td:2032 @@ -2031,1 +2031,3 @@ +def MSHookPrologue : InheritableAttr { + let Spellings = [GCC<"ms_hook_prologue">]; aaron.ballman wrote: > Does this attribute appertain to all target

r269687 - [Lex] inferModuleFromLocation should do no work if there are no modules

Author: majnemer Date: Mon May 16 15:30:03 2016 New Revision: 269687 URL: http://llvm.org/viewvc/llvm-project?rev=269687&view=rev Log: [Lex] inferModuleFromLocation should do no work if there are no modules getModuleContainingLocation ends up on the hot-path for typical C code which can lead to c

Re: [PATCH] D20133: [OpenCL] Fix __builtin_astype for vec3 types.

yaxunl updated this revision to Diff 57392. yaxunl added a comment. Add a test for casting char16 to i3 as Alexey suggested. http://reviews.llvm.org/D20133 Files: lib/CodeGen/CGExprScalar.cpp test/CodeGenOpenCL/as_type.cl Index: test/CodeGenOpenCL/as_type.cl ===

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:21 @@ +20,3 @@ + +static StringRef +makeDynamicExceptionString(const SourceManager &SM, Instead of a bunch of static functions, would an unnamed namespace make more sense?

Re: [PATCH] D20133: [OpenCL] Fix __builtin_astype for vec3 types.

yaxunl updated this revision to Diff 57393. yaxunl added a comment. Update test. http://reviews.llvm.org/D20133 Files: lib/CodeGen/CGExprScalar.cpp test/CodeGenOpenCL/as_type.cl Index: test/CodeGenOpenCL/as_type.cl === --- /de

Does anyone need these zorg modules?

Hello everyone, I am cleaning zorg a little and going to remove the next builder modules since they are not in use for a long time now: If anyone have plans for any of them please speak up! ChrootSetup.py DragonEggBuilder.py KLEEBuilder.py ScriptedBuilder.py gccSuiteBuilder.py Thanks Galina ___

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

hintonda added inline comments. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:21 @@ +20,3 @@ + +static StringRef +makeDynamicExceptionString(const SourceManager &SM, aaron.ballman wrote: > Instead of a bunch of static functions, would an unnamed namespace

r269693 - Added support to the ASTImporter for C++ constructor initializers.

Author: spyffe Date: Mon May 16 15:48:03 2016 New Revision: 269693 URL: http://llvm.org/viewvc/llvm-project?rev=269693&view=rev Log: Added support to the ASTImporter for C++ constructor initializers. Also added named casts and propagation of "implicit" to fix the LLDB testsuite. This is a fixed co

r269695 - Reapply^2 "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC"

Author: vedantk Date: Mon May 16 15:50:13 2016 New Revision: 269695 URL: http://llvm.org/viewvc/llvm-project?rev=269695&view=rev Log: Reapply^2 "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC" Sync up with "(llvm) Use Error in InstrProf and Coverage". Differential Revision: http:

Buildbot numbers for the last week of 5/08/2016 - 5/14/2016

Hello everyone, Below are some buildbot numbers for the last week of 5/08/2016 - 5/14/2016. Thanks Galina "Status change ratio" by active builder (percent of builds that changed the builder status from greed to red or from red to green): buildername

r269701 - Revert "Reapply^2 "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC""

Author: vedantk Date: Mon May 16 16:04:19 2016 New Revision: 269701 URL: http://llvm.org/viewvc/llvm-project?rev=269701&view=rev Log: Revert "Reapply^2 "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC"" This reverts commit r269695. The llvm commit does not pass the MSVC bot. Modi

Re: [PATCH] D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC

hubert.reinterpretcast added a comment. Ping (#2). http://reviews.llvm.org/D19322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:21 @@ +20,3 @@ + +static StringRef +makeDynamicExceptionString(const SourceManager &SM, hintonda wrote: > aaron.ballman wrote: > > Instead of a bunch of static functions, wo

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

hintonda added inline comments. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:46 @@ +45,3 @@ + const SmallVector &Tokens) { + // Find throw token -- it's a keyword, so there can't be more than one. Also, + // it should be near the end of the decla

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

aaron.ballman added inline comments. Comment at: test/clang-tidy/modernize-use-noexcept-macro.cpp:11 @@ +10,3 @@ + +// Should not trigger a FixItHint +class A {}; hintonda wrote: > aaron.ballman wrote: > > I may have missed some context in the discussion, but why

r269709 - [PS4] Tighten up a test (noticed in passing)

Author: probinson Date: Mon May 16 16:25:15 2016 New Revision: 269709 URL: http://llvm.org/viewvc/llvm-project?rev=269709&view=rev Log: [PS4] Tighten up a test (noticed in passing) Modified: cfe/trunk/test/Driver/ps4-linker-win.c Modified: cfe/trunk/test/Driver/ps4-linker-win.c URL: http://

[PATCH] D20302: Remove LazyDefinitionDataPtr and rely on getMostRecentDecl. Fixes PR27754.

v.g.vassilev created this revision. v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a subscriber: cfe-commits. v.g.vassilev set the repository for this revision to rL LLVM. Repository: rL LLVM http://reviews.llvm.org/D20302 Files: include/clang/AST/DeclCXX.h lib/AST/DeclCXX.cpp

Re: [PATCH] D20302: Remove LazyDefinitionDataPtr and rely on getMostRecentDecl. Fixes PR27754.

rsmith added inline comments. Comment at: include/clang/AST/DeclCXX.h:522 @@ -545,7 +521,3 @@ - typedef LazyDefinitionDataPtr - DefinitionDataPtr; - friend class LazyDefinitionDataPtr; - - mutable DefinitionDataPtr DefinitionData; + mutable DefinitionData* DefinitionDat

r269716 - Avoid O(n^2) string analysis when handling GNU __asm__ statements.

Author: rsmith Date: Mon May 16 17:52:23 2016 New Revision: 269716 URL: http://llvm.org/viewvc/llvm-project?rev=269716&view=rev Log: Avoid O(n^2) string analysis when handling GNU __asm__ statements. Modified: cfe/trunk/lib/AST/Stmt.cpp Modified: cfe/trunk/lib/AST/Stmt.cpp URL: http://llvm.

r269717 - Switch from SmallVector to TinyPtrVector for the list of attributes on a declaration. This removes a memory allocation for the common case where the declaration has only one attribute.

Author: rsmith Date: Mon May 16 17:53:19 2016 New Revision: 269717 URL: http://llvm.org/viewvc/llvm-project?rev=269717&view=rev Log: Switch from SmallVector to TinyPtrVector for the list of attributes on a declaration. This removes a memory allocation for the common case where the declaration ha

r269718 - Doxygen comments for avxintrin.h.

Author: kromanova Date: Mon May 16 17:54:45 2016 New Revision: 269718 URL: http://llvm.org/viewvc/llvm-project?rev=269718&view=rev Log: Doxygen comments for avxintrin.h. Added doxygen comments to avxintrin.h's intrinsics. As of now, only around 50% of the intrinsics in this file are documented h

r269720 - Try to make the buildbots green again: avoid the need for class Attr to be

Author: rsmith Date: Mon May 16 18:03:40 2016 New Revision: 269720 URL: http://llvm.org/viewvc/llvm-project?rev=269720&view=rev Log: Try to make the buildbots green again: avoid the need for class Attr to be complete for users of AttrVec. Modified: cfe/trunk/include/clang/AST/AttrIterator.h

Re: r269214 - Relax -Wcalling-convention-cast when casting to the default convention (cdecl)

After this tweak, Chromium builds cleanly with the new warning enabled. Maybe it's time to turn it on by default. On Wed, May 11, 2016 at 1:43 PM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Wed May 11 12:43:13 2016 > New Revision: 269214 > > URL: http

r269721 - Less broken fix for buildbot breakage.

Author: rsmith Date: Mon May 16 18:07:58 2016 New Revision: 269721 URL: http://llvm.org/viewvc/llvm-project?rev=269721&view=rev Log: Less broken fix for buildbot breakage. Modified: cfe/trunk/include/clang/AST/AttrIterator.h Modified: cfe/trunk/include/clang/AST/AttrIterator.h URL: http://l

Re: r269309 - [ubsan] Add -fsanitize-undefined-strip-path-components=N

On Fri, May 13, 2016 at 12:01 AM, Filipe Cabecinhas wrote: > > > On 13 May 2016, at 07:03, Sean Silva wrote: > > > > > > > > On Thu, May 12, 2016 at 9:51 AM, Filipe Cabecinhas via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > Author: filcab > > Date: Thu May 12 11:51:36 2016 > > New Rev

Re: [PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D20111: [OpenMP] Adjust map type bits according to latest spec and use zero size array sections for pointers.

sfantao updated this revision to Diff 57419. sfantao added a comment. - Rebase. http://reviews.llvm.org/D20111 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/target_codegen.cpp test/OpenMP/target_codegen_registration.cpp test/OpenMP/target_data_codegen.cpp test/OpenMP/target_enter

Re: [PATCH] D20112: [OpenMP] Add support for the 'private pointer' flag to signal variables captured in target regions and used in first-private clauses.

sfantao updated this revision to Diff 57420. sfantao added a comment. - Move the flags adjustment for first private declarations to the mappable expressions handler. http://reviews.llvm.org/D20112 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/target_firstprivate_codegen.cpp test/Ope

Re: [PATCH] D20112: [OpenMP] Add support for the 'private pointer' flag to signal variables captured in target regions and used in first-private clauses.

sfantao marked 2 inline comments as done. sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5452 @@ +5451,3 @@ + // in there. + for (const auto *C : D.getClausesOfKind()) { +for (const auto *D : C->varlists()) { ---

  1   2   >