mclow.lists added a comment.
A couple of packaging comments. In general, this looks fine to me - still
waiting on someone from Android to chime in. -- I'll ping Dan.
================
Comment at: include/support/xlocale/__posix_l_fallback.h:13
@@ +12,3 @@
+// extended locale support for libc's that normally don't have any (like
+// Android's bionic, and Newlib).
+//===----------------------------------------------------------------------===//
----------------
extra comma
================
Comment at: include/support/xlocale/__posix_l_fallback.h:23
@@ +22,3 @@
+
+static inline int isalnum_l(int c, locale_t) {
+ return isalnum(c);
----------------
Instead of `static inline`, how about you mark these as `_LIBCPP_ALWAYS_INLINE`?
Also, do you want to write them as `return ::isalnum(c);`
(I don't know the answer here, but they're definitely not in namespace `std`)
================
Comment at: include/support/xlocale/__strtonum_fallback.h:22
@@ +21,3 @@
+#endif
+static inline long double strtold_l(const char *nptr, char **endptr, locale_t)
{
+ return strtold(nptr, endptr);
----------------
Again with the inline and `::` bits.
http://reviews.llvm.org/D17416
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
