Author: mzuckerm
Date: Tue Apr 12 02:59:39 2016
New Revision: 266048
URL: http://llvm.org/viewvc/llvm-project?rev=266048&view=rev
Log:
[Clang][BuiltIn][avx512] Adding avx512 (shuf,sqrt{ss|sd},rsqrt ) builtin to
clang
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
cfe/trunk/lib/H
ioeric updated this revision to Diff 53370.
ioeric added a comment.
- minor changes in checkEmptyNamespace.
http://reviews.llvm.org/D18551
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
unittests/Format/CMakeLists.txt
unittests/Format/CleanupTest.cpp
unittests/Format/Forma
pilki updated this revision to Diff 53371.
pilki marked an inline comment as done.
http://reviews.llvm.org/D18961
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/DeletedDefaultCheck.cpp
clang-tidy/readability/DeletedDefaultCheck.h
clang-tidy/readability/Readability
pilki added inline comments.
Comment at: clang-tidy/readability/DeletedDefaultCheck.cpp:35
@@ +34,3 @@
+ this);
+ Finder->addMatcher(cxxMethodDecl(anyOf(isCopyAssignmentOperator(),
+ isMoveAssignmentOperator()),
---
hokein updated this revision to Diff 53372.
hokein added a comment.
Keep track all the fields of ClangTidyOptions.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/Inputs/explain-config/
hokein marked an inline comment as done.
hokein added a comment.
In http://reviews.llvm.org/D18694#396797, @alexfh wrote:
> I've just realized that the approach is artificially limited to just keeping
> track of the origin of the `Checks` option, while it could be easily extended
> to track the
hokein updated this revision to Diff 53373.
hokein added a comment.
Don't modify unrelevant code.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/Inputs/explain-config/.clang-tidy
tes
Author: abataev
Date: Tue Apr 12 04:35:56 2016
New Revision: 266052
URL: http://llvm.org/viewvc/llvm-project?rev=266052&view=rev
Log:
[OPENMP 4.0] Support for 'aligned' clause in 'declare simd' directive.
The aligned clause declares that the object to which each list item points is
aligned to th
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good. A couple of comments.
I'm happy to commit the patch for you once you answer the comments.
Thank you for the work!
Comment at: clang-tidy/readability/DeletedDefa
Author: abataev
Date: Tue Apr 12 06:02:11 2016
New Revision: 266056
URL: http://llvm.org/viewvc/llvm-project?rev=266056&view=rev
Log:
[OPENMP 4.0] Support for 'linear' clause in 'declare simd' directive.
The linear clause declares one or more list items to be private to a SIMD lane
and to have a
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4260-4273
@@ -4259,2 +4259,16 @@
+/// \brief look inside a Body stmt for a LF statement discarding any
+/// intervening CompoundStmt's
+template
+const static LF *hasEnclosingOpenMPDirective(const Stmt *
faisalv added a comment.
*ping*
http://reviews.llvm.org/D18510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pilki updated this revision to Diff 53381.
pilki marked an inline comment as done.
http://reviews.llvm.org/D18961
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/DeletedDefaultCheck.cpp
clang-tidy/readability/DeletedDefaultCheck.h
clang-tidy/readability/Readability
michael_miller updated this revision to Diff 53380.
michael_miller marked 2 inline comments as done.
michael_miller added a comment.
Herald added a subscriber: klimek.
Moved isDelegatingConstructor and isUserProvided into
clang/include/clang/ASTMatchers/ASTMatchers.h and updated the tests and doc
michael_miller marked 3 inline comments as done.
michael_miller added a comment.
Sounds good! Updated with suggested changes.
http://reviews.llvm.org/D18584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
pilki added inline comments.
Comment at: clang-tidy/readability/DeletedDefaultCheck.cpp:36
@@ +35,3 @@
+}
+
+void DeletedDefaultCheck::check(const MatchFinder::MatchResult &Result) {
alexfh wrote:
> I would at least join matchers, since, I believe, it might be mo
Author: d0k
Date: Tue Apr 12 06:49:52 2016
New Revision: 266057
URL: http://llvm.org/viewvc/llvm-project?rev=266057&view=rev
Log:
Remove unused diagnostics. NFC.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
Modified: c
avt77 marked an inline comment as done.
Comment at: lib/Sema/SemaDecl.cpp:5570
@@ -5565,3 +5569,3 @@
// and qualified friend declarations.
- // NB: MSVC converts such a declaration to dllexport.
+ // NB: MSVC converts such a declaration to dllexport that's why we do it
also.
a.sidorin updated this revision to Diff 53389.
a.sidorin added a comment.
Update to current master;
Fix a memory leak introduced in cf8ccff5: an array is allocated in ImportArray
and never freed.
http://reviews.llvm.org/D14286
Files:
include/clang/AST/Type.h
lib/AST/ASTImporter.cpp
unitt
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with one minor correction (you can correct when committing it).
Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:2343
@@ +2342,3 @@
+
+TEST(DestructorD
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, with one small nit.
Comment at: include/clang/Basic/Builtins.h:97
@@ -96,1 +96,3 @@
+ /// \brief Return true if this function has no side effects
+ boo
xazax.hun added a comment.
What is the status of this?
As far as I understand it is blocked on that there is no checker that we could
use to test this function with unknown variables as indexes?
http://reviews.llvm.org/D16044
___
cfe-commits maili
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a comment.
I share David's consideration for making this a compiler warning instead of a
clang-tidy check. Perhaps it would make sense to gather some data using this
check over some large code bases to see how often it triggers
Elijah_Th added a comment.
alexfh,
OK. I'll take a look at apply-replacements and fix if needed, in the beginning
of the next week!
http://reviews.llvm.org/D16183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Alexander_Droste added a comment.
> What is the status of this?
> As far as I understand it is blocked on that there is no checker that we
> could use to test this function with unknown variables as indexes?
Yes, this is blocked due to the MPI-Checker dependency. The best thing I can
offer at
twoh updated this revision to Diff 53395.
twoh added a comment.
Addressing comments from @aaron.ballman. It would be great if someone can
commit this patch for me, as I don't have the privilege yet.
http://reviews.llvm.org/D18970
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/
sbaranga added inline comments.
Comment at: test/Sema/arm_vfma.c:1
@@ -1,2 +1,2 @@
-// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon
-fsyntax-only -verify %s
+// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon
-target-feature +vfp4 -fsyn
sbenza added inline comments.
Comment at: clang-tidy/readability/RedundantInlineCheck.cpp:68
@@ +67,3 @@
+ }
+ llvm_unreachable("InlineTok() did not encounter the 'inline' token");
+}
This is still reachable.
The token might be hidden through macros, for example
sbenza updated this revision to Diff 53398.
sbenza marked an inline comment as done.
sbenza added a comment.
Change warning message.
http://reviews.llvm.org/D18766
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MultipleStatementMacroCheck.cpp
cl
sbenza added inline comments.
Comment at: clang-tidy/misc/MultipleStatementMacroCheck.cpp:99
@@ +98,3 @@
+
+ diag(InnerRanges.back().first, "multiple statement macro spans unbraced "
+ "conditional and the following statement");
al
Author: aaronballman
Date: Tue Apr 12 10:09:17 2016
New Revision: 266079
URL: http://llvm.org/viewvc/llvm-project?rev=266079&view=rev
Log:
Moving clang-test-depends into the Clang tests folder and moving
vtables_blacklist into the Misc folder; NFC, this simply cleans up the
generated solution so
pilki added a comment.
Fixed all the comment but the one about merging the two matchers.
http://reviews.llvm.org/D18961
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
This check found suspicious cases of sizeof expression.
Sizeof expression is retuning the size (in bytes) of a type or an
expression. Programmers often abuse of misuse this expression.
Th
pilki updated this revision to Diff 53404.
pilki marked 3 inline comments as done.
http://reviews.llvm.org/D18961
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/DeletedDefaultCheck.cpp
clang-tidy/readability/DeletedDefaultCheck.h
clang-tidy/readability/Readability
d.zobnin.bugzilla updated this revision to Diff 53400.
d.zobnin.bugzilla added a comment.
Eric, thank you for the review!
I've renamed the test, but have also made it a .cpp file for the reasons
described below.
You are right -- GCC looks at "target" attribute applied to the function in
which
sbaranga updated this revision to Diff 53409.
sbaranga added a comment.
If no cpu has been passed to the command line, use the generic cpu when
selecting
features/FPU, instead of using an empty string (which is not recognized by the
TargetParser).
http://reviews.llvm.org/D18963
Files:
lib/Ba
sbaranga added a comment.
I've updated the patch to fix the defaults when the cpu is not specified.
Renato, Tim, could you have a look at this again please?
Thanks,
Silviu
http://reviews.llvm.org/D18963
___
cfe-commits mailing list
cfe-commits@lis
alexfh added a comment.
The check is really awesome! Thank you for coming up with all the patterns that
frequently happen to result from coding errors!
Please update release notes.
A few inline comments as well.
Comment at: clang-tidy/misc/SizeofExpressionCheck.cpp:22
@@ +21,
Author: yaxunl
Date: Tue Apr 12 10:46:24 2016
New Revision: 266083
URL: http://llvm.org/viewvc/llvm-project?rev=266083&view=rev
Log:
Verify commit right by adding a blank line to
test/CodeGenOpenCL/address-spaces-conversions.cl.
Modified:
cfe/trunk/test/CodeGenOpenCL/address-spaces-conversio
jlebar updated this revision to Diff 53415.
jlebar added a comment.
Switch [this] to [&].
http://reviews.llvm.org/D18617
Files:
lib/CodeGen/BackendUtil.cpp
Index: lib/CodeGen/BackendUtil.cpp
===
--- lib/CodeGen/BackendUtil.cpp
+
alexfh added inline comments.
Comment at: clang-tidy/readability/DeletedDefaultCheck.cpp:37
@@ +36,3 @@
+
+void DeletedDefaultCheck::check(const MatchFinder::MatchResult &Result) {
+ const StringRef Message = "%0 is explicitly defaulted but implicitly "
Will it
alexfh added inline comments.
Comment at: clang-tidy/misc/MultipleStatementMacroCheck.cpp:100
@@ +99,3 @@
+ diag(InnerRanges.back().first, "multiple statement macro used without "
+ "braces; some statements will be "
+
zaks.anna added a comment.
Gabor,
Can other checkers use this function? I am Ok with this being committed with
limited coverage.
http://reviews.llvm.org/D16044
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
On Mon, Apr 11, 2016 at 7:16 PM, Nico Weber wrote:
> r260990 exposed -isystem in clang-cl. -isystem adds a directory to the front
> of the system include search path. The idea was to use this to point to a
> hermetic msvc install, but as it turns out this doesn't work: -isystem then
> adds the her
d.zobnin.bugzilla updated this revision to Diff 53414.
d.zobnin.bugzilla added a comment.
John, thanks for the review!
Please take a look at the updated patch -- did I understand your comments
correctly?
The test passes and ds2 application is compiled successfully.
Thank you,
Denis Zobnin
htt
Author: majnemer
Date: Tue Apr 12 11:33:53 2016
New Revision: 266089
URL: http://llvm.org/viewvc/llvm-project?rev=266089&view=rev
Log:
[FileManager] Don't crash if reading from stdin and stat(".") fails
addAncestorsAsVirtualDirs("") quickly returns without doing work
because "" has no parent_path
Author: nico
Date: Tue Apr 12 11:38:07 2016
New Revision: 266090
URL: http://llvm.org/viewvc/llvm-project?rev=266090&view=rev
Log:
clang-cl: Expose -nostdlibinc.
Modified:
cfe/trunk/include/clang/Driver/Options.td
cfe/trunk/test/Driver/cl-options.c
Modified: cfe/trunk/include/clang/Drive
Any chance of using unique_ptr, or at least a scoped cleanup device, here?
On Mon, Apr 11, 2016 at 1:54 PM, Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: hans
> Date: Mon Apr 11 15:53:59 2016
> New Revision: 265994
>
> URL: http://llvm.org/viewvc/llvm-project?rev=26
Author: nico
Date: Tue Apr 12 11:52:30 2016
New Revision: 266091
URL: http://llvm.org/viewvc/llvm-project?rev=266091&view=rev
Log:
Revert 266090, needs more testing first.
Modified:
cfe/trunk/include/clang/Driver/Options.td
cfe/trunk/test/Driver/cl-options.c
Modified: cfe/trunk/include/c
benlangmuir added a comment.
> From what I understand from
> http://lists.llvm.org/pipermail/cfe-dev/2014-July/038273.html, changing the
> behavior of the cached result has side-effects and demands a non trivial
> change, am I assuming the right thing?
Yes.
Threading through the Filename see
chandlerc added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:347
@@ +346,3 @@
+PassManagerBuilder::EP_EarlyAsPossible,
+[&](const PassManagerBuilder &, legacy::PassManagerBase &PM) {
+ TM->addEarlyAsPossiblePasses(PM);
Wow, C++
> -Original Message-
> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
> Evgeniy Stepanov via cfe-commits
> Sent: Monday, April 11, 2016 3:28 PM
> To: cfe-commits@lists.llvm.org
> Subject: r266005 - Allow simultaneous safestack and stackprotector
> attributes.
>
xazax.hun added a comment.
In http://reviews.llvm.org/D16044#398463, @zaks.anna wrote:
> Can other checkers use this function? I am Ok with this being committed with
> limited coverage.
Once I rebase http://reviews.llvm.org/D15227, it will provide us with the
limited coverage. In case that pa
On Mon, Mar 7, 2016 at 12:33 AM Michael Zuckerman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: mzuckerm
> Date: Mon Mar 7 02:29:10 2016
> New Revision: 262817
>
> URL: http://llvm.org/viewvc/llvm-project?rev=262817&view=rev
> Log:
> [CLANG][AVX512][BUILTIN] Adding vpmultishiftqb
carlo.bertolli marked an inline comment as done.
carlo.bertolli added a comment.
Great, thanks for the hint. I do much prefer your version of the function. I am
updating the diff.
Repository:
rL LLVM
http://reviews.llvm.org/D18474
___
cfe-commit
carlo.bertolli updated this revision to Diff 53425.
carlo.bertolli added a comment.
[OPENMP] Remove unnecessary templating of function.
Repository:
rL LLVM
http://reviews.llvm.org/D18474
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/teams_codegen.cpp
Index: test/OpenMP/teams_codege
etienneb updated this revision to Diff 53428.
etienneb marked 6 inline comments as done.
etienneb added a comment.
fix alexfh@ comments
http://reviews.llvm.org/D19014
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/SizeofExpressionCheck.cpp
clang
While useful, that would require a lot of restructuring, I think.
This file seems to mostly be dealing with C-style objects;
ExprEvalResult doesn't even have a C++ destructor. I'm not going to
dig into that, I just wanted to address this bug that someone
reported.
- Hans
On Tue, Apr 12, 2016 a
Thanks, fixed in r266095
On Tue, Apr 12, 2016 at 10:15 AM, Robinson, Paul
wrote:
>
>
>> -Original Message-
>> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
>> Evgeniy Stepanov via cfe-commits
>> Sent: Monday, April 11, 2016 3:28 PM
>> To: cfe-commits@lists.llv
Author: eugenis
Date: Tue Apr 12 12:51:59 2016
New Revision: 266095
URL: http://llvm.org/viewvc/llvm-project?rev=266095&view=rev
Log:
Stricter checks in the stack-protector codegen test.
Modified:
cfe/trunk/test/CodeGen/stack-protector.c
Modified: cfe/trunk/test/CodeGen/stack-protector.c
URL
spyffe added a subscriber: spyffe.
spyffe added a comment.
Aleksei,
it looks like I might have made a bad assumption in my ImportArray – namely
that there were some entities that required arrays of things they’re
constructed with to be allocated in the ASTContext. Looking at the
constructors
Aleksei,
it looks like I might have made a bad assumption in my ImportArray – namely
that there were some entities that required arrays of things they’re
constructed with to be allocated in the ASTContext. Looking at the
constructors for those entities, it looks like most of them actually do t
etienneb updated this revision to Diff 53429.
etienneb added a comment.
release notes.
http://reviews.llvm.org/D19014
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/SizeofExpressionCheck.cpp
clang-tidy/misc/SizeofExpressionCheck.h
docs/Release
etienneb updated this revision to Diff 53431.
etienneb added a comment.
more unittests
http://reviews.llvm.org/D19014
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/SizeofExpressionCheck.cpp
clang-tidy/misc/SizeofExpressionCheck.h
docs/Release
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG, except for the small comment
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4260
@@ -4259,1 +4259,3 @@
+/// \brief discard all CompoundStmts intervening between two const
etienneb updated this revision to Diff 53436.
etienneb added a comment.
fix typos and doc.
http://reviews.llvm.org/D19014
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/SizeofExpressionCheck.cpp
clang-tidy/misc/SizeofExpressionCheck.h
docs/Rel
manmanren added inline comments.
Comment at: lib/Parse/ParseObjc.cpp:1697
@@ -1696,3 +1696,3 @@
// We syntactically matched a type argument, so commit to parsing
- // type arguments.
+ // type arguments. Finding protocol arguments after here is an error.
I
kzhuravl added a comment.
ping
http://reviews.llvm.org/D18748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added inline comments.
Comment at: clang-tidy/misc/SizeofExpressionCheck.cpp:197
@@ +196,3 @@
+ this);
+}
+
What about this comment?
Comment at: clang-tidy/misc/SizeofExpressionCheck.cpp:203
@@ +202,3 @@
+ if (const auto *E = Result.
All done. phab's back, but since we started with a patch attachment, let's
keep it that way.
On Tue, Apr 12, 2016 at 12:12 PM, Hans Wennborg wrote:
> On Mon, Apr 11, 2016 at 7:16 PM, Nico Weber wrote:
> > r260990 exposed -isystem in clang-cl. -isystem adds a directory to the
> front
> > of th
skalinichev accepted this revision.
skalinichev added a comment.
LGTM!
Comment at: bindings/python/tests/cindex/test_cursor.py:197
@@ +196,3 @@
+
+def test_is_deleted_method():
+"""Ensure Cursor.is_deleted_method works."""
You should remove it too.
http://
LGTM
On Tue, Apr 12, 2016 at 11:40 AM, Nico Weber wrote:
> All done. phab's back, but since we started with a patch attachment, let's
> keep it that way.
>
>
>
> On Tue, Apr 12, 2016 at 12:12 PM, Hans Wennborg wrote:
>>
>> On Mon, Apr 11, 2016 at 7:16 PM, Nico Weber wrote:
>> > r260990 exposed
etienneb updated this revision to Diff 53437.
etienneb marked 5 inline comments as done.
etienneb added a comment.
alexfh comments.
http://reviews.llvm.org/D19014
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/SizeofExpressionCheck.cpp
clang-tid
etienneb added inline comments.
Comment at: clang-tidy/misc/SizeofExpressionCheck.cpp:27
@@ +26,3 @@
+
+AST_MATCHER(BinaryOperator, isRelationnalOperator) {
+ return Node.isRelationalOp();
alexfh wrote:
> alexfh wrote:
> > nit: extra 'n' in "relational"
> I'd put
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
This all looks fine to me, and the LLDB test suite is happy also.
http://reviews.llvm.org/D14286
___
cfe-commits mailing list
cfe-commits@lists.l
zaks.anna added a comment.
Alexander,
This patch is in a pretty good shape. I am fine with committing it and
iterating with smaller updates in tree if it is more convenient for you.
One task that I would like to very strongly encourage is running this on a lot
of code. You will find a lot of i
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D18748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266107: [OpenCL] Handle AddressSpaceConversion when target
address space does not… (authored by yaxunl).
Changed prior to commit:
http://reviews.llvm.org/D18713?vs=52800&id=53439#toc
Repository:
rL L
Author: nico
Date: Tue Apr 12 14:04:37 2016
New Revision: 266108
URL: http://llvm.org/viewvc/llvm-project?rev=266108&view=rev
Log:
clang-cl: Remove -isystem, add -imsvc.
r260990 exposed -isystem in clang-cl. -isystem adds a directory to the front of
the system include search path. The idea was to
Yes, we’ll try make the patches smaller and avoid such mistakes.
- Elena
From: Chandler Carruth [mailto:chandl...@google.com]
Sent: Tuesday, April 12, 2016 20:25
To: Zuckerman, Michael ;
cfe-commits@lists.llvm.org; Demikhovsky, Elena
Subject: Re: r262817 - [CLANG][AVX512][BUILTIN] Add
Author: yaxunl
Date: Tue Apr 12 14:03:49 2016
New Revision: 266107
URL: http://llvm.org/viewvc/llvm-project?rev=266107&view=rev
Log:
[OpenCL] Handle AddressSpaceConversion when target address space does not
change.
In codegen different address spaces may be mapped to the same address
space for a
bruno added a comment.
Hi Manman,
Comment at: lib/Parse/ParseObjc.cpp:1697
@@ -1696,3 +1696,3 @@
// We syntactically matched a type argument, so commit to parsing
- // type arguments.
+ // type arguments. Finding protocol arguments after here is an error.
alexfh added inline comments.
Comment at: clang-tidy/misc/SizeofExpressionCheck.cpp:28
@@ +27,3 @@
+ return Node.getValue().getZExtValue() > N;
+}
+
There are no firm rules. It mostly depends on how generic/useful in other tools
the matcher could be. This one se
bruno added a comment.
Hi Ben,
Comment at: lib/Basic/FileManager.cpp:221-223
@@ -220,2 +220,5 @@
// See if there is already an entry in the map.
+ // FIXME: Note that when first requested, the returned file name equals to
the
+ // requested path. This is not true when retu
Author: dcoughlin
Date: Tue Apr 12 14:29:52 2016
New Revision: 266109
URL: http://llvm.org/viewvc/llvm-project?rev=266109&view=rev
Log:
[analyzer] Nullability: Suppress return diagnostics in inlined functions.
The nullability checker can sometimes miss detecting nullability precondition
violation
loladiro added a subscriber: loladiro.
loladiro added a comment.
Thanks for this. I was about to create the same patch (after seeing this broken
on 3.7) only to see it had already been done!
Repository:
rL LLVM
http://reviews.llvm.org/D13610
___
alexfh added a comment.
BTW, why is the check in the 'modernize' module? It doesn't seem to make
anything more modern. I would guess, the pattern it detects is most likely to
result from a programming error. Also, the fix, though it retains the behavior,
has a high chance to be incorrect. Can y
etienneb updated this revision to Diff 53442.
etienneb marked an inline comment as done.
etienneb added a comment.
alexfh comments.
http://reviews.llvm.org/D19014
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/SizeofExpressionCheck.cpp
clang-tid
benlangmuir added inline comments.
Comment at: lib/Basic/FileManager.cpp:221-223
@@ -220,2 +220,5 @@
// See if there is already an entry in the map.
+ // FIXME: Note that when first requested, the returned file name equals to
the
+ // requested path. This is not true when re
Author: yaxunl
Date: Tue Apr 12 14:43:36 2016
New Revision: 266111
URL: http://llvm.org/viewvc/llvm-project?rev=266111&view=rev
Log:
PR19957: [OpenCL] Incorrectly accepts implicit address space conversion with
ternary operator.
Generates addrspacecast instead of bitcast for ternary operator when
This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Closed by commit rL266111: PR19957: [OpenCL] Incorrectly accepts implicit
address space conversion with… (authored by yaxunl).
Changed prior to commit:
http://reviews.llvm.org/D174
michael_miller updated this revision to Diff 53441.
michael_miller added a comment.
Removed accidentally duplicated test case.
http://reviews.llvm.org/D18584
Files:
clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp
clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h
clang-tidy/uti
michael_miller added a comment.
In http://reviews.llvm.org/D18584#398298, @aaron.ballman wrote:
> LGTM with one minor correction (you can correct when committing it).
Oops! Not sure how that happened. I submitted a revised diff.
http://reviews.llvm.org/D18584
__
zaks.anna added a comment.
"Since we are adding support for so many new APIs that are only available on
Windows, could you please condition checking them only when we build for
Windows. You probably can look and Language Options to figure that out."
malloc-uses.c -> "alternative-malloc-api.c" ?
alexfh added inline comments.
Comment at: clang-tidy/misc/SizeofExpressionCheck.cpp:198
@@ +197,3 @@
+}
+
+void SizeofExpressionCheck::check(const MatchFinder::MatchResult &Result) {
I'm probably wrong about "a more effective approach in general", but for
`sizeof
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with one more nit. I'm not sure what to do with `hasSizeOfAncestor`,
we can leave it as is for now.
Comment at: clang-tidy/misc/SizeofExpressionCheck.cpp:47
@@ +46
zaks.anna added a comment.
You do not have to supply these. Just declaring and not defining the functions
in the main test file should be sufficient.
http://reviews.llvm.org/D18595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
Author: rsmith
Date: Tue Apr 12 14:58:30 2016
New Revision: 266113
URL: http://llvm.org/viewvc/llvm-project?rev=266113&view=rev
Log:
[modules] When an incompatible module file is explicitly provided for a module,
and we fall back to textual inclusion, don't require the module as a whole to
be mark
michael_miller marked an inline comment as done.
michael_miller added a comment.
In http://reviews.llvm.org/D18584#398298, @aaron.ballman wrote:
> LGTM with one minor correction (you can correct when committing it).
Also, what's the next step? Is there anything else for me to do?
http://revie
Author: rsmith
Date: Tue Apr 12 15:20:33 2016
New Revision: 266116
URL: http://llvm.org/viewvc/llvm-project?rev=266116&view=rev
Log:
[modules] Extend r266113 to cope with submodules.
Modified:
cfe/trunk/lib/Lex/PPDirectives.cpp
cfe/trunk/test/Modules/explicit-build-missing-files.cpp
Modi
1 - 100 of 147 matches
Mail list logo
