[PATCH] D18014: Allows to build libc++ with -DLLVM_USE_SANITIZER="Address; Undefined" on OSX

joker.eph created this revision. joker.eph added a reviewer: beanz. joker.eph added a subscriber: cfe-commits. joker.eph set the repository for this revision to rL LLVM. It seems some cases were missing to the configuration. Repository: rL LLVM http://reviews.llvm.org/D18014 Files: lib/CMak

Re: [PATCH] D17627: Fix false positives for for-loop-analysis warning

rjmccall added inline comments. Comment at: lib/Sema/SemaStmt.cpp:1448 @@ +1447,3 @@ +if (auto *OVE = dyn_cast(S)) { + // Look pass OVE for Decl. + if (Expr *E = OVE->getSourceExpr()) "Look past the OVE into the expression it binds." ===

r263076 - [Modules] Add stdatomic to the list of builtin headers

Author: benlangmuir Date: Wed Mar 9 17:31:34 2016 New Revision: 263076 URL: http://llvm.org/viewvc/llvm-project?rev=263076&view=rev Log: [Modules] Add stdatomic to the list of builtin headers Since it's provided by the compiler. This allows a system module map file to declare a module for it. N

Re: [PATCH] D18011: [modules] Diagnose insufficient privileges when trying to load the modulemap

silvas added a comment. Isn't there a `read` call or something that fails down the road? How can it be silent? http://reviews.llvm.org/D18011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

Re: r262881 - P0188R1: add support for standard [[fallthrough]] attribute. This is almost

On Tue, Mar 8, 2016 at 12:18 PM, Nico Weber wrote: > On Tue, Mar 8, 2016 at 2:10 PM, Richard Smith > wrote: > >> On Tue, Mar 8, 2016 at 11:04 AM, Nico Weber wrote: >> > On Tue, Mar 8, 2016 at 1:49 PM, Richard Smith >> wrote: >> >> >> >> On Tue, Mar 8, 2016 at 9:05 AM, Nico Weber >> wrote: >>

Re: [PATCH] D17627: Fix false positives for for-loop-analysis warning

steven_wu updated this revision to Diff 50212. steven_wu updated the summary for this revision. steven_wu added a comment. Update according to feedback. I agree that OVE should never be null as semantics of PseudoObjectExpr. http://reviews.llvm.org/D17627 Files: lib/Sema/SemaStmt.cpp test/S

Re: [PATCH] D15314: Fix a bug in unavailable checking

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D15314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D18014: Allows to build libc++ with -DLLVM_USE_SANITIZER="Address; Undefined" on OSX

beanz added inline comments. Comment at: lib/CMakeLists.txt:51 @@ -50,2 +50,3 @@ if (APPLE AND LLVM_USE_SANITIZER) - if ("${LLVM_USE_SANITIZER}" STREQUAL "Address") + if ("${LLVM_USE_SANITIZER}" STREQUAL "Address" OR + "${LLVM_USE_SANITIZER}" STREQUAL "Address;Undefined" O

r263081 - EmitCXXStructorCall -> EmitCXXDestructorCall. NFC.

Author: samsonov Date: Wed Mar 9 18:20:37 2016 New Revision: 263081 URL: http://llvm.org/viewvc/llvm-project?rev=263081&view=rev Log: EmitCXXStructorCall -> EmitCXXDestructorCall. NFC. This function is only used in Microsoft ABI and only to emit destructors. Rename/simplify it accordingly. Modi

r263080 - Remove unused function arguments. NFC.

Author: samsonov Date: Wed Mar 9 18:20:33 2016 New Revision: 263080 URL: http://llvm.org/viewvc/llvm-project?rev=263080&view=rev Log: Remove unused function arguments. NFC. Modified: cfe/trunk/lib/CodeGen/CGExprCXX.cpp Modified: cfe/trunk/lib/CodeGen/CGExprCXX.cpp URL: http://llvm.org/view

Re: [PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

rsmith added a comment. `-f(no-)strict-nonnull-this` maybe? http://reviews.llvm.org/D17993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17976: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

> On Mar 8, 2016, at 5:44 PM, Roman Levenstein via cfe-commits > wrote: > > Forgot to add the mailing list when I created a patch. You don’t have cfe-commits in phabricator subscribers, so you probably won’t get notifications when someone replies there. It might make sense to resubmit the pat

Re: [PATCH] D18014: Allows to build libc++ with -DLLVM_USE_SANITIZER="Address;Undefined" on OSX

Thanks, that's a lot cleaner indeed. I'll update. -- Mehdi > On Mar 9, 2016, at 4:02 PM, Chris Bieneman wrote: > > beanz added inline comments. > > > Comment at: lib/CMakeLists.txt:51 > @@ -50,2 +50,3 @@ > if (APPLE AND LLVM_USE_SANITIZER) > - if ("${LLVM_USE_SANITIZER}" ST

Re: [PATCH] D17983: Eliminate many benign instances of "potentially uninitialized local variable" warnings

On Wed, Mar 9, 2016 at 12:06 PM, Alexander Riccio via cfe-commits < cfe-commits@lists.llvm.org> wrote: > ariccio added a comment. > > Oh, and by the way, what's the policy on using `enum class`es instead of C > style enums? I bet the compiler would have fewer false positives with > strongly typed

Re: [PATCH] D17983: Eliminate many benign instances of "potentially uninitialized local variable" warnings

On Wed, Mar 9, 2016 at 11:58 AM, Alexander Riccio via cfe-commits < cfe-commits@lists.llvm.org> wrote: > ariccio added a comment. > > In http://reviews.llvm.org/D17983#370717, @dblaikie wrote: > > > Initializations we never expect to use (eg because we have a covered > switch > > that initializes

Re: [PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

hfinkel added a comment. In http://reviews.llvm.org/D17993#370793, @chandlerc wrote: > If we're not going to fully implement "fdelete-null-pointer-checks" we > shouldn't claim to... I'm really worried about us accepting that flag and not > actually honoring it. > > However, I *do* think this sh

Re: r262851 - Module Debugging: Fix a crash when emitting debug info for nested tag types

Is this bug only reachable with modules debug info? Could you describe the nature of the fix (not quite clear to me just by looking at it) On Mon, Mar 7, 2016 at 12:58 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Mon Mar 7 14:58:52 2016 > New Re

Re: [PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

chandlerc added a comment. In http://reviews.llvm.org/D17993#371454, @hfinkel wrote: > In http://reviews.llvm.org/D17993#370793, @chandlerc wrote: > > > If we're not going to fully implement "fdelete-null-pointer-checks" we > > shouldn't claim to... I'm really worried about us accepting that fla

Re: [PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

hfinkel added a comment. In http://reviews.llvm.org/D17993#370790, @rjmccall wrote: > Hal, I think you're talking about a slightly different thing. This patch is > adding an assumption that C++ this pointers are non-null, but only when > -fno-delete-null-pointer-checks is not passed. The flag

Re: [PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

hfinkel added a comment. In http://reviews.llvm.org/D17993#371459, @chandlerc wrote: > In http://reviews.llvm.org/D17993#371454, @hfinkel wrote: > > > In http://reviews.llvm.org/D17993#370793, @chandlerc wrote: > > > > > If we're not going to fully implement "fdelete-null-pointer-checks" we > >

Re: [PATCH] D17999: Rewrite ARM & AArch64 tests to check LLVM IR rather than assembly

rengolin added a comment. Great work, Tim! Thank you! http://reviews.llvm.org/D17999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17627: Fix false positives for for-loop-analysis warning

rjmccall added a comment. Thanks, LGTM. http://reviews.llvm.org/D17627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17627: Fix false positives for for-loop-analysis warning

This revision was automatically updated to reflect the committed changes. steven_wu marked 2 inline comments as done. Closed by commit rL263087: Fix false positives for for-loop-analysis warning (authored by steven_wu). Changed prior to commit: http://reviews.llvm.org/D17627?vs=50212&id=50221#t

r263087 - Fix false positives for for-loop-analysis warning

Author: steven_wu Date: Wed Mar 9 20:02:48 2016 New Revision: 263087 URL: http://llvm.org/viewvc/llvm-project?rev=263087&view=rev Log: Fix false positives for for-loop-analysis warning Summary: For PseudoObjectExpr, the DeclMatcher need to search only all the semantics but also need to search pa

[PATCH] D18024: Remove compile time PreserveName switch based on NDEBUG

joker.eph created this revision. joker.eph added a reviewer: chandlerc. joker.eph added a subscriber: cfe-commits. Following r263086, we are now relying on a flag on the Context to discard Value names in release builds. http://reviews.llvm.org/D18024 Files: lib/CodeGen/CGBuilder.h lib/CodeGe

Re: [PATCH] D17963: [OPENMP] Codegen for teams directive for NVPTX

ABataev added a comment. Add tests with captured globals to check that this problem is resolved Repository: rL LLVM http://reviews.llvm.org/D17963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D18025: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

swiftix created this revision. swiftix added reviewers: ributzka, aaron.ballman. swiftix added a subscriber: cfe-commits. Herald added a subscriber: aemerson. Till now, preserve_mostcc/preserve_allcc calling convention attributes were only available at the LLVM IR level. This patch adds attribute

Re: [PATCH] D17976: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

I resubmitted the patch as http://reviews.llvm.org/D18025 and included the mailing list as a subscriber, so that the replies are not getting lost. Sorry for the inconvenience. -Roman > On Mar 8, 2016, at 5:44 PM, Roman Levenstein via cfe-commits > wrote: > >

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:69 @@ +68,3 @@ + /// evaluates to false. + virtual void emitTargetOutlinedFunctionHelper(const OMPExecutableDirective &D, +StringRef ParentName,

Re: [PATCH] D17963: [OPENMP] Codegen for teams directive for NVPTX

carlo.bertolli added a comment. Support for global variables in a target region requires the global to be placed in a pragma declare target region. Pragma declare target region is not currently available in Clang (no parsing, sema, or codegen). I will add a check for this in the regression test

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

arpith-jacob marked an inline comment as done. Comment at: lib/CodeGen/CGOpenMPRuntime.h:69 @@ +68,3 @@ + /// evaluates to false. + virtual void emitTargetOutlinedFunctionHelper(const OMPExecutableDirective &D, +StringRef ParentNa

Re: [PATCH] D17412: PR19957: [OpenCL] incorrectly accepts implicit address space conversion with ternary operator

pxli168 added a comment. The logic is still to complex and I hope it can be optimized. Comment at: lib/Sema/SemaExpr.cpp:6222-6227 @@ -6188,1 +6221,8 @@ +auto ResultAddrSpace = ResultTy.getQualifiers().getAddressSpace(); +LHSCastKind = lhQual.getAddressSpace() == ResultA

r263091 - Disable failing test and fix RUN line.

Author: rtrieu Date: Wed Mar 9 22:04:12 2016 New Revision: 263091 URL: http://llvm.org/viewvc/llvm-project?rev=263091&view=rev Log: Disable failing test and fix RUN line. See https://llvm.org/bugs/show_bug.cgi?id=26894 for details. This change fixes the incorrect flags to Clang and the piping i

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D17877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

r263093 - ARM: fix arm_neon_intrinsics.c and re-enable.

Author: tnorthover Date: Wed Mar 9 22:39:45 2016 New Revision: 263093 URL: http://llvm.org/viewvc/llvm-project?rev=263093&view=rev Log: ARM: fix arm_neon_intrinsics.c and re-enable. It turns out I'd never actually tested my recent change because it was gated on long-tests. Failure ensued. Modif

Re: [PATCH] D4507: R600: Define device name macros.

arsenm abandoned this revision. arsenm added a comment. Going to redo this with simplified names http://reviews.llvm.org/D4507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D5896: Emit minnum / maxnum for __builtin_fmin/fmax

arsenm added a comment. ping since there seems to be a consensus now that intrinsics should be preferred http://reviews.llvm.org/D5896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17983: Eliminate many benign instances of "potentially uninitialized local variable" warnings

ariccio updated this revision to Diff 50241. ariccio added a comment. For some reason, this smaller diff was harder to upload than the first diff. http://reviews.llvm.org/D17983 Files: llvm/lib/Analysis/DependenceAnalysis.cpp llvm/lib/Analysis/InstructionSimplify.cpp llvm/lib/AsmParser/LL

<    1   2