Re: [PATCH] D17130: Debloat some headers

ariccio updated the summary for this revision. ariccio updated this revision to Diff 47603. http://reviews.llvm.org/D17130 Files: llvm/tools/clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h llvm/tools/clang/include/clang/StaticAnalyzer/Core/CheckerManager.h llvm/tools/clang

Re: [PATCH] D17130: Debloat some headers

ariccio added inline comments. Comment at: llvm/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h:143 @@ -144,3 +142,3 @@ void addAbortedBlock(const ExplodedNode *node, const CFGBlock *block) { -blocksAborted.push_back(std::make_pair(block, node)); +

Re: [PATCH] D17130: Debloat some headers

ariccio added a comment. In http://reviews.llvm.org/D17130#349744, @craig.topper wrote: > What's complex about the SVal constructors? I arbitrarily figured that classes that are more than twice-derived (is there a better way to say that) are complex. I don't think there was any //particularly

RE: [libcxx] r260235 - Introduce a cmake module to figure out whether we need to link with libatomic.

Hi, In my latests rc2+patches build I've also found that we need to rename HAVE_CXX_ATOMICS_WITH_LIB to something like LIBCXX_HAVE_CXX_ATOMICS_WITH_LIB. It's currently re-using the result of LLVM's check which doesn't include 64-bit atomics. From: Vasile

[clang-tools-extra] r260503 - [clang-tidy] Add a check to find unintended semicolons that changes the semantics.

Author: xazax Date: Thu Feb 11 03:23:33 2016 New Revision: 260503 URL: http://llvm.org/viewvc/llvm-project?rev=260503&view=rev Log: [clang-tidy] Add a check to find unintended semicolons that changes the semantics. Reviewers: hokein, alexfh Differential Revision: http://reviews.llvm.org/D16535

Re: [PATCH] D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL260503: [clang-tidy] Add a check to find unintended semicolons that changes the… (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D16535?vs=47446&id=47604#toc Repository: rL LLVM

Re: [PATCH] D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics.

xazax.hun added a comment. In http://reviews.llvm.org/D16535#348469, @alexfh wrote: > Could you run the check on LLVM and post here a summary of results: how many > warnings are generated, whether there are any false positives (based on a > reasonably-sized random sample, if there are too many

Re: [PATCH] D17069: [clang-tidy] Fix an assert failure in 'readability-braces-around-statements' check.

hokein updated this revision to Diff 47609. hokein added a comment. Address review comment. http://reviews.llvm.org/D17069 Files: clang-tidy/readability/BracesAroundStatementsCheck.cpp test/clang-tidy/readability-braces-around-statements-assert-failure.cpp Index: test/clang-tidy/readabilit

Re: [PATCH] D17069: [clang-tidy] Fix an assert failure in 'readability-braces-around-statements' check.

hokein marked an inline comment as done. hokein added a comment. http://reviews.llvm.org/D17069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17069: [clang-tidy] Fix an assert failure in 'readability-braces-around-statements' check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL260505: [clang-tidy] Fix an assert failure in 'readability-braces-around-statements'… (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D17069?vs=47609&id=47610#toc Repository: r

[clang-tools-extra] r260505 - [clang-tidy] Fix an assert failure in 'readability-braces-around-statements' check.

Author: hokein Date: Thu Feb 11 03:57:55 2016 New Revision: 260505 URL: http://llvm.org/viewvc/llvm-project?rev=260505&view=rev Log: [clang-tidy] Fix an assert failure in 'readability-braces-around-statements' check. Summary: The check will trigger a assert failure("CondEndLoc.isValid") when che

[PATCH] D17132: [libcxx] Fix definition of regex_traits::__regex_word on big-endian glibc systems

dsanders created this revision. dsanders added reviewers: mclow.lists, hans. dsanders added a subscriber: cfe-commits. On glibc, the bits used for the various character classes is endian dependant (see _ISbit() in ctypes.h) but __regex_word does not account for this and uses a spare bit that isn't

Re: [PATCH] D17132: [libcxx] Fix definition of regex_traits::__regex_word on big-endian glibc systems

dsanders added inline comments. Comment at: include/regex:980 @@ +979,3 @@ +#if defined(__GLIBC__) +static const char_class_type __regex_word = static_cast(_ISbit(15)); +#else The static_cast is necessary to silence a false-positive warning on little-endian.

Re: [PATCH] D16851: Update of "GCC extensions not implemented yet" in Clang User's Manual

andreybokhanko added a comment. In http://reviews.llvm.org/D16851#349537, @silvas wrote: > Assuming the features are implemented this seems fine. LGTM. Thank you! Comment at: docs/UsersManual.rst:1698 @@ -1697,3 @@ -- clang does not support #pragma weak (`bug - 3679

Re: [PATCH] D16851: Update of "GCC extensions not implemented yet" in Clang User's Manual

This revision was automatically updated to reflect the committed changes. Closed by commit rL260506: Update of "GCC extensions not implemented yet" in Clang User's Manual (authored by asbokhan). Changed prior to commit: http://reviews.llvm.org/D16851?vs=46779&id=47615#toc Repository: rL LLVM

r260506 - Update of "GCC extensions not implemented yet" in Clang User's Manual

Author: asbokhan Date: Thu Feb 11 04:36:06 2016 New Revision: 260506 URL: http://llvm.org/viewvc/llvm-project?rev=260506&view=rev Log: Update of "GCC extensions not implemented yet" in Clang User's Manual #pragma weak, global register variables and static initialization of flexible array members

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Thu, Feb 11, 2016 at 2:47 AM, Matthijs van Duin wrote: > On 8 February 2016 at 22:40, H.J. Lu wrote: >> "empty type". An empty type is either an array of empty types or a >> class type where every member is of empty type. > > Note that the term "empty type" is commonly used in type theory to

Re: [PATCH] D16808: [MCU] PR26438: Fix assertion failure on function returning an empty struct or union

This revision was automatically updated to reflect the committed changes. Closed by commit rL260510: [MCU] Fix assertion failure on function returning empty union. (authored by dzobnin). Changed prior to commit: http://reviews.llvm.org/D16808?vs=47333&id=47624#toc Repository: rL LLVM http:/

r260510 - [MCU] Fix assertion failure on function returning empty union.

Author: dzobnin Date: Thu Feb 11 05:26:03 2016 New Revision: 260510 URL: http://llvm.org/viewvc/llvm-project?rev=260510&view=rev Log: [MCU] Fix assertion failure on function returning empty union. Treat empty struct/union in return type as void for MCU ABI. PR26438. Differential Revision: http:/

Re: [PATCH] D14203: [analyzer] Improve pointer arithmetic checker.

xazax.hun added a comment. Ping. http://reviews.llvm.org/D14203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r260513 - Teach __hash_table how to handle unordered_map's __hash_value_type.

Author: ericwf Date: Thu Feb 11 05:59:44 2016 New Revision: 260513 URL: http://llvm.org/viewvc/llvm-project?rev=260513&view=rev Log: Teach __hash_table how to handle unordered_map's __hash_value_type. This patch is fairly large and contains a number of changes. The main change is teaching '__hash

Re: [PATCH] D17134: [clang-tidy] Fix an assert failure of ForStmt in `readability-braces-around-statements` check.

alexfh added inline comments. Comment at: test/clang-tidy/readability-braces-around-statements-assert-failure.cpp:13 @@ +12,3 @@ + std::vector e; + for (typename std::vector::const_reverse_iterator iter = e.begin(), + end2 =

[PATCH] D17136: [AST] VisitFunctionTemplateDecl implementation in ASTImporter class.

esakella created this revision. esakella added reviewers: rsmith, klimek, bkramer, spyffe. esakella added subscribers: karies, cfe-commits. Herald added a subscriber: aemerson. Implemented the VisitFunctionTemplateDecl function for the import of template function definitions. Note that this fun

[libcxx] r260514 - Teach __hash_table how to handle unordered_map's __hash_value_type.

Author: ericwf Date: Thu Feb 11 06:25:27 2016 New Revision: 260514 URL: http://llvm.org/viewvc/llvm-project?rev=260514&view=rev Log: Teach __hash_table how to handle unordered_map's __hash_value_type. This patch is fairly large and contains a number of changes. The main change is teaching '__hash

[libcxx] r260515 - Re-commit "Introduce a cmake module to figure out whether we need to link with libatomic."

Author: vkalintiris Date: Thu Feb 11 06:43:04 2016 New Revision: 260515 URL: http://llvm.org/viewvc/llvm-project?rev=260515&view=rev Log: Re-commit "Introduce a cmake module to figure out whether we need to link with libatomic." This re-applies commit r260235. However, this time we add -gcc-tool

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On 11 February 2016 at 12:40, Matthijs van Duin wrote: > You never define "POD for the purposes of layout", and I can only > interpret it as being equivalent to "standard-layout". As Richard pointed out, it's defined in the C++ ABI. ___ cfe-commits maili

[libcxx] r260516 - separate nested >>

Author: ericwf Date: Thu Feb 11 06:51:19 2016 New Revision: 260516 URL: http://llvm.org/viewvc/llvm-project?rev=260516&view=rev Log: separate nested >> Modified: libcxx/trunk/test/support/container_test_types.h Modified: libcxx/trunk/test/support/container_test_types.h URL: http://llvm.org/

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Thu, Feb 11, 2016 at 4:40 AM, Matthijs van Duin wrote: > On 11 February 2016 at 11:53, H.J. Lu wrote: >> Since this isn't Plain Old Data (POD) for the purposes of layout, it >> isn't covered by my proposal for psABI. I leave this to C++ ABI. > > You never define "POD for the purposes of layou

Re: [PATCH] D16792: unordered_map: Use __hash_table::__emplace_unique(), NFC

EricWF added a comment. All of the prep work has landed. This patch is no longer needed though. http://reviews.llvm.org/D16792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16965: Fix for Bug 14644 - clang confuses scope operator for global namespace giving extra qualification on member

ryee88 added a comment. Ping-- I think this review got missed. http://reviews.llvm.org/D16965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16949: Fix for: Bug 5941 - improve diagnostic for * vs & confusion

ryee88 added a comment. Ping-- can someone look at this review? http://reviews.llvm.org/D16949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15998: Implement __attribute__((gc_leaf_function)).

sanjoy resigned from this revision. sanjoy removed a reviewer: sanjoy. sanjoy added a comment. Resigning for now to make my "Revisions Waiting on You" queue less noisy. Please don't hesitate to add me back if this or a variant of this change becomes active. http://reviews.llvm.org/D15998 _

Re: Linux-abi group

H.J, I think we are fragmenting with too many standards and mailing lists. This new discussion group and eventually the resulting standards, all might be put under LSB http://refspecs.linuxfoundation.org/lsb.shtml The Intro on LSB says: http://refspecs.linuxfoundation.org/LSB_5.0.0/LSB-Core-

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On 8 February 2016 at 22:40, H.J. Lu wrote: > "empty type". An empty type is either an array of empty types or a > class type where every member is of empty type. Note that the term "empty type" is commonly used in type theory to denote a (or the) type with no values. The closest thing C has wo

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On 11 February 2016 at 11:53, H.J. Lu wrote: > Since this isn't Plain Old Data (POD) for the purposes of layout, it > isn't covered by my proposal for psABI. I leave this to C++ ABI. You never define "POD for the purposes of layout", and I can only interpret it as being equivalent to "standard-l

r260517 - clang-format: Make indentation after "<<" more consistent.

Author: djasper Date: Thu Feb 11 07:15:14 2016 New Revision: 260517 URL: http://llvm.org/viewvc/llvm-project?rev=260517&view=rev Log: clang-format: Make indentation after "<<" more consistent. Before: Diag(, ) << (

Re: [PATCH] D16517: ClangTidy check to flag uninitialized builtin and pointer fields.

alexfh added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:206 @@ +205,3 @@ + // Do not propose fixes in macros since we cannot place them correctly. + if (Ctor->getLocStart().isMacroID()) +return; IIUC what this is doi

r260518 - clang-format: [JS] Support for (.. of ..) loops.

Author: djasper Date: Thu Feb 11 07:24:15 2016 New Revision: 260518 URL: http://llvm.org/viewvc/llvm-project?rev=260518&view=rev Log: clang-format: [JS] Support for (.. of ..) loops. Before: for (var i of[2, 3]) {} After: for (var i of [2, 3]) {} Modified: cfe/trunk/lib/Format/FormatTok

r260519 - Partial revert of rL260506.

Author: asbokhan Date: Thu Feb 11 07:27:02 2016 New Revision: 260519 URL: http://llvm.org/viewvc/llvm-project?rev=260519&view=rev Log: Partial revert of rL260506. After some experiments I discovered that clang doesn't support static initialization of flexible array members in full, so restored th

Re: [PATCH] D17023: pr26544: Bitfield layout with pragma pack and attributes "packed" and "aligned

DmitryPolukhin added a comment. John, this patch extends check that I added recently and looks good to me but could you please also take a look. http://reviews.llvm.org/D17023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On 11 February 2016 at 13:58, H.J. Lu wrote: > "POD for the purpose of layout" is defined in the Itanium C++ ABI here: > > http://mentorembedded.github.io/cxx-abi/abi.html#definitions Sorry, I overlooked that. I still stand by my viewpoint however that triviality of copying and destruction is th

Re: Linux-abi group

On Thu, Feb 11, 2016 at 2:26 AM, Suprateeka R Hegde wrote: > H.J, > > I think we are fragmenting with too many standards and mailing lists. This > new discussion group and eventually the resulting standards, all might be > put under LSB http://refspecs.linuxfoundation.org/lsb.shtml > > The Intro o

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Thu, Feb 11, 2016 at 5:44 AM, Matthijs van Duin wrote: > On 11 February 2016 at 13:58, H.J. Lu wrote: >> "POD for the purpose of layout" is defined in the Itanium C++ ABI here: >> >> http://mentorembedded.github.io/cxx-abi/abi.html#definitions > > Sorry, I overlooked that. > > I still stand by

r260522 - Revert "Bail on compilation as soon as a job fails."

Author: rafael Date: Thu Feb 11 08:13:17 2016 New Revision: 260522 URL: http://llvm.org/viewvc/llvm-project?rev=260522&view=rev Log: Revert "Bail on compilation as soon as a job fails." This reverts commit r260448. It was causing Driver/output-file-cleanup.c to fail. Modified: cfe/trunk/lib

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On 11 February 2016 at 15:00, H.J. Lu wrote: > I intentionally exclude C++ specific features in my propose. Yet you use a definition from the Itanium C++ ABI which itself depends on multiple definitions in a particular version of the C++ standard, which depend on C++ specific features. This make

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Thu, Feb 11, 2016 at 6:18 AM, Matthijs van Duin wrote: > On 11 February 2016 at 15:00, H.J. Lu wrote: >> I intentionally exclude C++ specific features in my propose. > > Yet you use a definition from the Itanium C++ ABI which itself depends > on multiple definitions in a particular version of

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

Hi, On Thu, 11 Feb 2016, Jonathan Wakely wrote: > On 11 February 2016 at 12:40, Matthijs van Duin wrote: > > You never define "POD for the purposes of layout", and I can only > > interpret it as being equivalent to "standard-layout". > > As Richard pointed out, it's defined in the C++ ABI. Whic

Re: [PATCH] D16545: [libcxxabi] Enable testing for static libc++abi

bcraig added a comment. ping http://reviews.llvm.org/D16545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16544: [libcxx] Framework to allow testing of static libc++abi

bcraig added a comment. ping http://reviews.llvm.org/D16544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Thu, Feb 11, 2016 at 6:30 AM, Michael Matz wrote: > Hi, > > On Thu, 11 Feb 2016, Jonathan Wakely wrote: > >> On 11 February 2016 at 12:40, Matthijs van Duin wrote: >> > You never define "POD for the purposes of layout", and I can only >> > interpret it as being equivalent to "standard-layout".

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good now. Thank you! http://reviews.llvm.org/D16922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

Hi, On Thu, 11 Feb 2016, H.J. Lu wrote: > Any suggestions on new wording, something like > > 1. "class type". A class type is a structure, union or C++ class. > 2. "empty type". An empty type is a type where it and all of its > subobjects are of class or array type. > > Does it cover > >

[PATCH] D17140: [clang-tidy] improve misc-misplaced-widening-cast so it also detects portability problems

danielmarjamaki created this revision. danielmarjamaki added a reviewer: alexfh. danielmarjamaki added a subscriber: cfe-commits. danielmarjamaki set the repository for this revision to rL LLVM. The misc-misplaced-widening-cast currently only looks at the size to determine if a cast is widening.

RE: [libcxx] r260515 - Re-commit "Introduce a cmake module to figure out whether we need to link with libatomic."

Hi Hans, Can we merge this on the release branch? It's a re-commit of D16613's patch with the an additional option (-gcc-toolchain) to the default flags, that we use in order to test support for atomics, when the user doesn't want to use the default/system GCC installation. Buildbots look good

Re: [libcxx] r260515 - Re-commit "Introduce a cmake module to figure out whether we need to link with libatomic."

Hi Vasileios, This patch doesn't quite work correctly. I've committed a follow up fix to it as r260524. Let me know if you have any issues. /Eric On Thu, Feb 11, 2016 at 5:43 AM, Vasileios Kalintiris via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: vkalintiris > Date: Thu Feb 11

Re: [PATCH] D15797: [clang-tidy] Fix readability-braces-around-statements assert failure

alexfh added a comment. An alternative fix has recently been committed. Can you run clang-tidy built after r260505 on your code? Repository: rL LLVM http://reviews.llvm.org/D15797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[libcxx] r260526 - Properly down-cast a sentinal node pointer through void*

Author: ericwf Date: Thu Feb 11 09:22:37 2016 New Revision: 260526 URL: http://llvm.org/viewvc/llvm-project?rev=260526&view=rev Log: Properly down-cast a sentinal node pointer through void* Modified: libcxx/trunk/include/__hash_table Modified: libcxx/trunk/include/__hash_table URL: http://l

[libcxx] r260527 - Add some tests to ensure that the __regex_word does not conflict with any of ctype_base's values.

Author: marshall Date: Thu Feb 11 09:23:04 2016 New Revision: 260527 URL: http://llvm.org/viewvc/llvm-project?rev=260527&view=rev Log: Add some tests to ensure that the __regex_word does not conflict with any of ctype_base's values. Hopefully this will catch cases like https://llvm.org/bugs/show

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Thu, Feb 11, 2016 at 6:54 AM, Michael Matz wrote: > Hi, > > On Thu, 11 Feb 2016, H.J. Lu wrote: > >> Any suggestions on new wording, something like >> >> 1. "class type". A class type is a structure, union or C++ class. >> 2. "empty type". An empty type is a type where it and all of its >>

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

To avoid depending again on precise wording of definitions in C++ standard it may be worth being explicit about the requirement to be trivially copyable *and* destructible, since although the former implies the latter in the C++ standard this is not obvious from the terminology (although you also n

[libcxx] r260524 - Fix r260515 - Correct typos in CMake changes

Author: ericwf Date: Thu Feb 11 09:05:56 2016 New Revision: 260524 URL: http://llvm.org/viewvc/llvm-project?rev=260524&view=rev Log: Fix r260515 - Correct typos in CMake changes Modified: libcxx/trunk/cmake/Modules/CheckLibcxxAtomic.cmake libcxx/trunk/cmake/config-ix.cmake Modified: libc

Re: [PATCH] D17132: [libcxx] Fix definition of regex_traits::__regex_word on big-endian glibc systems

mclow.lists added a comment. In r260527, I added some tests to catch this if it happens again. If those tests fail w/o this patch and succeed with, then I'm happy with applying it. http://reviews.llvm.org/D17132 ___ cfe-commits mailing list cfe-co

Re: Linux-abi group

On 8 February 2016 at 18:08, Joseph Myers wrote: > On Mon, 8 Feb 2016, H.J. Lu wrote: > >> >> I was referring to program properties: >> >> >> >> https://groups.google.com/forum/#!topic/generic-abi/fyIXttIsYc8 >> > >> > This looks more like an ELF topic to me, not really ABI. >> > >> > Please discu

RE: [libcxx] r260515 - Re-commit "Introduce a cmake module to figure out whether we need to link with libatomic."

Hi Eric, Your changes work fine for me. Out of curiosity, the correctness issue you mentioned was about the lines you removed from config-ix.cmake, right? - Vasileios From: Eric Fiselier [e...@efcs.ca] Sent: 11 February 2016 15:11 To: Vasileios Kalintiris Cc: cfe

Re: [libcxx] r260515 - Re-commit "Introduce a cmake module to figure out whether we need to link with libatomic."

There were a couple of correctness issues. 'LIBCXX_HAS_ATOMIC_WITHOUT_LIB' was accidentally typo-ed '_WITH_' in a couple of places and 'LIBCXX_HAS_ATOMIC_LIB' was not originally a cache variable like it probably should have been. I just used 'LIBCXX_HAS_ATOMIC_LIB' directly in 'check_library_exist

[libcxx] r260531 - Rename CheckLibcxxAtomic.cmake variable result names so they don't clash with LLVM

Author: ericwf Date: Thu Feb 11 09:52:52 2016 New Revision: 260531 URL: http://llvm.org/viewvc/llvm-project?rev=260531&view=rev Log: Rename CheckLibcxxAtomic.cmake variable result names so they don't clash with LLVM Modified: libcxx/trunk/cmake/Modules/CheckLibcxxAtomic.cmake Modified: libc

Re: Linux-abi group

On 11-Feb-2016 07:21 PM, H.J. Lu wrote: On Thu, Feb 11, 2016 at 2:26 AM, Suprateeka R Hegde wrote: H.J, I think we are fragmenting with too many standards and mailing lists. This new discussion group and eventually the resulting standards, all might be put under LSB http://refspecs.linuxfounda

[clang-tools-extra] r260532 - Merge branch 'arcpatch-D16922'

Author: congliu Date: Thu Feb 11 10:03:27 2016 New Revision: 260532 URL: http://llvm.org/viewvc/llvm-project?rev=260532&view=rev Log: Merge branch 'arcpatch-D16922' Modified: clang-tools-extra/trunk/clang-tidy/misc/VirtualNearMissCheck.cpp clang-tools-extra/trunk/clang-tidy/misc/VirtualNe

Re: [libcxx] r260235 - Introduce a cmake module to figure out whether we need to link with libatomic.

> we need to rename HAVE_CXX_ATOMICS_WITH_LIB to something like LIBCXX_HAVE_CXX_ATOMICS_WITH_LIB. Fixed in r260531. I think we will eventually want to merge the following commits, assuming they don't regress the build, especially with the -gcc-toolchain option. - [libcxx] r260515 - Re-commit "I

r260533 - [ARM] Add command-line options for ARMv8.2-A

Author: olista01 Date: Thu Feb 11 10:05:52 2016 New Revision: 260533 URL: http://llvm.org/viewvc/llvm-project?rev=260533&view=rev Log: [ARM] Add command-line options for ARMv8.2-A This allows ARMv8.2-A to be targeted either by using "armv8.2a" in the triple, or by using -march=armv8.2-a (or the a

Re: [PATCH] D15040: [ARM] Add command-line options for ARMv8.2-A

This revision was automatically updated to reflect the committed changes. Closed by commit rL260533: [ARM] Add command-line options for ARMv8.2-A (authored by olista01). Changed prior to commit: http://reviews.llvm.org/D15040?vs=41302&id=47650#toc Repository: rL LLVM http://reviews.llvm.org

Re: [PATCH] D17140: [clang-tidy] improve misc-misplaced-widening-cast so it also detects portability problems

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM http://reviews.llvm.org/D17140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D17143: When trying to get destructor name, make we have a complete type before calling LookupQualifiedName(), which will assert otherwise.

hintonda created this revision. hintonda added reviewers: doug.gregor, majnemer. hintonda added a subscriber: cfe-commits. Fix crash from PR25156 where getDestructorName() calls LookupQualifiedName() on incomplete type. http://reviews.llvm.org/D17143 Files: lib/Sema/SemaExprCXX.cpp test/Sem

Re: Linux-abi group

On Thu, Feb 11, 2016 at 8:05 AM, Suprateeka R Hegde wrote: > On 11-Feb-2016 07:21 PM, H.J. Lu wrote: >> >> On Thu, Feb 11, 2016 at 2:26 AM, Suprateeka R Hegde >> wrote: >>> >>> H.J, >>> >>> I think we are fragmenting with too many standards and mailing lists. >>> This >>> new discussion group and

[clang-tools-extra] r260535 - [clang-tidy] google-runtime-int: fix a false positive in implicit code.

Author: alexfh Date: Thu Feb 11 10:22:58 2016 New Revision: 260535 URL: http://llvm.org/viewvc/llvm-project?rev=260535&view=rev Log: [clang-tidy] google-runtime-int: fix a false positive in implicit code. Modified: clang-tools-extra/trunk/clang-tidy/google/IntegerTypesCheck.cpp clang-tool

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

congliu closed this revision. congliu added a comment. Closed by commit rL260532: Merge branch 'arcpatch-D16922' (authored by congliu ) http://reviews.llvm.org/D16922 ___ cfe-c

r260536 - Revert r260265, "clang-cl: Support loading plugins on Windows"

Author: chapuni Date: Thu Feb 11 10:33:20 2016 New Revision: 260536 URL: http://llvm.org/viewvc/llvm-project?rev=260536&view=rev Log: Revert r260265, "clang-cl: Support loading plugins on Windows" It causes memory exhaust on mingw-w64(x64). Investigating. Modified: cfe/trunk/docs/ClangPlugin

r260537 - Revert r260266 (and r260276), "clang-cl: Enable plugins on Windows"

Author: chapuni Date: Thu Feb 11 10:43:08 2016 New Revision: 260537 URL: http://llvm.org/viewvc/llvm-project?rev=260537&view=rev Log: Revert r260266 (and r260276), "clang-cl: Enable plugins on Windows" It doesn't work, at least, i686-win32. Modified: cfe/trunk/test/Frontend/plugins.c cfe

Re: [PATCH] D16973: Fix ICE with constexpr and friend functions

ogoffart added a comment. ping? http://reviews.llvm.org/D16973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: Linux-abi group

On Thu, 11 Feb 2016, Suprateeka R Hegde wrote: > H.J, > > I think we are fragmenting with too many standards and mailing lists. This new > discussion group and eventually the resulting standards, all might be put > under LSB http://refspecs.linuxfoundation.org/lsb.shtml > > The Intro on LSB says

Re: [PATCH] D17134: [clang-tidy] Fix an assert failure of ForStmt in `readability-braces-around-statements` check.

hokein added inline comments. Comment at: test/clang-tidy/readability-braces-around-statements-assert-failure.cpp:13 @@ +12,3 @@ + std::vector e; + for (typename std::vector::const_reverse_iterator iter = e.begin(), + end2 =

r260543 - [Modules] Don't infinite recurse on implicit import of circular modules in preamble

Author: benlangmuir Date: Thu Feb 11 11:04:42 2016 New Revision: 260543 URL: http://llvm.org/viewvc/llvm-project?rev=260543&view=rev Log: [Modules] Don't infinite recurse on implicit import of circular modules in preamble Update the Preprocessor's VisibleModuleSet when typo-correction creates a

Re: [PATCH] D16949: Fix for: Bug 5941 - improve diagnostic for * vs & confusion

dblaikie added a subscriber: dblaikie. dblaikie added a comment. Needs test coverage http://reviews.llvm.org/D16949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D17148: [OPENMP] Basic teams directive implementation

carlo.bertolli created this revision. carlo.bertolli added reviewers: ABataev, fraggamuffin, kkwli0. carlo.bertolli added subscribers: sfantao, arpith-jacob, cfe-commits. carlo.bertolli set the repository for this revision to rL LLVM. This patch implements the teams directive. It only provides sup

Re: [clang-tools-extra] r260532 - Merge branch 'arcpatch-D16922'

On Thu, Feb 11, 2016 at 8:03 AM, Cong Liu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: congliu > Date: Thu Feb 11 10:03:27 2016 > New Revision: 260532 > > URL: http://llvm.org/viewvc/llvm-project?rev=260532&view=rev > Log: > Merge branch 'arcpatch-D16922' > Please be sure to che

Re: r260543 - [Modules] Don't infinite recurse on implicit import of circular modules in preamble

Argh, I forgot to update my commit message after I changed this patch. Instead of updating the PP’s module set in typo-correction, which broke a submodule visibility test, I fixed this by not updating the PP’s module set in the astreader if the source location is invalid. > On Feb 11, 2016, at

Re: [PATCH] D17124: Add driver support for Qualcomm Kryo cpu.

rengolin added a comment. I'm assuming you also have the LLVM counterpart? http://reviews.llvm.org/D17124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16544: [libcxx] Framework to allow testing of static libc++abi

EricWF added a comment. Did you consider simply wrapping the library in "-Wl,-Bstatic" and "-Wl,-Bdynamic" linker flags? It seems like that would work almost as well as explicitly naming the target. Comment at: test/libcxx/test/config.py:463 @@ -462,2 +462,3 @@ else:

Re: [PATCH] D17124: Add driver support for Qualcomm Kryo cpu.

t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Tim. http://reviews.llvm.org/D17124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

Re: [PATCH] D16545: [libcxxabi] Enable testing for static libc++abi

EricWF added inline comments. Comment at: test/CMakeLists.txt:10 @@ -9,2 +9,3 @@ pythonize_bool(LLVM_BUILD_32_BITS) +pythonize_bool(LIBCXX_ENABLE_SHARED) pythonize_bool(LIBCXXABI_ENABLE_SHARED) This seems wrong for out of tree builds because LIBCXX_ENABLE_SHARED

Re: [PATCH] D17124: Add driver support for Qualcomm Kryo cpu.

mcrosier added a comment. In http://reviews.llvm.org/D17124#350130, @rengolin wrote: > I'm assuming you also have the LLVM counterpart? Yes, but I haven't made them public just yet. http://reviews.llvm.org/D17122 http://reviews.llvm.org/D17119 http://reviews.llvm.org/D17124 __

Re: [PATCH] D17132: [libcxx] Fix definition of regex_traits::__regex_word on big-endian glibc systems

dsanders added a comment. In http://reviews.llvm.org/D17132#349993, @mclow.lists wrote: > In r260527, I added some tests to catch this if it happens again. > > If those tests fail w/o this patch and succeed with, then I'm happy with > applying it. The tests in r260527, don't fail without this

r260548 - Revert "Revert r260388 "[MS ABI] Never reference dllimport'd vtables""

Author: majnemer Date: Thu Feb 11 11:49:28 2016 New Revision: 260548 URL: http://llvm.org/viewvc/llvm-project?rev=260548&view=rev Log: Revert "Revert r260388 "[MS ABI] Never reference dllimport'd vtables"" This reverts commit r260449. We would supress our emission of vftable definitions if we th

Re: [PATCH] D15998: Implement __attribute__((gc_leaf_function)).

mjacob abandoned this revision. mjacob added a comment. I experimented with another approach in the meantime. http://reviews.llvm.org/D15998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

r260552 - Remove unused includes

Author: majnemer Date: Thu Feb 11 11:54:39 2016 New Revision: 260552 URL: http://llvm.org/viewvc/llvm-project?rev=260552&view=rev Log: Remove unused includes Modified: cfe/trunk/lib/Tooling/Core/QualTypeNames.cpp Modified: cfe/trunk/lib/Tooling/Core/QualTypeNames.cpp URL: http://llvm.org/vi

r260555 - [Driver] Add support for Qualcomm's Kryo CPU.

Author: mcrosier Date: Thu Feb 11 12:09:31 2016 New Revision: 260555 URL: http://llvm.org/viewvc/llvm-project?rev=260555&view=rev Log: [Driver] Add support for Qualcomm's Kryo CPU. http://reviews.llvm.org/D17124 Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/lib/Driver/Tools.cpp

Re: [PATCH] D17124: Add driver support for Qualcomm Kryo cpu.

mcrosier closed this revision. mcrosier added a comment. Committed r260555. http://reviews.llvm.org/D17124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r260556 - Revert r260514 because it has a bogus commit message.

Author: ericwf Date: Thu Feb 11 12:21:18 2016 New Revision: 260556 URL: http://llvm.org/viewvc/llvm-project?rev=260556&view=rev Log: Revert r260514 because it has a bogus commit message. Modified: libcxx/trunk/include/unordered_map libcxx/trunk/test/std/containers/unord/unord.map/unord.m

Re: [PATCH] D17134: [clang-tidy] Fix an assert failure of ForStmt in `readability-braces-around-statements` check.

alexfh added inline comments. Comment at: test/clang-tidy/readability-braces-around-statements-assert-failure.cpp:13 @@ +12,3 @@ + std::vector e; + for (typename std::vector::const_reverse_iterator iter = e.begin(), + end2 =

Re: [PATCH] D17111: [CUDA] Added --cuda-noopt-device-debug option to control ptxas' debug info generation.

tra retitled this revision from "[CUDA] pass debug options to ptxas." to "[CUDA] Added --cuda-noopt-device-debug option to control ptxas' debug info generation.". tra updated the summary for this revision. tra updated this revision to Diff 47680. tra added a comment. Added --cuda-noopt-device-de

  1   2   3   >