[PATCH] D16396: Warn if variable cannot be implicitly instantiated

sepavloff created this revision. sepavloff added a reviewer: rsmith. sepavloff added subscribers: cfe-commits, silvas. Instantiation of static class members may be a source of user misunderstanding, especially in the case of using modules, PR24425 describes one of such examples. This patch impleme

[PATCH] D16400: [OpenMP] Sema for depend clause on target enter data directive.

arpith-jacob created this revision. arpith-jacob added reviewers: ABataev, kkwli0, hfinkel, sfantao, carlo.bertolli. arpith-jacob added subscribers: cfe-commits, fraggamuffin, caomhin. Accept depend clause on target enter data directive in sema and add test cases. http://reviews.llvm.org/D16400

[PATCH] D16401: [OpenMP] Sema for depend clause on target exit data directive.

arpith-jacob created this revision. arpith-jacob added reviewers: ABataev, kkwli0, hfinkel, sfantao, carlo.bertolli. arpith-jacob added subscribers: cfe-commits, fraggamuffin, caomhin. Accept depend clause on target exit data directive in sema and add test cases. http://reviews.llvm.org/D16401 F

Re: [PATCH] D16400: [OpenMP] Sema for depend clause on target enter data directive.

ABataev added a comment. Add tests for templates to test/OpenMP/target_enter_data_depend_messages.cpp http://reviews.llvm.org/D16400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r258394 - [OPENMP] Fix crash on reduction for complex variables.

Author: abataev Date: Thu Jan 21 06:35:58 2016 New Revision: 258394 URL: http://llvm.org/viewvc/llvm-project?rev=258394&view=rev Log: [OPENMP] Fix crash on reduction for complex variables. reworked codegen for reduction operation for complex types to avoid crash Modified: cfe/trunk/lib/CodeGe

Re: [PATCH] D16394: Add an isVirtualAsWritten AST matcher.

aaron.ballman accepted this revision. aaron.ballman added a comment. FWIW, LGTM as well. http://reviews.llvm.org/D16394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r258396 - Fix crash for typedefs for arrays of runtime bounds in Lambdas/Captured Statements, used in sizeof() expression only.

Author: abataev Date: Thu Jan 21 06:54:48 2016 New Revision: 258396 URL: http://llvm.org/viewvc/llvm-project?rev=258396&view=rev Log: Fix crash for typedefs for arrays of runtime bounds in Lambdas/Captured Statements, used in sizeof() expression only. Modified: cfe/trunk/lib/Sema/SemaExpr.cp

Re: [PATCH] D11035: trivial patch, improve constness

danielmarjamaki marked an inline comment as done. danielmarjamaki added a comment. http://reviews.llvm.org/D11035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11035: trivial patch, improve constness

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! http://reviews.llvm.org/D11035 __

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

danielmarjamaki added a comment. In http://reviews.llvm.org/D16310#331538, @LegalizeAdulthood wrote: > If you state what the check does, then > > In http://reviews.llvm.org/D16310#331054, @danielmarjamaki wrote: > > > In http://reviews.llvm.org/D16310#330367, @LegalizeAdulthood wrote: > > > > > W

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

danielmarjamaki marked an inline comment as done. Comment at: clang-tidy/misc/LongCastCheck.cpp:43 @@ +42,3 @@ + +static unsigned getMaxCalculationWidth(ASTContext &C, const Expr *E) { + E = E->IgnoreParenImpCasts(); LegalizeAdulthood wrote: > Prefer anonymous na

Re: [PATCH] D16400: [OpenMP] Sema for depend clause on target enter data directive.

arpith-jacob updated this revision to Diff 45525. arpith-jacob added a comment. Added template instantiation test case for all feasible tests. http://reviews.llvm.org/D16400 Files: include/clang/Basic/OpenMPKinds.def test/OpenMP/target_enter_data_ast_print.cpp test/OpenMP/target_enter_dat

Re: [PATCH] D16376: clang-tidy check: User-defined copy without assignment

aaron.ballman added inline comments. Comment at: clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.cpp:37 @@ +36,3 @@ + + DiagnosticBuilder Diag = diag(MatchedDecl->getLocation(), "class '%0' defines a copy-constructor but not an assignment operator") + << ClassName; --

[PATCH] D16406: [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

dsanders created this revision. dsanders added reviewers: mclow.lists, hans. dsanders added a subscriber: cfe-commits. http://reviews.llvm.org/D16406 Files: test/std/input.output/file.streams/fstreams/filebuf.virtuals/overflow.pass.cpp test/std/input.output/file.streams/fstreams/filebuf.virt

Re: [PATCH] D16406: [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

dsanders added a comment. Hi, I'd like to merge this to the 3.8 branch once it has been accepted. http://reviews.llvm.org/D16406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

alexfh added inline comments. Comment at: clang-tidy/misc/LongCastCheck.cpp:21 @@ +20,3 @@ + Finder->addMatcher( + returnStmt( + has(cStyleCastExpr(has(binaryOperator(anyOf(hasOperatorName("+"), Any reason to limit this to returnStmt, varDecl and as

Re: [PATCH] D16376: clang-tidy check: User-defined copy without assignment

alexfh added inline comments. Comment at: clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.cpp:32 @@ +31,3 @@ + + if (MatchedDecl->isImplicit()) +return; This check should be done in the matcher. Comment at: clang-tidy/misc/UserDefinedC

Re: [PATCH] D16376: clang-tidy check: User-defined copy without assignment

aaron.ballman added subscribers: dblaikie, rsmith. Comment at: clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.cpp:51 @@ +50,3 @@ + + Diag << FixItHint::CreateInsertion(CCtorEnd, Insertion.str()); +} alexfh wrote: > aaron.ballman wrote: > > We probably do n

Re: [PATCH] D16406: [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

bcraig added a subscriber: bcraig. bcraig added a comment. LGTM, but that doesn't mean much. I suspect that there are some tests that have snuck past this sweep, but I haven't done the work to figure out which ones. I base this statement off of these search results... LOCALE_en_US_UTF_8 found

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

danielmarjamaki marked an inline comment as done. Comment at: clang-tidy/misc/LongCastCheck.cpp:21 @@ +20,3 @@ + Finder->addMatcher( + returnStmt( + has(cStyleCastExpr(has(binaryOperator(anyOf(hasOperatorName("+"), alexfh wrote: > Any reason to limi

r258401 - When dumping documentation for AST matchers, do something more useful with \see doxygen commands. Ideally this would link to the target of \see, but for now it translates \see into "See also

Author: aaronballman Date: Thu Jan 21 09:18:25 2016 New Revision: 258401 URL: http://llvm.org/viewvc/llvm-project?rev=258401&view=rev Log: When dumping documentation for AST matchers, do something more useful with \see doxygen commands. Ideally this would link to the target of \see, but for now i

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

alexfh added inline comments. Comment at: clang-tidy/misc/LongCastCheck.cpp:21 @@ +20,3 @@ + Finder->addMatcher( + returnStmt( + has(cStyleCastExpr(has(binaryOperator(anyOf(hasOperatorName("+"), danielmarjamaki wrote: > alexfh wrote: > > Any reason

Re: [PATCH] D16406: [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

dsanders updated this revision to Diff 45531. dsanders added a comment. Added one more. It was also guarded by a check for ru_RU.UTF-8 so it was missed on the first sweep. http://reviews.llvm.org/D16406 Files: test/std/input.output/file.streams/fstreams/filebuf.virtuals/overflow.pass.cpp

Re: [PATCH] D16400: [OpenMP] Sema for depend clause on target enter data directive.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D16400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D16406: [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

dsanders added a comment. Thanks. I've added one more which came up after enabling all the missing locales except for en_US.UTF-8. I'll commit this and find the other 8 with grep afterwards. http://reviews.llvm.org/D16406 ___ cfe-commits mailing l

Re: [PATCH] D16401: [OpenMP] Sema for depend clause on target exit data directive.

arpith-jacob updated this revision to Diff 45532. arpith-jacob added a comment. Added template instantiation test case for all feasible tests. http://reviews.llvm.org/D16401 Files: include/clang/Basic/OpenMPKinds.def test/OpenMP/target_exit_data_ast_print.cpp test/OpenMP/target_exit_data_

Re: [PATCH] D16406: [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

This revision was automatically updated to reflect the committed changes. Closed by commit rL258403: [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8. (authored by dsanders). Changed prior to commit: http://reviews.llvm.org/D16406?vs=45531&id=45533#toc Repository

[libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

Author: dsanders Date: Thu Jan 21 09:35:15 2016 New Revision: 258403 URL: http://llvm.org/viewvc/llvm-project?rev=258403&view=rev Log: [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8. Reviewers: mclow.lists, hans Subscribers: bcraig, cfe-commits Differential Revi

[PATCH] D16408: [libcxx] Additional 'REQUIRE' directives for tests that require en_US.UTF-8.

dsanders created this revision. dsanders added reviewers: bcraig, mclow.lists, hans. dsanders added a subscriber: cfe-commits. These are the tests that didn't fail in the release candidate because they were covered by another 'REQUIRES' directive. http://reviews.llvm.org/D16408 Files: test/st

Re: [PATCH] D16376: clang-tidy check: User-defined copy without assignment

alexfh added inline comments. Comment at: docs/clang-tidy/checks/misc-user-defined-copy-without-assignment.rst:6 @@ +5,3 @@ + +MSVC 2015 will generate an assignment operator even if the user defines a copy constructor. +This check finds classes with a user-defined (including del

Re: [PATCH] D16408: [libcxx] Additional 'REQUIRE' directives for tests that require en_US.UTF-8.

dsanders added a comment. There's only 7 instead of the 8 we were expecting because one match turned out to be the python script that checks for the availability of the locale. http://reviews.llvm.org/D16408 ___ cfe-commits mailing list cfe-commits

Re: [PATCH] D16408: [libcxx] Additional 'REQUIRE' directives for tests that require en_US.UTF-8.

hans added a subscriber: dim. hans added a comment. +dim who said the locale tests were also failing for him on FreeBSD. Maybe this is relevant? http://reviews.llvm.org/D16408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

Re: [clang-tools-extra] r258356 - Make modernize-use-default tolerant of delayed template parsing; this code was previously causing failed assertions because dyn_cast was being passed a null pointer d

I'm fine with it. Alex, what do you think? On Wed, Jan 20, 2016 at 3:07 PM, Aaron Ballman wrote: > Uncertain whether this meets the bar for inclusion in 3.8. > clang-modernize was moved into clang-tidy and from what I can tell, it > did not suffer from this crash. I wouldn't normally recommend th

Re: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

Hi Marshall, Is this OK for 3.8? Daniel, I assume we want reviews.llvm.org/D16408 too when that lands, right? Thanks, Hans On Thu, Jan 21, 2016 at 7:35 AM, Daniel Sanders via cfe-commits wrote: > Author: dsanders > Date: Thu Jan 21 09:35:15 2016 > New Revision: 258403 > > URL: http://llvm.org/

RE: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

> Daniel, I assume we want reviews.llvm.org/D16408 too when that lands, > right? Yes, the tests in D16408 aren't blocking any particular build that I know of but we should still merge it. > -Original Message- > From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf > Of Hans

Re: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

On Thu, Jan 21, 2016 at 9:05 AM, Hans Wennborg wrote: > Hi Marshall, > > Is this OK for 3.8? > I have no idea; this is the first I've seen of it. Apparently it was posted on phab, no one approved it, and it was committed. In an hour. -- Marshall > > Daniel, I assume we want reviews.llvm.or

RE: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

Hi, It was LGTM'd by bcraig. From: Marshall Clow [mailto:mclow.li...@gmail.com] Sent: 21 January 2016 17:25 To: Hans Wennborg Cc: Daniel Sanders; cfe-commits Subject: Re: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8. On Thu, Jan 21, 2016 at

Re: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

On Thu, Jan 21, 2016 at 9:27 AM, Daniel Sanders wrote: > Hi, > > > > It was LGTM'd by bcraig. > Specifically, he said "LGTM, but that doesn't mean much." -- Marshall > > > *From:* Marshall Clow [mailto:mclow.li...@gmail.com] > *Sent:* 21 January 2016 17:25 > *To:* Hans Wennborg > *Cc:* Daniel

RE: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

I just took that as being humble. I'm happy to revert if you want. From: Marshall Clow [mailto:mclow.li...@gmail.com] Sent: 21 January 2016 17:29 To: Daniel Sanders Cc: Hans Wennborg; cfe-commits Subject: Re: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require e

Re: [PATCH][Modules][PR26179]

ping... (perhaps someone else with commit rights can check it it...) --Vassil On 18/01/16 22:07, Vassil Vassilev wrote: Thanks! Could you check it in? -- Vassil On 18/01/16 21:38, Richard Smith via cfe-commits wrote: LGTM On Jan 18, 2016 12:06 PM, "Vassil Vassilev" > w

RE: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

I'm not sure why my reply-all dropped Hans from the recipients. Re-added him. From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Daniel Sanders via cfe-commits Sent: 21 January 2016 17:31 To: Marshall Clow Cc: cfe-commits Subject: RE: [libcxx] r258403 - [libcxx] Add approp

[PATCH] D16413: Let RecursiveASTVisitor visit array index VarDecls

thakis created this revision. thakis added reviewers: rsmith, klimek. thakis added a subscriber: cfe-commits. Herald added a subscriber: klimek. An implicit copy ctor creates loop VarDecls that hang off CXXCtorInitializer. RecursiveASTVisitor used to not visit them, so that they didn't show up in

Re: [PATCH] D16413: Let RecursiveASTVisitor visit array index VarDecls

thakis updated this revision to Diff 45551. thakis added a comment. fix test name http://reviews.llvm.org/D16413 Files: include/clang/AST/RecursiveASTVisitor.h unittests/ASTMatchers/ASTMatchersTest.cpp Index: include/clang/AST/RecursiveASTVisitor.h =

Re: [PATCH] D8940: Clang changes for indirect call target profiling

betulb updated this revision to Diff 45550. betulb added a comment. In this revision: - Clang no longer attaches function names as metadata. - Bug fixed in checking the getNumValueSites return value. - Addressed review comments. http://reviews.llvm.org/D8940 Files: lib/CodeGen/CGCall.cpp l

r258415 - Add an isVirtualAsWritten AST matcher.

Author: nico Date: Thu Jan 21 11:56:24 2016 New Revision: 258415 URL: http://llvm.org/viewvc/llvm-project?rev=258415&view=rev Log: Add an isVirtualAsWritten AST matcher. http://reviews.llvm.org/D16394 Modified: cfe/trunk/docs/LibASTMatchersReference.html cfe/trunk/include/clang/ASTMatche

Re: [PATCH] D16394: Add an isVirtualAsWritten AST matcher.

thakis closed this revision. thakis added a comment. r258415, thanks! http://reviews.llvm.org/D16394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r258356 - Make modernize-use-default tolerant of delayed template parsing; this code was previously causing failed assertions because dyn_cast was being passed a null pointer d

I'm fine with including this to 3.8. BTW, I'm working on release notes. On Thu, Jan 21, 2016 at 6:01 PM, Hans Wennborg wrote: > I'm fine with it. Alex, what do you think? > > On Wed, Jan 20, 2016 at 3:07 PM, Aaron Ballman > wrote: > > Uncertain whether this meets the bar for inclusion in 3.8. >

Re: [clang-tools-extra] r258356 - Make modernize-use-default tolerant of delayed template parsing; this code was previously causing failed assertions because dyn_cast was being passed a null pointer d

Thanks. Aaron, do you want to go ahead and merge this with utils/release/merge.sh? Or let me know if you'd prefer me to do the merge. On Thu, Jan 21, 2016 at 10:00 AM, Alexander Kornienko wrote: > I'm fine with including this to 3.8. BTW, I'm working on release notes. > > On Thu, Jan 21, 2016 at

Re: [PATCH] D16376: clang-tidy check: User-defined copy without assignment

jbcoe removed rL LLVM as the repository for this revision. jbcoe updated this revision to Diff 45554. jbcoe added a comment. Made requested changes. http://reviews.llvm.org/D16376 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/UserDefinedCopyWitho

Re: [PATCH] D8940: Clang changes for indirect call target profiling

betulb marked 3 inline comments as done. Comment at: lib/CodeGen/CodeGenPGO.cpp:768 @@ +767,3 @@ +}; +Builder.CreateCall( +CGM.getIntrinsic(llvm::Intrinsic::instrprof_value_profile), Args); I removed the if check instead. It was not needed since th

Re: [PATCH] D16376: clang-tidy check: User-defined copy without assignment

jbcoe marked 5 inline comments as done. Comment at: clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.h:25 @@ +24,3 @@ +/// assignment operator to be `= delete`. +/// +/// For the user-facing documentation see: The standard says that compiler generation of the

Re: [PATCH] D16376: clang-tidy check: User-defined copy without assignment

jbcoe marked 2 inline comments as done. jbcoe added a comment. http://reviews.llvm.org/D16376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

On Wed, Jan 20, 2016 at 12:42 PM, Nico Weber wrote: > thakis added a comment. > > After some more debugging, the only thing in this test that's still > faiilng on Windows is the "unsigned-integer-overflow:do_overflow" > suppression -- when llvm-symbolizer gets symbols from PDBs it currently > req

Re: [PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

On Thu, Jan 21, 2016 at 1:19 PM, Alexey Samsonov wrote: > > On Wed, Jan 20, 2016 at 12:42 PM, Nico Weber wrote: > >> thakis added a comment. >> >> After some more debugging, the only thing in this test that's still >> faiilng on Windows is the "unsigned-integer-overflow:do_overflow" >> suppressi

Re: [PATCH] D16385: [OpenMP] Update map clause SEMA to support OpenMP 4.5 possible list items.

sfantao updated this revision to Diff 45557. sfantao retitled this revision from " [OpenMP] Update map clause SEMA to support OpenMP 4.5 possible list items." to "[OpenMP] Update map clause SEMA to support OpenMP 4.5 possible list items.". sfantao updated the summary for this revision. sfantao ad

Re: [PATCH] D15624: Add iOS/watchOS/tvOS support for ASan (clang part)

samsonov added a comment. Thanks. Comment at: lib/Driver/ToolChains.cpp:322 @@ -321,1 +321,3 @@ +StringRef Darwin::getOSLibraryNameSuffix() const { + if (isTargetMacOS()) Fun fact: if TargetPlatform is `TvOSSimulator`, this function will return `iossim` beca

[libcxx] r258418 - Implement LWG#2101 'Some transformation types can produce impossible types' Introduced a new (internal) type trait '__is_referenceable' with tests. Use that trait in add_lvalue_refe

Author: marshall Date: Thu Jan 21 12:22:43 2016 New Revision: 258418 URL: http://llvm.org/viewvc/llvm-project?rev=258418&view=rev Log: Implement LWG#2101 'Some transformation types can produce impossible types' Introduced a new (internal) type trait '__is_referenceable' with tests. Use that tra

Re: [PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

On Thu, Jan 21, 2016 at 10:20 AM, Nico Weber wrote: > On Thu, Jan 21, 2016 at 1:19 PM, Alexey Samsonov > wrote: > >> >> On Wed, Jan 20, 2016 at 12:42 PM, Nico Weber wrote: >> >>> thakis added a comment. >>> >>> After some more debugging, the only thing in this test that's still >>> faiilng on W

Re: [PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

On Thu, Jan 21, 2016 at 1:44 PM, Alexey Samsonov wrote: > > On Thu, Jan 21, 2016 at 10:20 AM, Nico Weber wrote: > >> On Thu, Jan 21, 2016 at 1:19 PM, Alexey Samsonov >> wrote: >> >>> >>> On Wed, Jan 20, 2016 at 12:42 PM, Nico Weber >>> wrote: >>> thakis added a comment. After so

Re: [PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

On Thu, Jan 21, 2016 at 10:47 AM, Nico Weber wrote: > Oh, ok, let's not depend on lld then. So, we need to either determine if >> DIA SDK is available at compiler-rt configure time, or teach >> llvm-symbolizer.exe to tell us that (as we support standalone compiler-rt >> build)... >> > > Maybe the

Re: [PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

samsonov added a comment. In http://reviews.llvm.org/D15225#328218, @zaks.anna wrote: > > I see, so essentially you want to use a different approach for determining > > sanitizer availability (on OS X for now): if the library is present, then > > we support > > > sanitizer, otherwise we don't

Re: [PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

On Thu, Jan 21, 2016 at 10:58 AM, Reid Kleckner wrote: > On Thu, Jan 21, 2016 at 10:47 AM, Nico Weber wrote: > >> Oh, ok, let's not depend on lld then. So, we need to either determine if >>> DIA SDK is available at compiler-rt configure time, or teach >>> llvm-symbolizer.exe to tell us that (as

Re: [PATCH] D16376: clang-tidy check: User-defined copy without assignment

jbcoe updated this revision to Diff 45573. jbcoe added a comment. Added symmetric check for user-defined assignment but no copy constructor. Check now adds '=default' to the missing special function if the user-specified one was specified as '=default'. Check needs renaming, I'll update it alon

Re: [PATCH] D16395: [Coverage] Reduce complexity of adding function mapping records

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D16395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

r258424 - [Coverage] Reduce complexity of adding function mapping records

Author: vedantk Date: Thu Jan 21 13:25:35 2016 New Revision: 258424 URL: http://llvm.org/viewvc/llvm-project?rev=258424&view=rev Log: [Coverage] Reduce complexity of adding function mapping records Replace a string append operation in addFunctionMappingRecord with a vector append. The existing be

Re: [PATCH] D16395: [Coverage] Reduce complexity of adding function mapping records

This revision was automatically updated to reflect the committed changes. Closed by commit rL258424: [Coverage] Reduce complexity of adding function mapping records (authored by vedantk). Changed prior to commit: http://reviews.llvm.org/D16395?vs=45491&id=45574#toc Repository: rL LLVM http:

Re: [clang-tools-extra] r258356 - Make modernize-use-default tolerant of delayed template parsing; this code was previously causing failed assertions because dyn_cast was being passed a null pointer d

On Thu, Jan 21, 2016 at 1:01 PM, Hans Wennborg wrote: > Thanks. > > Aaron, do you want to go ahead and merge this with > utils/release/merge.sh? Or let me know if you'd prefer me to do the > merge. I'd prefer if you'd handle the merge (I'm on Windows), if you don't mind. Thanks! ~Aaron > > On

Re: [PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

zaks.anna added a comment. > I don't know, is there a way to install runtime components for ASan if your > distribution doesn't happen to have one (that must be tricky, as the version > of ASan should match the version of the compiler). Correct, there is no recommended way of installing the

r258425 - [OpenMP] Check for at least one map clause on target data directive.

Author: arpith Date: Thu Jan 21 13:57:55 2016 New Revision: 258425 URL: http://llvm.org/viewvc/llvm-project?rev=258425&view=rev Log: [OpenMP] Check for at least one map clause on target data directive. Summary: Adds the following restriction in the OpenMP specifications. OpenMP [2.10.1, Restric

Re: [PATCH] D16341: [OpenMP] Check for at least one map clause on target data directive.

This revision was automatically updated to reflect the committed changes. Closed by commit rL258425 (authored by arpith). Changed prior to commit: http://reviews.llvm.org/D16341?vs=45332&id=45579#toc Repository: rL LLVM http://reviews.llvm.org/D16341 Files: cfe/trunk/lib/Sema/SemaOpenMP.c

Re: [PATCH] D16341: [OpenMP] Check for at least one map clause on target data directive.

arpith-jacob added a comment. Committed revision 258425. Repository: rL LLVM http://reviews.llvm.org/D16341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r258426 - [driver] Enable some static analyzer "unix" checkers on Windows.

Author: dcoughlin Date: Thu Jan 21 14:09:49 2016 New Revision: 258426 URL: http://llvm.org/viewvc/llvm-project?rev=258426&view=rev Log: [driver] Enable some static analyzer "unix" checkers on Windows. Many of the "unix" checkers are not actually unix-specific and would be valuable to run on Windo

Re: [PATCH] D16248: [Clang-tidy] rename misc-inefficient-algorithm to performance-inefficient-algorithm

xazax.hun added inline comments. Comment at: docs/clang-tidy/checks/performance-inefficient-algorithm.rst:3 @@ -2,3 +2,3 @@ -misc-inefficient-algorithm +performance-inefficient-algorithm == Eugene.Zelenko wrote: > alexfh wrote: > > After

Re: [libcxxabi] r258249 - Recommit r256322: Fix PR25898 - Check for incomplete pointers types in can_catch(...)

I'll merge all my commits tonight. Thanks Hans. /Eric On Wed, Jan 20, 2016 at 10:38 AM, Hans Wennborg wrote: > No problem. Please go ahead and merge with utils/release/merge.sh, or > let me know if you'd prefer me to do it. > > On Tue, Jan 19, 2016 at 7:09 PM, Eric Fiselier wrote: > > Hi Hans,

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

xur added a comment. Ping. Passmanagerbuilder change has been committed. Could you take a look at this command line option patch? Thanks, -Rong http://reviews.llvm.org/D15829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

Re: [PATCH] D16179: [clang-tidy] Handle decayed types and other improvements in VirtualNearMiss check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks! http://reviews.llvm.org/D16179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

LegalizeAdulthood added a comment. In http://reviews.llvm.org/D16310#332200, @danielmarjamaki wrote: > Why is there a cast in the first place? It is unlikely that the programmer > added a useless cast for no reason. If this has universally been your experience on a code base, then I say you s

Re: [clang-tools-extra] r258356 - Make modernize-use-default tolerant of delayed template parsing; this code was previously causing failed assertions because dyn_cast was being passed a null pointer d

On Thu, Jan 21, 2016 at 12:00 PM, Aaron Ballman wrote: > On Thu, Jan 21, 2016 at 1:01 PM, Hans Wennborg wrote: >> Thanks. >> >> Aaron, do you want to go ahead and merge this with >> utils/release/merge.sh? Or let me know if you'd prefer me to do the >> merge. > > I'd prefer if you'd handle the me

Re: r258394 - [OPENMP] Fix crash on reduction for complex variables.

Jack suggested (https://llvm.org/bugs/show_bug.cgi?id=26059#c7) that this should be merged to 3.8. Alexey, you're the code owner here. OK for merging? If yes, do you want to go ahead and merge with utils/release/merge.sh? On Thu, Jan 21, 2016 at 4:35 AM, Alexey Bataev via cfe-commits wrote: > Au

Re: r258396 - Fix crash for typedefs for arrays of runtime bounds in Lambdas/Captured Statements, used in sizeof() expression only.

Richard, it was suggested (in https://llvm.org/bugs/show_bug.cgi?id=26059#c7) that this gets merged to 3.8. I believe this falls under your ownership. On Thu, Jan 21, 2016 at 4:54 AM, Alexey Bataev via cfe-commits wrote: > Author: abataev > Date: Thu Jan 21 06:54:48 2016 > New Revision: 258396 >

Re: r258307 - [OPENMP 4.0] Fix for codegen of 'cancel' directive within 'sections' directive.

Jack suggested (https://llvm.org/bugs/show_bug.cgi?id=26059#c7) that this should be merged to 3.8. Alexey, you're the code owner here. OK for merging? If yes, do you want to go ahead and merge with utils/release/merge.sh? On Wed, Jan 20, 2016 at 4:29 AM, Alexey Bataev via cfe-commits wrote: > Au

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

LegalizeAdulthood added inline comments. Comment at: clang-tidy/misc/LongCastCheck.cpp:97 @@ +96,3 @@ + + if (!CastType->isIntegerType() || !SubType->isIntegerType()) +return; danielmarjamaki wrote: > LegalizeAdulthood wrote: > > Why don't you check for casti

Re: [PATCH] D13420: Fix deduction of __atomic_load's parameter types.

EricWF added a comment. ping. http://reviews.llvm.org/D13420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r258441 - [OpenMP] Parsing + Sema for nowait clause on target directive

Author: arpith Date: Thu Jan 21 16:18:28 2016 New Revision: 258441 URL: http://llvm.org/viewvc/llvm-project?rev=258441&view=rev Log: [OpenMP] Parsing + Sema for nowait clause on target directive Summary: Allow nowait clause on target directive in sema and add test cases. Reviewers: ABataev Diff

Re: [PATCH] D16358: [OpenMP] Parsing + Sema for nowait clause on target directive

This revision was automatically updated to reflect the committed changes. Closed by commit rL258441: [OpenMP] Parsing + Sema for nowait clause on target directive (authored by arpith). Changed prior to commit: http://reviews.llvm.org/D16358?vs=45399&id=45595#toc Repository: rL LLVM http://r

Re: [PATCH] D16163: [Concepts] Diagnose when return type of a function concept or declaration type of a variable concept is not bool.

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D16163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D16408: [libcxx] Additional 'REQUIRE' directives for tests that require en_US.UTF-8.

bcraig added a comment. LGTM. May want to wait on mclow though considering the trouble I helped cause with the last one of these. http://reviews.llvm.org/D16408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

Re: [PATCH] D15935: Improve diagnostics for literal conversion to Boolean

manmanren added a subscriber: manmanren. manmanren added a comment. Thanks for working on this. This looks good to me overall, but I am not the expert on Sema :] Cheers, Manman Comment at: lib/Sema/SemaChecking.cpp:6985 @@ -6984,6 +6984,3 @@ SmallString<16> PrettyTargetValu

Re: [PATCH] D16408: [libcxx] Additional 'REQUIRE' directives for tests that require en_US.UTF-8.

dsanders added a comment. Thanks. > May want to wait on mclow though considering the trouble I helped cause with > the last one of these. Sure. That wasn't your fault though, it was mine. I should have asked for clarification first. http://reviews.llvm.org/D16408

[PATCH] D16430: Fix printing of nested variable declarations with suppressed specifiers

nick.sumner created this revision. nick.sumner added reviewers: bkramer, rsmith. nick.sumner added a subscriber: cfe-commits. Allow nested variable declarations to have their types printed correctly even when the incoming PrintingPolicy suppresses specifiers. This can happen when initializing a va

r258447 - [MSVC Compat] Don't omit frame pointers if /Oy- is specified before /O2

Author: majnemer Date: Thu Jan 21 17:01:11 2016 New Revision: 258447 URL: http://llvm.org/viewvc/llvm-project?rev=258447&view=rev Log: [MSVC Compat] Don't omit frame pointers if /Oy- is specified before /O2 Microsoft's documentation states that specifying /Oy- after the /O[12x] options disables f

[PATCH] D16433: Fix printing signed character literals

nick.sumner created this revision. nick.sumner added reviewers: bkramer, rsmith. nick.sumner added a subscriber: cfe-commits. Allow StmtPrinter to print signed character literals. Given the code: char c = '\200'; The character literal is presently printed as: char c = '\Uff80'; The o

Re: [PATCH] D16361: [OpenMP] Parsing + Sema for nowait clause on target enter data directive.

This revision was automatically updated to reflect the committed changes. Closed by commit rL258457: [OpenMP] Parsing + Sema for nowait clause on target enter data directive. (authored by arpith). Changed prior to commit: http://reviews.llvm.org/D16361?vs=45409&id=45610#toc Repository: rL LL

r258457 - [OpenMP] Parsing + Sema for nowait clause on target enter data directive.

Author: arpith Date: Thu Jan 21 18:03:50 2016 New Revision: 258457 URL: http://llvm.org/viewvc/llvm-project?rev=258457&view=rev Log: [OpenMP] Parsing + Sema for nowait clause on target enter data directive. Summary: Accept nowait clause on target enter data directive in sema and add test cases.

Re: [PATCH] D16362: [OpenMP] Parsing + Sema for nowait clause on target exit data directive.

This revision was automatically updated to reflect the committed changes. Closed by commit rL258459: [OpenMP] Parsing + Sema for nowait clause on target exit data directive. (authored by arpith). Changed prior to commit: http://reviews.llvm.org/D16362?vs=45410&id=45614#toc Repository: rL LLV

r258459 - [OpenMP] Parsing + Sema for nowait clause on target exit data directive.

Author: arpith Date: Thu Jan 21 18:22:05 2016 New Revision: 258459 URL: http://llvm.org/viewvc/llvm-project?rev=258459&view=rev Log: [OpenMP] Parsing + Sema for nowait clause on target exit data directive. Summary: Accept nowait clause on target exit data directive in sema and add test cases. Re

Re: [PATCH] D16375: [OpenMP] Sema for depend clause on target directive.

This revision was automatically updated to reflect the committed changes. Closed by commit rL258460: [OpenMP] Sema for depend clause on target directive. (authored by arpith). Changed prior to commit: http://reviews.llvm.org/D16375?vs=45447&id=45616#toc Repository: rL LLVM http://reviews.ll

r258460 - [OpenMP] Sema for depend clause on target directive.

Author: arpith Date: Thu Jan 21 18:49:21 2016 New Revision: 258460 URL: http://llvm.org/viewvc/llvm-project?rev=258460&view=rev Log: [OpenMP] Sema for depend clause on target directive. Summary: Accept depend clause on target directive in sema and add test cases. Reviewers: ABataev Differential

r258461 - [analyzer] Suppress nullability warning for defensive super initializer idiom.

Author: dcoughlin Date: Thu Jan 21 19:01:11 2016 New Revision: 258461 URL: http://llvm.org/viewvc/llvm-project?rev=258461&view=rev Log: [analyzer] Suppress nullability warning for defensive super initializer idiom. A common idiom in Objective-C initializers is for a defensive nil-check on the res

[libcxx] r258463 - Merging r258217:

Author: ericwf Date: Thu Jan 21 19:08:10 2016 New Revision: 258463 URL: http://llvm.org/viewvc/llvm-project?rev=258463&view=rev Log: Merging r258217: r258217 | ericwf | 2016-01-19 16:06:29 -0700 (Tue, 19 Jan 2016) | 1 line F

  1   2   >