bcraig added a subscriber: bcraig. bcraig added a comment. LGTM, but that doesn't mean much.
I suspect that there are some tests that have snuck past this sweep, but I haven't done the work to figure out which ones. I base this statement off of these search results... LOCALE_en_US_UTF_8 found in 78 files underneath libcxx/test (prior to this change) locale.en_US.UTF-8 found in 46 files underneath libcxx/test (prior to this change) 23 new instances of locale.en_US.UTF-8 in this change. That suggests that there are at least 78 - (46+23) = 9 files that mention LOCALE_en_US_UTF_8 that don't have the REQUIRES clause. Maybe some other REQUIRES clause is making it so your test runs work. In my opinion, it is fine to leave that work for someone else. http://reviews.llvm.org/D16406 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
