On Thu, Jan 21, 2016 at 1:19 PM, Alexey Samsonov <vonos...@gmail.com> wrote:
> > On Wed, Jan 20, 2016 at 12:42 PM, Nico Weber <tha...@chromium.org> wrote: > >> thakis added a comment. >> >> After some more debugging, the only thing in this test that's still >> faiilng on Windows is the "unsigned-integer-overflow:do_overflow" >> suppression -- when llvm-symbolizer gets symbols from PDBs it currently >> requires the DIA SDK. If that's not found at cmake time, then >> llvm-symbolizer silently can't symbolize executables with pdb debug info. >> >> The test should probably have some "REQUIRES: symbols" thingie. (I'll >> also fix llvm not finding the DIA SDK in our build setup, but the test will >> still fail for others who don't have that.) >> > > Interesting, thanks for digging into this! IIRC the story with Dwarf > support on Windows (both producing it by Clang and consuming it by > llvm-symbolizer) got slightly better recently. Maybe, we can add a compiler > flag to force Clang emit Dwarf data on Windows in our compiler-rt test > suites? > It isn't heavily tested and it'd require using lld instead of link. I think it's possible. But most clients probably use PDBs for now, so maybe testing that is better, not sure. > > >> >> >> Repository: >> rL LLVM >> >> http://reviews.llvm.org/D15363 >> >> >> >> > > > -- > Alexey Samsonov > vonos...@gmail.com >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
