xazax.hun added a comment.
This looks good to me, I have one question inline.
Comment at: lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp:425
@@ +424,3 @@
+llvm::DenseMap CaptureFields;
+FieldDecl *ThisCaptureField;
+LambdaClass->getCaptureFields(CaptureFields, Thi
Richard, this is still optional, right? (the AST matchers need to control
visitation)
On Tue, Nov 17, 2015 at 2:26 AM Argyrios Kyrtzidis via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> W00t! That’s awesome Richard!
>
> On Nov 16, 2015, at 5:10 PM, Richard Smith wrote:
>
> Attached patch m
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2514
@@ -2513,1 +2513,3 @@
+ if (FName.endswith("postEvent") &&
+ FD->getQualifiedNameAsString() == "QCoreApplication::postEvent") {
Shouldn't you use == instead of
LOn Nov 17, 2015 12:49 AM, "Manuel Klimek" wrote:
> Richard, this is still optional, right? (the AST matchers need to control
visitation)
This doesn't change RAV semantics at all (or if it does, it's a bug). If
any of the extension points are overridden in the derived class, data
recursion is aut
On Tue, Nov 17, 2015 at 10:14 AM Richard Smith
wrote:
> LOn Nov 17, 2015 12:49 AM, "Manuel Klimek" wrote:
> > Richard, this is still optional, right? (the AST matchers need to
> control visitation)
>
> This doesn't change RAV semantics at all (or if it does, it's a bug). If
> any of the extensio
On 16 November 2015 at 23:09, Stephen Canon via cfe-commits
wrote:
> Author: scanon
> Date: Mon Nov 16 17:09:11 2015
> New Revision: 253269
>
> URL: http://llvm.org/viewvc/llvm-project?rev=253269&view=rev
> Log:
> Make FP_CONTRACT ON the default.
>
> Differential Revision: D14200
Hi Stephen,
It
d.zobnin.bugzilla updated this revision to Diff 40380.
d.zobnin.bugzilla added a comment.
Only tests have been updated: enabled a test case for Sema, which pass with
these changes, added corresponding test case for CodeGen.
http://reviews.llvm.org/D14467
Files:
include/clang/Sema/Sema.h
li
d.zobnin.bugzilla added inline comments.
Comment at: test/SemaCXX/pragma-vtordisp.cpp:34-35
@@ -33,6 +33,4 @@
struct C {
-// FIXME: Our implementation based on token insertion makes it impossible for
-// the pragma to appear everywhere we should support it.
-//#pragma vtordisp(
sdardis updated this revision to Diff 40382.
sdardis marked 12 inline comments as done.
sdardis added a comment.
Updated documentation text.
Switched the various hard failures to semantic warnings/failures.
Strangely, the 'interrupt' attribute on a non-function defaults to a warning.
Thanks.
> On Nov 17, 2015, at 4:51 AM, Renato Golin wrote:
>
> On 16 November 2015 at 23:09, Stephen Canon via cfe-commits
> wrote:
>> Author: scanon
>> Date: Mon Nov 16 17:09:11 2015
>> New Revision: 253269
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=253269&view=rev
>> Log:
>> Make FP_CONTRACT
- Original Message -
> From: "Renato Golin via cfe-commits"
> To: "Stephen Canon"
> Cc: "Clang Commits"
> Sent: Tuesday, November 17, 2015 3:51:23 AM
> Subject: Re: r253269 - Make FP_CONTRACT ON the default.
>
> On 16 November 2015 at 23:09, Stephen Canon via cfe-commits
> wrote:
> > A
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: aaron.ballman.
DmitryPolukhin added a subscriber: cfe-commits.
Add support for vector mode attributes like "__attribute__((mode(V4SF)))". Also
add warning about deprecated vector modes like GCC does.
http://reviews.llvm.org/D
Note that due to this change we're hitting an assert at
lib/CodeGen/CGExprScalar.cpp:2570 in llvm::Value *tryEmitFMulAdd(const
(anonymous namespace)::BinOpInfo &, const clang::CodeGen::CodeGenFunction
&, clang::CodeGen::CGBuilderTy &, bool): LHSBinOp->getNumUses(
) == 0 && "Operations with multiple
ABataev added inline comments.
Comment at: include/clang/AST/OpenMPClause.h:2660-2662
@@ +2659,5 @@
+ ///
+ /// \param StartLoc Starting location of the clause.
+ /// \param EndLoc Ending location of the clause.
+ /// \param N Number of the variables in the clause.
+ ///
thiagomacieira added a comment.
In http://reviews.llvm.org/D14727#290661, @jroelofs wrote:
> hHave a look at the svn-blame for this file, then find other commits which
> changed this part of the file, and see where those commits added tests.
Thanks, looks like 189212 has a way to do it.
http
thiagomacieira updated this revision to Diff 40370.
thiagomacieira added a comment.
v3: updated to add unit testing
http://reviews.llvm.org/D14727
Files:
lib/Driver/ToolChains.cpp
test/Driver/Inputs/gcc_version_parsing5/bin/.keep
test/Driver/Inputs/gcc_version_parsing5/lib/gcc/i386-unkno
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:255
@@ -254,1 +254,3 @@
def err_parameter_name_omitted : Error<"parameter name omitted">;
+def err_excess_arguments : Error<"function %0 has too many arguments">;
+def err_wrong_return_typ
pgousseau added a comment.
Ping!
http://reviews.llvm.org/D13731
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Looks good to me. I'm not too worried about the compactness of the
visitor class.
On 11/16/2015 7:10 PM, Richard Smith wrote:
Attached patch makes RAV fully data-recursive when visiting
statements, except in cases where the derived class could tell the
difference (when it falls back to a norm
Author: klimek
Date: Tue Nov 17 09:40:10 2015
New Revision: 253337
URL: http://llvm.org/viewvc/llvm-project?rev=253337&view=rev
Log:
Revert "Make FP_CONTRACT ON the default."
This reverts commit r253269.
This leads to assert / segfault triggering on the following reduced example:
float foo(float
Repro:
float foo(float U, float base, float cell) { return (U = 2 * base) - cell; }
Preparing rollback of the CL.
On Tue, Nov 17, 2015 at 2:46 PM Manuel Klimek wrote:
> Note that due to this change we're hitting an assert at
> lib/CodeGen/CGExprScalar.cpp:2570 in llvm::Value *tryEmitFMulAdd(cons
Reverted in r253337. Failing test case in commit message.
On Tue, Nov 17, 2015 at 4:39 PM Manuel Klimek wrote:
> Repro:
> float foo(float U, float base, float cell) { return (U = 2 * base) - cell;
> }
> Preparing rollback of the CL.
>
> On Tue, Nov 17, 2015 at 2:46 PM Manuel Klimek wrote:
>
>>
hans created this revision.
hans added reviewers: thakis, echristo.
hans added a subscriber: cfe-commits.
The tzcnt intrinsics are used non non-BMI targets by code (e.g. ffmpeg) that
uses it as a potentially faster BSF.
The TZCNT instruction is special in that it's encoded in a backward-compatib
Author: dougk
Date: Tue Nov 17 11:41:23 2015
New Revision: 253350
URL: http://llvm.org/viewvc/llvm-project?rev=253350&view=rev
Log:
Add trivial utility to append -L arguments to linker step. NFC
Modified:
cfe/trunk/include/clang/Driver/ToolChain.h
cfe/trunk/lib/Driver/ToolChain.cpp
cf
aaron.ballman added a comment.
I am a little bit confused -- this patch adds a deprecation warning for vector
sizes and claims that the attribute is ignored (by placing it in the
IgnoredAttributes group), but then provides the initial implementation for this
functionality and makes use of the a
Author: tnorthover
Date: Tue Nov 17 12:27:27 2015
New Revision: 253355
URL: http://llvm.org/viewvc/llvm-project?rev=253355&view=rev
Log:
ARM: fix mismatch between Clang and backend on exception type.
"-arch armv7k" is only normally used with a watchos target, but Clang doesn't
stop you from givin
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:829
@@ +828,3 @@
+ if (Type > 3) {
+S.Diag(E->getLocStart(), diag::err_attribute_argument_outof_range)
+ << Attr.getName() << 0 << 3 << E->getSourceRange();
>> I'm wondering why t
thakis added a comment.
Looks good. The reasoning is that without this, projects will put in an `#if
__clang__ no tzcnt` path (e.g.
http://ffmpeg.org/pipermail/ffmpeg-devel/2015-November/183408.html), and with
this patch they won't and in a few years when people use build flags that allow
BMI
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Sounds good to me. Weird, but fine :)
-eric
http://reviews.llvm.org/D14748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
Author: hans
Date: Tue Nov 17 12:46:48 2015
New Revision: 253358
URL: http://llvm.org/viewvc/llvm-project?rev=253358&view=rev
Log:
bmiintrin.h: Allow using the tzcnt intrinsics for non-BMI targets
The tzcnt intrinsics are used non non-BMI targets by code (e.g. ffmpeg)
that uses it as a potentiall
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253358: bmiintrin.h: Allow using the tzcnt intrinsics for
non-BMI targets (authored by hans).
Changed prior to commit:
http://reviews.llvm.org/D14748?vs=40399&id=40411#toc
Repository:
rL LLVM
http:/
On 17 November 2015 at 15:47, Manuel Klimek wrote:
> Reverted in r253337. Failing test case in commit message.
And the bot is green again! :)
Thanks!
--renato
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
DmitryPolukhin added a comment.
Thank you for prompt response!
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2765
@@ +2764,3 @@
+def warn_vector_mode_deprecated : Warning<
+ "specifying vector types with __attribute__ ((mode)) is deprecated, "
+ "use __attribute__ ((v
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2765
@@ +2764,3 @@
+def warn_vector_mode_deprecated : Warning<
+ "specifying vector types with __attribute__ ((mode)) is deprecated, "
+ "use __attribute__ ((vector_size)) instead">,
craig.topper added a subscriber: craig.topper.
craig.topper added a comment.
The summary of why this is ok is slightly misleading. The backend won't try to
encode the TZCNT instruction when the BMI feature is not enabled. Notice this
just maps the to the generic non-x86 specific __builtin_ctz. T
On Tue, Nov 17, 2015 at 11:32 AM, Craig Topper
wrote:
> craig.topper added a subscriber: craig.topper.
> craig.topper added a comment.
>
> The summary of why this is ok is slightly misleading.
I read this as reason why programs might try to use this, not why this
change here is correct. (This c
Author: lcharles
Date: Tue Nov 17 14:25:05 2015
New Revision: 253371
URL: http://llvm.org/viewvc/llvm-project?rev=253371&view=rev
Log:
[Lit Test] Updated 34 Lit tests to be C++11 compatible.
Added expected diagnostics new to C++11.
Expanded RUN line to: default, C++98/03 and C++11.
Modified:
Author: dougk
Date: Tue Nov 17 14:28:07 2015
New Revision: 253372
URL: http://llvm.org/viewvc/llvm-project?rev=253372&view=rev
Log:
Use !hasArg with two options instead of !hasArg && !hasArg.
Thereby fixing a warning about failure to claim all args.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
rizsotto.mailinglist added a comment.
In http://reviews.llvm.org/D9600#290031, @jroelofs wrote:
> Thanks for re-uploading!
thanks for your comments! :)
most of your comments are about to embed it more into the clang build, test
infrastructure. i think these are valid points!
i would like to
Author: marshall
Date: Tue Nov 17 15:04:24 2015
New Revision: 253376
URL: http://llvm.org/viewvc/llvm-project?rev=253376&view=rev
Log:
Add tests for the extended integer types - as required by LWG#2119
Modified:
libcxx/trunk/test/std/utilities/function.objects/unord.hash/integral.pass.cpp
M
dougk created this revision.
dougk added a reviewer: jyknight.
dougk added a subscriber: cfe-commits.
Herald added a subscriber: jyknight.
http://reviews.llvm.org/D14754
Files:
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
lib/Driver/Tools.cpp
test/Driver/Inputs/basic_myriad_tree/lib/
pete updated this revision to Diff 40426.
pete added a comment.
Updated the driver test to ensure that the option is set for tvOS and watchOS.
http://reviews.llvm.org/D14737
Files:
include/clang/Basic/LangOptions.def
include/clang/Basic/ObjCRuntime.h
include/clang/Driver/Options.td
lib/
rjmccall added inline comments.
Comment at: include/clang/Basic/LangOptions.def:194
@@ -193,2 +193,3 @@
LANGOPT(ObjCAutoRefCount , 1, 0, "Objective-C automated reference counting")
+LANGOPT(ObjCConvertMessagesToRuntimeCalls , 1, 0, "objc_* support for
retain/release in t
rmaprath added a comment.
@rengolin: Gentle ping.
Cheers,
- Asiri
http://reviews.llvm.org/D14293
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Tue Nov 17 15:48:29 2015
New Revision: 253382
URL: http://llvm.org/viewvc/llvm-project?rev=253382&view=rev
Log:
Fix bad variable name. project_root -> project_obj_root
Modified:
libcxx/trunk/test/libcxx/test/config.py
Modified: libcxx/trunk/test/libcxx/test/config.py
URL
tyomitch created this revision.
tyomitch added reviewers: rengolin, bogden, compnerd.
tyomitch added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
Clang-side update, corresponding to D14755
http://reviews.llvm.org/D14756
Files:
test/Driver/arm-cortex-cpus.c
Index: t
Author: tra
Date: Tue Nov 17 16:28:46 2015
New Revision: 253386
URL: http://llvm.org/viewvc/llvm-project?rev=253386&view=rev
Log:
[CUDA] added include paths for both sides of CUDA compilation.
In order to compile a CUDA file clang must be able to find
include files for both both host and device.
Author: tra
Date: Tue Nov 17 16:28:50 2015
New Revision: 253387
URL: http://llvm.org/viewvc/llvm-project?rev=253387&view=rev
Log:
[CUDA] Detect and link with CUDA's libdevice bitcode library.
- added detection of libdevice bitcode file and API to find one appropriate for
the GPU we're compiling
Author: tra
Date: Tue Nov 17 16:28:40 2015
New Revision: 253385
URL: http://llvm.org/viewvc/llvm-project?rev=253385&view=rev
Log:
[CUDA] use -aux-triple to pass target triple of opposite side of compilation
Clang needs to know target triple for both sides of compilation so that
preprocessor macro
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253385: [CUDA] use -aux-triple to pass target triple of
opposite side of compilation (authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D13144?vs=40163&id=40432#toc
Repository:
rL LL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253386: [CUDA] added include paths for both sides of CUDA
compilation. (authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D13170?vs=39860&id=40433#toc
Repository:
rL LLVM
http://rev
jyknight added inline comments.
Comment at: lib/Driver/ToolChains.cpp:4319
@@ +4318,3 @@
+ // This contains libc, libg (a superset of libc), libm, libstdc++, libssp.
+ SmallString<128> LibDir(GCCInstallation.getParentLibPath());
+ if (Triple.getArch() == llvm::Triple::sparcel)
Author: tra
Date: Tue Nov 17 16:28:52 2015
New Revision: 253388
URL: http://llvm.org/viewvc/llvm-project?rev=253388&view=rev
Log:
[CUDA] Added a wrapper header for inclusion of stock CUDA headers.
Header files that come with CUDA are assuming split host/device
compilation and are not usable by cl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253387: [CUDA] Detect and link with CUDA's libdevice bitcode
library. (authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D14556?vs=39863&id=40434#toc
Repository:
rL LLVM
http://revi
Author: tra
Date: Tue Nov 17 16:28:55 2015
New Revision: 253389
URL: http://llvm.org/viewvc/llvm-project?rev=253389&view=rev
Log:
[CUDA] Make CUDA compilation usable by default.
Currently clang requires several additional command
line options in order to enable new features needed
during CUDA com
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253388: [CUDA] Added a wrapper header for inclusion of stock
CUDA headers. (authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D13171?vs=38574&id=40435#toc
Repository:
rL LLVM
http:/
tyomitch created this revision.
tyomitch added reviewers: t.p.northover, rengolin.
tyomitch added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
Clang-side update, corresponding to D14757
http://reviews.llvm.org/D14758
Files:
lib/Driver/Tools.cpp
Index: lib/Driver/To
Author: dougk
Date: Tue Nov 17 16:33:34 2015
New Revision: 253390
URL: http://llvm.org/viewvc/llvm-project?rev=253390&view=rev
Log:
[Myriad]: -nostdlib implies -nostartfiles
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/myriad-toolchain.c
Modified: cfe/trunk/lib/Driver/T
dougk updated this revision to Diff 40442.
dougk marked 2 inline comments as done.
dougk added a comment.
changes per jyknight
http://reviews.llvm.org/D14754
Files:
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
lib/Driver/Tools.cpp
test/Driver/Inputs/basic_myriad_tree/lib/gcc/sparc-
Author: rsmith
Date: Tue Nov 17 17:32:01 2015
New Revision: 253398
URL: http://llvm.org/viewvc/llvm-project?rev=253398&view=rev
Log:
[modules] When a #include is mapped to a module import and appears somewhere
other than the top level, we issue an error. This breaks a fair amount of C++
code wrapp
Author: mgehre
Date: Tue Nov 17 17:35:39 2015
New Revision: 253399
URL: http://llvm.org/viewvc/llvm-project?rev=253399&view=rev
Log:
Fix bug 25362 "cppcoreguidelines-pro-bounds-array-to-pointer-decay does not
consider const"
Summary:
The current matcher is
implicitCastExpr(unless(hasParent(exp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253399: Fix bug 25362
"cppcoreguidelines-pro-bounds-array-to-pointer-decay does not… (authored by
mgehre).
Changed prior to commit:
http://reviews.llvm.org/D14517?vs=39948&id=40446#toc
Repository:
r
On Tue, Nov 17, 2015 at 3:32 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Tue Nov 17 17:32:01 2015
> New Revision: 253398
>
> URL: http://llvm.org/viewvc/llvm-project?rev=253398&view=rev
> Log:
> [modules] When a #include is mapped to a module imp
mgehre updated this revision to Diff 40448.
mgehre added a comment.
Simplified with Alex suggestion. Thanks!
http://reviews.llvm.org/D14582
Files:
clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.cpp
test/clang-tidy/cppcoreguidelines-pro-bounds-pointer-arithmetic.cpp
Index: tes
Author: mgehre
Date: Tue Nov 17 17:43:20 2015
New Revision: 253401
URL: http://llvm.org/viewvc/llvm-project?rev=253401&view=rev
Log:
[clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index
Summary:
This check flags all array subscriptions on static arrays and
std::arrays that eit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253401: [clang-tidy] add check
cppcoreguidelines-pro-bounds-constant-array-index (authored by mgehre).
Changed prior to commit:
http://reviews.llvm.org/D13746?vs=39953&id=40449#toc
Repository:
rL LLV
ahatanak added a comment.
Thanks, I'll commit this patch shortly.
If it makes the code cleaner, I can define enums in TargetInfo and change
validateGlobalRegisterVariable to return one of them in a follow-up patch.
http://reviews.llvm.org/D13834
_
On Tue, Nov 17, 2015 at 3:40 PM, David Blaikie wrote:
> On Tue, Nov 17, 2015 at 3:32 PM, Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rsmith
>> Date: Tue Nov 17 17:32:01 2015
>> New Revision: 253398
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=253398&vie
Author: betulb
Date: Tue Nov 17 18:14:08 2015
New Revision: 253404
URL: http://llvm.org/viewvc/llvm-project?rev=253404&view=rev
Log:
[PGO] Removed unused code. [NFC]
Modified:
cfe/trunk/lib/CodeGen/CodeGenPGO.h
Modified: cfe/trunk/lib/CodeGen/CodeGenPGO.h
URL:
http://llvm.org/viewvc/llvm-p
On Tue, Nov 17, 2015 at 4:15 PM, Richard Smith
wrote:
> On Tue, Nov 17, 2015 at 3:40 PM, David Blaikie wrote:
>
>> On Tue, Nov 17, 2015 at 3:32 PM, Richard Smith via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author: rsmith
>>> Date: Tue Nov 17 17:32:01 2015
>>> New Revision: 253
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253405: Produce a better diagnostic for global register
variables. (authored by ahatanak).
Changed prior to commit:
http://reviews.llvm.org/D13834?vs=39774&id=40451#toc
Repository:
rL LLVM
http://re
Author: ahatanak
Date: Tue Nov 17 18:15:28 2015
New Revision: 253405
URL: http://llvm.org/viewvc/llvm-project?rev=253405&view=rev
Log:
Produce a better diagnostic for global register variables.
Currently, when there is a global register variable in a program that
is bound to an invalid register,
Author: tra
Date: Tue Nov 17 18:37:41 2015
New Revision: 253410
URL: http://llvm.org/viewvc/llvm-project?rev=253410&view=rev
Log:
Fix for use-after-free which caused test failure in cuda-detect.cu.
Return std::string itself instead StringRef to a temporary std::string.
Modified:
cfe/trunk/li
Hi Matthias,
This is failing on the green dragon bot:
http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/13184/
http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/13184/consoleFull#54616856949ba4694-19c4-4d7e-bec5-911270d8a58c
Thanks,
On Tue, Nov 17, 2015 at 3:43
zaks.anna closed this revision.
zaks.anna added a comment.
Committed in r251449.
http://reviews.llvm.org/D13488
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This introduced a memory leak, which I'm testing a patch for.
Aside from that, did you get Doug to review this? We probably want to be
really careful about changing libclang's C API, so you should be more
cautious here than you would be normally.
On Wed, Nov 11, 2015 at 7:57 PM, Saleem Abdulrasoo
Author: rnk
Date: Tue Nov 17 19:06:39 2015
New Revision: 253418
URL: http://llvm.org/viewvc/llvm-project?rev=253418&view=rev
Log:
Try to fix leak in CXStringSet from r252853
Modified:
cfe/trunk/tools/libclang/CXString.cpp
Modified: cfe/trunk/tools/libclang/CXString.cpp
URL:
http://llvm.org/
On Tue, Nov 17, 2015 at 4:37 PM, Artem Belevich via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: tra
> Date: Tue Nov 17 18:37:41 2015
> New Revision: 253410
>
> URL: http://llvm.org/viewvc/llvm-project?rev=253410&view=rev
> Log:
> Fix for use-after-free which caused test failure in c
zaks.anna added inline comments.
Comment at: test/Analysis/inline.cpp:308
@@ +307,3 @@
+clang_analyzer_eval(0 != void_string); // expected-warning{{TRUE}}
+clang_analyzer_eval(0 != ((char *)void_string)[1]); //
expected-warning{{TRUE}}
+ }
Why are we che
Author: rsmith
Date: Tue Nov 17 19:19:02 2015
New Revision: 253420
URL: http://llvm.org/viewvc/llvm-project?rev=253420&view=rev
Log:
Don't expose iterators into the list of types on the ASTContext; these are
unsafe, since many operations on the types can trigger lazy deserialization of
more types
getLibDeviceFile only used once per device-side compilation in driver, so
returning the string should be OK here.
BTW, would copy elision kick in when I use std::string Path =
getLibDeviceFile("foo"); ?
--Artem
On Tue, Nov 17, 2015 at 5:12 PM, David Blaikie wrote:
>
>
> On Tue, Nov 17, 2015 at
On Tue, Nov 17, 2015 at 5:35 PM, Artem Belevich wrote:
> getLibDeviceFile only used once per device-side compilation in driver, so
> returning the string should be OK here.
>
> BTW, would copy elision kick in when I use std::string Path =
> getLibDeviceFile("foo"); ?
>
Yeah - if the caller needs
Author: chapuni
Date: Tue Nov 17 20:14:35 2015
New Revision: 253428
URL: http://llvm.org/viewvc/llvm-project?rev=253428&view=rev
Log:
Revert r253401, "[clang-tidy] add check
cppcoreguidelines-pro-bounds-constant-array-index"
cppcoreguidelines-pro-bounds-constant-array-index.cpp is failing in sev
chapuni added a subscriber: chapuni.
chapuni added a comment.
I have reverted in r253428, since I can reproduce failure locally. I'll
investigate later, too.
Comment at:
clang-tools-extra/trunk/test/clang-tidy/cppcoreguidelines-pro-bounds-constant-array-index.cpp:2
@@ +1,3 @@
stephanemoore added a subscriber: stephanemoore.
stephanemoore added a comment.
I hope that it's not presumptuous of me to inquire but I was wondering if the
intent of this patch is to optimize calls to RR methods (and alloc) in non-ARC
code? Would I be correct in assuming that clang will alread
rjmccall added a comment.
In http://reviews.llvm.org/D14737#291481, @stephanemoore wrote:
> I hope that it's not presumptuous of me to inquire but I was wondering if the
> intent of this patch is to optimize calls to RR methods (and alloc) in
> non-ARC code? Would I be correct in assuming that
Author: faisalv
Date: Tue Nov 17 22:29:22 2015
New Revision: 253431
URL: http://llvm.org/viewvc/llvm-project?rev=253431&view=rev
Log:
[NFC] Change the evaluation context of a non-type default template argument
from Unevaluated to ConstantEvaluated.
This patch emits a more appropriate (but stil
ygribov added inline comments.
Comment at: test/Analysis/inline.cpp:308
@@ +307,3 @@
+clang_analyzer_eval(0 != void_string); // expected-warning{{TRUE}}
+clang_analyzer_eval(0 != ((char *)void_string)[1]); //
expected-warning{{TRUE}}
+ }
zaks.anna wrote:
Author: chapuni
Date: Tue Nov 17 23:15:21 2015
New Revision: 253434
URL: http://llvm.org/viewvc/llvm-project?rev=253434&view=rev
Log:
BuildUniversalActions(): Prune obsolete \param(s). [-Wdocumentation]
FIXME: Describe BAInputs.
Modified:
cfe/trunk/include/clang/Driver/Driver.h
Modified: cf
Author: compnerd
Date: Tue Nov 17 23:33:38 2015
New Revision: 253435
URL: http://llvm.org/viewvc/llvm-project?rev=253435&view=rev
Log:
c++abi: use __builtin_offsetof instead of offsetof
Use `__builtin_offsetof` in place of `offsetof`. Certain environments provide a
macro definition of `offsetof`
Author: rafael
Date: Wed Nov 18 00:54:13 2015
New Revision: 253440
URL: http://llvm.org/viewvc/llvm-project?rev=253440&view=rev
Log:
Update for llvm change.
Modified:
cfe/trunk/include/clang/Lex/HeaderSearchOptions.h
cfe/trunk/lib/CodeGen/CGObjCMac.cpp
Modified: cfe/trunk/include/clang/L
Author: ctopper
Date: Wed Nov 18 01:08:11 2015
New Revision: 253442
URL: http://llvm.org/viewvc/llvm-project?rev=253442&view=rev
Log:
Replace a dyn_cast with isa where the result was only being used as a boolean.
NFC.
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/UseDefaultCheck.cpp
92 matches
Mail list logo
