Re: Implict casts disappeared from syntactic init list expressions in C++

Il 08/10/2015 23:36, Richard Smith ha scritto: > There are some other open problems in this area: > > - RecursiveASTVisitor on nested InitListExprs is currently worst-case > exponential time because it walks the syntactic and semantic forms > separately > - Tools such as "find all references to th

Re: [PATCH] D13099: [Analyzer] Don’t invalidate CXXThis when conservatively evaluating const methods (PR 21606)

seaneveson updated this revision to Diff 36927. seaneveson added a comment. Updated to latest trunk. Added FIXME test for circular reference issue. http://reviews.llvm.org/D13099 Files: include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h lib/StaticAnalyzer/Core/CallEvent.cpp test/

[PATCH] D13582: [DEBUG INFO] Emit debug info for type used in explicit cast only.

ABataev created this revision. ABataev added a reviewer: echristo. ABataev added a subscriber: cfe-commits. Currently debug info for types used in explicit cast only is not emitted. It happened after a patch for better alignment handling. This patch fixes this bug. http://reviews.llvm.org/D13582

Re: [PATCH] D13474: [VFS] Port tooling to use the in-memory file system.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D13474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

r249815 - [VFS] Port tooling to use the in-memory file system.

Author: d0k Date: Fri Oct 9 04:54:37 2015 New Revision: 249815 URL: http://llvm.org/viewvc/llvm-project?rev=249815&view=rev Log: [VFS] Port tooling to use the in-memory file system. This means file remappings can now be managed by ClangTool (or a ToolInvocation user) instead of by ToolInvocation

Re: [PATCH] D13474: [VFS] Port tooling to use the in-memory file system.

This revision was automatically updated to reflect the committed changes. Closed by commit rL249815: [VFS] Port tooling to use the in-memory file system. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D13474?vs=36632&id=36929#toc Repository: rL LLVM http://reviews.llvm.

Re: [PATCH] D12244: Implement ACLE 2.0 macros of chapters 6.4 and 6.5 for [ARM] and [Aarch64] targets

labrinea closed this revision. labrinea added a comment. committed as r246768 http://reviews.llvm.org/D12244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13440: [clang-tidy] Python script for easy check rename

ClockMan marked 3 inline comments as done. ClockMan added a comment. Repository: rL LLVM http://reviews.llvm.org/D13440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13546: [ATTR] Automatic line feed after pragma-like attribute.

aaron.ballman added a comment. Looks great, thank you! ~Aaron http://reviews.llvm.org/D13546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r249721 - When mapping no_sanitize_* attributes to no_sanitize attributes, handle GNU-style formatting that involves prefix and suffix underscores. Cleans up other usages of similar functionality.

On Thu, Oct 8, 2015 at 6:10 PM, Richard Smith wrote: > On Thu, Oct 8, 2015 at 2:59 PM, Adrian Zgorzalek wrote: >> >> Same story: >> warning: 'ownership_takes' attribute only applies to functions >> [-Wignored-attributes] >> __attribute__((ownership_takes(__))) void f(); >>

[PATCH] D13590: Support every kind of initialization.

angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: alexfh, cfe-commits. modernize-make-unique now correctly supports the different kinds of list initialization. http://reviews.llvm.org/D13590 Files: clang-tidy/modernize/MakeUniqueCheck.cpp

r249830 - [VFS] Just normalize away .. and . in paths for in-memory file systems.

Author: d0k Date: Fri Oct 9 08:03:22 2015 New Revision: 249830 URL: http://llvm.org/viewvc/llvm-project?rev=249830&view=rev Log: [VFS] Just normalize away .. and . in paths for in-memory file systems. This simplifies the code and gets us support for .. for free. Modified: cfe/trunk/include/

r249831 - [VFS] Wire up driver VFS through tooling.

Author: d0k Date: Fri Oct 9 08:03:25 2015 New Revision: 249831 URL: http://llvm.org/viewvc/llvm-project?rev=249831&view=rev Log: [VFS] Wire up driver VFS through tooling. Sadly I don't currently have a way to tests this as the driver is always initialized with the default triple and finding syst

r249829 - [VFS] Wire up multilib toolchain code to the VFS.

Author: d0k Date: Fri Oct 9 08:03:18 2015 New Revision: 249829 URL: http://llvm.org/viewvc/llvm-project?rev=249829&view=rev Log: [VFS] Wire up multilib toolchain code to the VFS. This lets a VFSified driver actually validate the GCC paths. Modified: cfe/trunk/lib/Driver/ToolChains.cpp c

r249832 - [VFS] Rename RedirectingFS internals to avoid collisions with public clang classes

Author: d0k Date: Fri Oct 9 08:28:13 2015 New Revision: 249832 URL: http://llvm.org/viewvc/llvm-project?rev=249832&view=rev Log: [VFS] Rename RedirectingFS internals to avoid collisions with public clang classes Hopefully fixes the MSVC build. NFC intended. Modified: cfe/trunk/lib/Basic/Vi

r249833 - Amending r249721 to properly handle pathological attribute-related names like __ and ____.

Author: aaronballman Date: Fri Oct 9 08:53:24 2015 New Revision: 249833 URL: http://llvm.org/viewvc/llvm-project?rev=249833&view=rev Log: Amending r249721 to properly handle pathological attribute-related names like __ and . Patch by Adrian Zgorzalek! Modified: cfe/trunk/lib/Sema/SemaD

Re: r249721 - When mapping no_sanitize_* attributes to no_sanitize attributes, handle GNU-style formatting that involves prefix and suffix underscores. Cleans up other usages of similar functionality.

On Thu, Oct 8, 2015 at 6:51 PM, Adrian Zgorzalek wrote: > Moved the test. > Feel free to commit it for me :) Thank you for the patch! I've commit it in r249833. ~Aaron > > > On Oct 8, 2015, at 3:29 PM, Richard Smith wrote: > > Please add the test to some existing test file for the ownership_ta

Re: r249721 - When mapping no_sanitize_* attributes to no_sanitize attributes, handle GNU-style formatting that involves prefix and suffix underscores. Cleans up other usages of similar functionality.

On Fri, Oct 9, 2015 at 8:53 AM, Aaron Ballman wrote: > On Thu, Oct 8, 2015 at 6:10 PM, Richard Smith wrote: >> On Thu, Oct 8, 2015 at 2:59 PM, Adrian Zgorzalek wrote: >>> >>> Same story: >>> warning: 'ownership_takes' attribute only applies to functions >>> [-Wignored-attributes] >>> __attribut

Re: [PATCH] D12726: [analyzer] A fix for symbolic element region index lifetime.

NoQ updated this revision to Diff 36946. NoQ marked 4 inline comments as done. NoQ added a comment. Thanks for the review! Fixed all comments. I don't notice any significant performance hit with this patch (+/- 2% on the whole Android codebase runs). I guess i won't break this into separate revi

Re: r249831 - [VFS] Wire up driver VFS through tooling.

On Fri, Oct 9, 2015 at 3:05 PM Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Fri Oct 9 08:03:25 2015 > New Revision: 249831 > > URL: http://llvm.org/viewvc/llvm-project?rev=249831&view=rev > Log: > [VFS] Wire up driver VFS through tooling. > > Sadly I

Re: [PATCH] D13440: [clang-tidy] Python script for easy check rename

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Do you have commit rights? If no, please have someone commit this for you. I won't be able to help with this soon, unfortunately. Repository: rL LLVM http://reviews.llvm.org/D1

Re: [PATCH] D13440: [clang-tidy] Python script for easy check rename

On Fri, Oct 9, 2015 at 11:21 AM, Alexander Kornienko wrote: > alexfh accepted this revision. > alexfh added a comment. > This revision is now accepted and ready to land. > > Looks good. Do you have commit rights? If no, please have someone commit this > for you. I won't be able to help with this

Re: [PATCH] D13582: [DEBUG INFO] Emit debug info for type used in explicit cast only.

On Fri, Oct 9, 2015 at 2:26 AM, Alexey Bataev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > ABataev created this revision. > ABataev added a reviewer: echristo. > ABataev added a subscriber: cfe-commits. > > Currently debug info for types used in explicit cast only is not emitted. > It ha

r249846 - Fix VFS GCC unittest on Windows

Author: rnk Date: Fri Oct 9 11:48:52 2015 New Revision: 249846 URL: http://llvm.org/viewvc/llvm-project?rev=249846&view=rev Log: Fix VFS GCC unittest on Windows Modified: cfe/trunk/unittests/Driver/ToolChainTest.cpp Modified: cfe/trunk/unittests/Driver/ToolChainTest.cpp URL: http://llvm.or

r249849 - Analysis: Make CFG::graph_iterator dereference to non-const

Author: dexonsmith Date: Fri Oct 9 11:50:55 2015 New Revision: 249849 URL: http://llvm.org/viewvc/llvm-project?rev=249849&view=rev Log: Analysis: Make CFG::graph_iterator dereference to non-const Since the original commit in r145858, we've had `CFG::graph_iterator` and `CFG::const_graph_iterator

Re: [PATCH] D12726: [analyzer] A fix for symbolic element region index lifetime.

zaks.anna added a comment. > I don't notice any significant performance hit with this > patch (+/- 2% on the whole Android codebase runs). What did you test it on? > we're covering all three places that were patched; maybe i could move these > tests > to symbol-reaper.c as well, but i gue

r249858 - [CMake] Fixing LTO library path passed into bootstrap builds.

Author: cbieneman Date: Fri Oct 9 12:45:44 2015 New Revision: 249858 URL: http://llvm.org/viewvc/llvm-project?rev=249858&view=rev Log: [CMake] Fixing LTO library path passed into bootstrap builds. This just fixes a small error in constructing the path to the LTO library. Modified: cfe/trunk

Re: [PATCH] D13099: [Analyzer] Don’t invalidate CXXThis when conservatively evaluating const methods (PR 21606)

zaks.anna accepted this revision. This revision is now accepted and ready to land. Comment at: lib/StaticAnalyzer/Core/CallEvent.cpp:419 @@ +418,3 @@ +const Expr *Ex = getCXXThisExpr(); +while (isa(Ex)) { + Ex = cast(Ex)->getSubExpr(); Use IgnoreParen

Re: [PATCH] D12821: Allow for C's "writing off the end" idiom in __builtin_object_size

george.burgess.iv updated this revision to Diff 36972. george.burgess.iv marked 4 inline comments as done. george.burgess.iv added a comment. Addressed all feedback. Also, updated object-size tests to use CHECK-LABEL instead of CHECK, because yay I’m learning how to do things properly. http://

Re: [PATCH] D12821: Allow for C's "writing off the end" idiom in __builtin_object_size

george.burgess.iv added inline comments. Comment at: lib/AST/ExprConstant.cpp:6331-6333 @@ +6330,5 @@ + BaseType = CAT->getElementType(); +} else if (BaseType->isAnyComplexType()) { + auto *CT = BaseType->castAs(); + BaseType = CT->getElementType(); +} else

Re: [PATCH] D13398: [clang-tidy] add check cppcoreguidelines-pro-type-const-cast

On 7 Oct 2015 19:24, "Aaron Ballman" wrote: > > On Tue, Oct 6, 2015 at 11:07 PM, Alexander Kornienko wrote: > > alexfh added a comment. > > > > It looks like potentially we're going to have tens of checks in this module. I wonder whether we should start organizing the checks somehow right away. F

r249872 - Fix whitespace, 80-column violations, embedded tabs for the

Author: echristo Date: Fri Oct 9 13:39:59 2015 New Revision: 249872 URL: http://llvm.org/viewvc/llvm-project?rev=249872&view=rev Log: Fix whitespace, 80-column violations, embedded tabs for the TargetInfo class. Modified: cfe/trunk/include/clang/Basic/TargetInfo.h cfe/trunk/lib/Basic/Tar

r249871 - constify the feature vector going into initFeatureMap as it shouldn't

Author: echristo Date: Fri Oct 9 13:39:55 2015 New Revision: 249871 URL: http://llvm.org/viewvc/llvm-project?rev=249871&view=rev Log: constify the feature vector going into initFeatureMap as it shouldn't change the set of features. Modified: cfe/trunk/include/clang/Basic/TargetInfo.h cfe

Re: [PATCH] D13444: [clang-tidy] Clocky module and multiple check from my repository

On 6 Oct 2015 22:50, "Aaron Ballman" wrote: > > On Tue, Oct 6, 2015 at 8:56 AM, Piotr Zegar wrote: > > ClockMan abandoned this revision. > > ClockMan added a comment. > > > > As a 'corporation' in which I work has doubts that checks developed by my after work, but tested on copyright protected co

Re: [PATCH] D13446: [PATCH] Add checker discouraging definition of variadic function definitions in C++

dberlin added a subscriber: dberlin. Comment at: docs/clang-tidy/checks/cert-variadic-function-def.rst:13 @@ +12,2 @@ +`DCL50-CPP. Do not define a C-style variadic function +

Re: [PATCH] D13446: [PATCH] Add checker discouraging definition of variadic function definitions in C++

On Fri, Oct 9, 2015 at 3:09 PM, Daniel Berlin wrote: > dberlin added a subscriber: dberlin. > > > Comment at: docs/clang-tidy/checks/cert-variadic-function-def.rst:13 > @@ +12,2 @@ > +`DCL50-CPP. Do not define a C-style variadic function > +

Re: [PATCH] D13444: [clang-tidy] Clocky module and multiple check from my repository

On Fri, Oct 9, 2015 at 2:45 PM, Alexander Kornienko wrote: > > On 6 Oct 2015 22:50, "Aaron Ballman" wrote: >> >> On Tue, Oct 6, 2015 at 8:56 AM, Piotr Zegar wrote: >> > ClockMan abandoned this revision. >> > ClockMan added a comment. >> > >> > As a 'corporation' in which I work has doubts that c

Re: [PATCH] D11328: [clang-tidy] new "throw-by-value-catch-by-reference" check for clang-tidy

Hi Aaron, > >> - the second thing is this MaterializeTemporary advice that you gave. I >> don’t fully understand it (possibly due to a lack of understanding the AST >> and a lack of documentation of the proposed methods). Could you please flesh >> out your idea and why you think it is necessar

Re: [PATCH] D13500: Improve helpfulness of assert message when number of diagnostics overflows number of available enum values.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. It'd be great if we could check this during compilation somehow. But anyway, LGTM. Comment at: lib/Basic/DiagnosticIDs.cpp:104 @@ -103,3 +103,3 @@ for (unsigned i = 1; i

Re: [PATCH] D11328: [clang-tidy] new "throw-by-value-catch-by-reference" check for clang-tidy

randomcppprogrammer updated this revision to Diff 36977. randomcppprogrammer marked 7 inline comments as done. randomcppprogrammer added a comment. new: - diagnosis on throwing lvalues returned by function calls such as struct S; S& function(); void foo() { throw function(); } - updated te

Re: [PATCH] D11328: [clang-tidy] new "throw-by-value-catch-by-reference" check for clang-tidy

On Fri, Oct 9, 2015 at 3:31 PM, Tobias Langner wrote: > Hi Aaron, > >> >>> - the second thing is this MaterializeTemporary advice that you gave. I >>> don’t fully understand it (possibly due to a lack of understanding the AST >>> and a lack of documentation of the proposed methods). Could you pl

[libcxx] r249889 - Split out of .

Author: rsmith Date: Fri Oct 9 14:56:37 2015 New Revision: 249889 URL: http://llvm.org/viewvc/llvm-project?rev=249889&view=rev Log: Split out of . Added: libcxx/trunk/include/wchar.h - copied, changed from r249736, libcxx/trunk/include/cwchar Modified: libcxx/trunk/include/cwchar

[libcxx] r249890 - Split out of .

Author: rsmith Date: Fri Oct 9 14:57:37 2015 New Revision: 249890 URL: http://llvm.org/viewvc/llvm-project?rev=249890&view=rev Log: Split out of . Added: libcxx/trunk/include/wctype.h - copied, changed from r249736, libcxx/trunk/include/cwctype Modified: libcxx/trunk/include/cwcty

Re: [PATCH] D12747: Implement [depr.c.headers]

As of r249890, all committed other than patches 12 (string.h) and 15 (more tests). On Thu, Oct 8, 2015 at 9:12 PM, Richard Smith wrote: > On Thu, Oct 8, 2015 at 6:58 PM, Richard Smith > wrote: > >> On Thu, Oct 8, 2015 at 6:25 PM, Eric Fiselier wrote: >> >>> Patch #12 needs revision. A bunch of

Re: [PATCH] D11328: [clang-tidy] new "throw-by-value-catch-by-reference" check for clang-tidy

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Please run your patch through clang-format before committing (just to fix the last bits of style and whitespace issues; no additional review required). Thank you for your h

Re: [PATCH] D11328: [clang-tidy] new "throw-by-value-catch-by-reference" check for clang-tidy

randomcppprogrammer updated this revision to Diff 36983. randomcppprogrammer added a comment. fixed formatting http://reviews.llvm.org/D11328 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/ThrowByValueCatchByReferenceCheck.cpp clang-tidy/misc/Th

r249893 - [Myriad]: put libstdc++ and libc in the right order

Author: dougk Date: Fri Oct 9 15:26:20 2015 New Revision: 249893 URL: http://llvm.org/viewvc/llvm-project?rev=249893&view=rev Log: [Myriad]: put libstdc++ and libc in the right order Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/myriad-toolchain.c Modified: cfe/trunk/li

r249894 - Add a fixme to handleTargetFeatures.

Author: echristo Date: Fri Oct 9 15:30:48 2015 New Revision: 249894 URL: http://llvm.org/viewvc/llvm-project?rev=249894&view=rev Log: Add a fixme to handleTargetFeatures. The goal of wanting this to avoid munging the feature list is so that it can be used for various targets as a way of both add

[PATCH] D13603: [Introduction] C++ Const object optimization.

lvoufo created this revision. lvoufo added reviewers: chandlerc, majnemer, dberlin, nlewycky. lvoufo added a subscriber: cfe-commits. Based on the design doc at https://docs.google.com/a/google.com/document/d/1vtoMypqHjkUle8KldKWYYwJF750KkYnEKffQKoYs6jo/edit?usp=sharing, it handles non-member co

r249896 - Fix inference of _Nullable for weak Objective-C properties.

Author: dgregor Date: Fri Oct 9 15:36:17 2015 New Revision: 249896 URL: http://llvm.org/viewvc/llvm-project?rev=249896&view=rev Log: Fix inference of _Nullable for weak Objective-C properties. The inference of _Nullable for weak Objective-C properties was broken in several ways: * It was back-p

[PATCH] D13604: Fix to allow C conversions on arguments passed to functions with __attribute__((overloadable)) in C

george.burgess.iv created this revision. george.burgess.iv added a reviewer: rsmith. george.burgess.iv added a subscriber: cfe-commits. The following is legal in C, and illegal in C++: ``` void *getPtr(); void foo(char *c); int main() { foo(getPtr()); } ``` Currently, we only allow C++ c

[clang-tools-extra] r249899 - Add a new checker that tests whether a throw expression throws by value, and whether a catch statement catches by reference.

Author: aaronballman Date: Fri Oct 9 15:42:44 2015 New Revision: 249899 URL: http://llvm.org/viewvc/llvm-project?rev=249899&view=rev Log: Add a new checker that tests whether a throw expression throws by value, and whether a catch statement catches by reference. Patch by Tobias Langner! Added:

Re: [PATCH] D11328: [clang-tidy] new "throw-by-value-catch-by-reference" check for clang-tidy

aaron.ballman closed this revision. aaron.ballman added a comment. I have commit in r249899. Thanks again! http://reviews.llvm.org/D11328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: r248949 - Don't inherit availability information when implementing a protocol requirement.

> On Oct 7, 2015, at 11:55 AM, Hans Wennborg wrote: > > Hi Doug, > > On Wed, Sep 30, 2015 at 2:27 PM, Douglas Gregor via cfe-commits > wrote: >> Author: dgregor >> Date: Wed Sep 30 16:27:42 2015 >> New Revision: 248949 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=248949&view=rev >> Log:

[clang-tools-extra] r249905 - Explicitly enable -fcxx-exceptions for this test to appease Windows build bots.

Author: aaronballman Date: Fri Oct 9 16:15:00 2015 New Revision: 249905 URL: http://llvm.org/viewvc/llvm-project?rev=249905&view=rev Log: Explicitly enable -fcxx-exceptions for this test to appease Windows build bots. Modified: clang-tools-extra/trunk/test/clang-tidy/misc-throw-by-value-cat

Re: [PATCH] D13603: [Introduction] C++ Const object optimization in LLVM

lvoufo updated this revision to Diff 36991. lvoufo added a comment. Clang-formatted. http://reviews.llvm.org/D13603 Files: include/clang/AST/DeclCXX.h include/clang/AST/Type.h lib/AST/DeclCXX.cpp lib/AST/Type.cpp lib/CodeGen/CGDecl.cpp lib/CodeGen/CGDeclCXX.cpp lib/CodeGen/CGExprA

Re: r248949 - Don't inherit availability information when implementing a protocol requirement.

On Fri, Oct 9, 2015 at 1:46 PM, Douglas Gregor wrote: > >> On Oct 7, 2015, at 11:55 AM, Hans Wennborg wrote: >> >> Hi Doug, >> >> On Wed, Sep 30, 2015 at 2:27 PM, Douglas Gregor via cfe-commits >> wrote: >>> Author: dgregor >>> Date: Wed Sep 30 16:27:42 2015 >>> New Revision: 248949 >>> >>> URL:

[PATCH] D13607: [Fix] Make it an error to take the address of (most) enable_if functions.

george.burgess.iv created this revision. george.burgess.iv added a reviewer: rsmith. george.burgess.iv added a subscriber: cfe-commits. For the following function: ``` int foo(int a) __attribute__((enable_if(a > 0, “”))); ``` The callee should be able to reasonably assume that `foo` will be call

Re: [PATCH] D13607: [Fix] Make it an error to take the address of (most) enable_if functions.

rsmith added inline comments. Comment at: lib/Sema/SemaExpr.cpp:10246-10253 @@ -10245,1 +10245,10 @@ + +if (RHS.get()->getType() == Context.OverloadTy) { + // As a set of extensions to C, we support overloading on functions. These + // functions need to be resolved

Re: [PATCH] D13604: Fix to allow C conversions on arguments passed to functions with __attribute__((overloadable)) in C

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Instead of `FixRHS`, I'd prefer either `ConvertRHS` or `PerformConversion` as your parameter name. Otherwise, LGTM, thanks! Comment at: lib/Sema/SemaOverload.cpp:1444-1445 @@

Re: r174630 - Enable overloading of OpenCL events - this is needed for the overloaded OpenCL builtin functions.

(Resending to correct mailing list address.) On Fri, Oct 9, 2015 at 3:23 PM, Richard Smith wrote: > On Thu, Feb 7, 2013 at 8:05 AM, Guy Benyei wrote: > >> Author: gbenyei >> Date: Thu Feb 7 10:05:33 2013 >> New Revision: 174630 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=174630&view=rev

Re: [PATCH] D12747: Implement [depr.c.headers]

Patch #12 LGTM. Thanks for doing tho cwchar approach in this patch. One small nit. I would prefer a "negative" feature macro for "_LIBCPP_STRING_H_HAS_CONST_OVERLOADS" because correct defaults shouldn't need a macro definition to be selected. (ie _LIBCPP_STRING_H_HAS_NO_CONST_OVERLOAD.) /Eric On

Re: [PATCH] D13603: [Introduction] C++ Const object optimization in LLVM

lvoufo updated this revision to Diff 37003. lvoufo added a comment. Fix unit test formatting. http://reviews.llvm.org/D13603 Files: include/clang/AST/DeclCXX.h include/clang/AST/Type.h lib/AST/DeclCXX.cpp lib/AST/Type.cpp lib/CodeGen/CGDecl.cpp lib/CodeGen/CGDeclCXX.cpp lib/CodeGe

Re: [PATCH] D13603: [Introduction] C++ Const object optimization in LLVM

lvoufo updated this revision to Diff 37004. lvoufo added a comment. Fix regression test formatting. http://reviews.llvm.org/D13603 Files: include/clang/AST/DeclCXX.h include/clang/AST/Type.h lib/AST/DeclCXX.cpp lib/AST/Type.cpp lib/CodeGen/CGDecl.cpp lib/CodeGen/CGDeclCXX.cpp lib/

Re: [PATCH] D13603: [Introduction] C++ Const object optimization in LLVM

lvoufo updated this revision to Diff 37005. lvoufo added a comment. All formatting changes should be done by now. http://reviews.llvm.org/D13603 Files: include/clang/AST/DeclCXX.h include/clang/AST/Type.h lib/AST/DeclCXX.cpp lib/AST/Type.cpp lib/CodeGen/CGDecl.cpp lib/CodeGen/CGDecl

Re: [PATCH] D12747: Implement [depr.c.headers]

Regarding Patch #15. 1. Tests under 'test/std' shouldn't directly include <__config> or depend on any libc++ implementation details. We are trying to make the test suite generic so refrain from referencing libc++ symbols. 2. "static_assert" is C++11 only but this test should work in C++03. Can you

Re: [PATCH] D12747: Implement [depr.c.headers]

@Marshall, @Richard Have we fixed the Solaris build yet? On Fri, Oct 9, 2015 at 4:48 PM, Eric Fiselier wrote: > Regarding Patch #15. > > 1. Tests under 'test/std' shouldn't directly include <__config> or > depend on any libc++ implementation details. We are trying to make the > test suite generic

Re: [PATCH] D13610: [CodeGen] Fix CodeGenModule::CreateGlobalInitOrDestructFunction

ahatanak added a comment. Add a comment to send this patch to cfe-commits. http://reviews.llvm.org/D13610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF marked an inline comment as done. EricWF added a comment. @eugenis I'll commit this tuesday morning If I don't hear anything over the weekend (Monday is a holiday for me). If you rebase the ABI patch to work with this I'll make sure to review it ASAP. Comment at: include

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

eugenis added a comment. Thanks. I'll upload the rebase patch on Monday. Comment at: include/CMakeLists.txt:38 @@ +37,3 @@ + COMMAND ${UNIX_CAT} ${LIBCXX_SOURCE_DIR}/include/__config >> ${LIBCXX_BINARY_DIR}/__generated_config + DEPENDS ${LIBCXX_SOURCE_DIR}/include/__c

[PATCH] D13614: [Extension] Optimizing passed by-value const objects.

lvoufo created this revision. lvoufo added reviewers: chandlerc, dberlin, majnemer, nicholas. lvoufo added a subscriber: cfe-commits. Continued from D13603, handling functions that are defined with const parameters. http://reviews.llvm.org/D13614 Files: include/clang/AST/DeclCXX.h include/c

Re: [PATCH] D13614: [Extension] Optimizing passed by-value const objects.

lvoufo updated this revision to Diff 37012. lvoufo added a comment. Update patch (Wrong patch submitted earlier). http://reviews.llvm.org/D13614 Files: lib/CodeGen/CGDecl.cpp test/CodeGenCXX/const-invariant.cpp test/CodeGenObjCXX/arc.mm Index: test/CodeGenObjCXX/arc.mm ==

Re: [PATCH] D12502: [libcxx] Better constain tuples constructors -- Fix PR23256 and PR22806

EricWF added a comment. Howard gave this approach and patch the thumbs up privately. @mclow.lists What's holding you back from approving this? http://reviews.llvm.org/D12502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF marked an inline comment as done. Comment at: include/CMakeLists.txt:38 @@ +37,3 @@ + COMMAND ${UNIX_CAT} ${LIBCXX_SOURCE_DIR}/include/__config >> ${LIBCXX_BINARY_DIR}/__generated_config + DEPENDS ${LIBCXX_SOURCE_DIR}/include/__config +) euge

[libcxx] r249926 - Revert r249889 due to bot failure.

Author: mren Date: Fri Oct 9 20:03:55 2015 New Revision: 249926 URL: http://llvm.org/viewvc/llvm-project?rev=249926&view=rev Log: Revert r249889 due to bot failure. Removed: libcxx/trunk/include/wchar.h Modified: libcxx/trunk/include/cwchar libcxx/trunk/test/std/depr/depr.c.headers/w

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF updated this revision to Diff 37013. EricWF added a comment. Make the generated config dependent on the "__config_site" file. It probably didn't need this but it doesn't hurt to have. http://reviews.llvm.org/D13407 Files: CMakeLists.txt cmake/Modules/HandleLibcxxFlags.cmake docs/D

Re: [PATCH] D11740: ABI versioning macros for libc++

eugenis set the repository for this revision to rL LLVM. eugenis updated this revision to Diff 37015. eugenis added a comment. Rebased on http://reviews.llvm.org/D13407 Repository: rL LLVM http://reviews.llvm.org/D11740 Files: CMakeLists.txt cmake/Modules/HandleLibcxxFlags.cmake docs/A

[libcxx] r249929 - Split out of .

Author: rsmith Date: Fri Oct 9 20:25:31 2015 New Revision: 249929 URL: http://llvm.org/viewvc/llvm-project?rev=249929&view=rev Log: Split out of . Also fix the overload set for the five functions whose signatures change in the case where we can fix it. This is already covered by existing tests

Re: [libcxx] r249926 - Revert r249889 due to bot failure.

On Fri, Oct 9, 2015 at 6:03 PM, Manman Ren via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: mren > Date: Fri Oct 9 20:03:55 2015 > New Revision: 249926 > > URL: http://llvm.org/viewvc/llvm-project?rev=249926&view=rev > Log: > Revert r249889 due to bot failure. > Can you provide a p

[libcxx] r249931 - Add a test that we declare the right set of C library function signatures in ::

Author: rsmith Date: Fri Oct 9 20:33:17 2015 New Revision: 249931 URL: http://llvm.org/viewvc/llvm-project?rev=249931&view=rev Log: Add a test that we declare the right set of C library function signatures in :: and std::, and that the names in :: and std:: are declaring the same entity. Added:

Re: [PATCH] D12747: Implement [depr.c.headers]

On Fri, Oct 9, 2015 at 3:48 PM, Eric Fiselier wrote: > Regarding Patch #15. > > 1. Tests under 'test/std' shouldn't directly include <__config> or > depend on any libc++ implementation details. We are trying to make the > test suite generic so refrain from referencing libc++ symbols. > OK, I'll

[libcxx] r249932 - Unrevert r249889, and XFAIL the test for Darwin, where the libc apparently doesn't provide a correct overload set for some functions.

Author: rsmith Date: Fri Oct 9 20:39:51 2015 New Revision: 249932 URL: http://llvm.org/viewvc/llvm-project?rev=249932&view=rev Log: Unrevert r249889, and XFAIL the test for Darwin, where the libc apparently doesn't provide a correct overload set for some functions. Added: libcxx/trunk/inclu

Re: [libcxx] r249926 - Revert r249889 due to bot failure.

On Fri, Oct 9, 2015 at 6:29 PM, Richard Smith wrote: > On Fri, Oct 9, 2015 at 6:03 PM, Manman Ren via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: mren >> Date: Fri Oct 9 20:03:55 2015 >> New Revision: 249926 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=249926&view=rev >

r249934 - [Concepts] Fixing Concepts TS directory structure; NFC

Author: nwilson Date: Fri Oct 9 21:17:39 2015 New Revision: 249934 URL: http://llvm.org/viewvc/llvm-project?rev=249934&view=rev Log: [Concepts] Fixing Concepts TS directory structure; NFC Added: cfe/trunk/test/CXX/concepts-ts/dcl.dcl/dcl.spec/dcl.spec.concept/ - copied from r249932, c

r249935 - [CMake] Always generate and install cmake config files on CMake>=3.0.

Author: chapuni Date: Fri Oct 9 21:37:30 2015 New Revision: 249935 URL: http://llvm.org/viewvc/llvm-project?rev=249935&view=rev Log: [CMake] Always generate and install cmake config files on CMake>=3.0. Currently, cmake config files are only generated and installed when CLANG_BUILD_STANDALONE s

Re: [PATCH] D13453: Always generate cmake config files

chapuni closed this revision. chapuni added a comment. Applied in r249935, thanks! http://reviews.llvm.org/D13453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D13618: [Extension] Optimizing const member objects.

lvoufo created this revision. lvoufo added reviewers: dberlin, chandlerc, majnemer, nlewycky. lvoufo added a subscriber: cfe-commits. Continued from D13603... http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.h test/CodeG

[libcxx] r249936 - Get some of wchar_h.pass.cpp working on apple.

Author: ericwf Date: Fri Oct 9 21:54:41 2015 New Revision: 249936 URL: http://llvm.org/viewvc/llvm-project?rev=249936&view=rev Log: Get some of wchar_h.pass.cpp working on apple. Modified: libcxx/trunk/test/std/depr/depr.c.headers/wchar_h.pass.cpp Modified: libcxx/trunk/test/std/depr/depr.c

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

lvoufo updated this revision to Diff 37023. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.h test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invariant.cpp ==

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

lvoufo updated this revision to Diff 37024. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.h test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invariant.cpp ==

[libcxx] r249938 - Revert r249931 - Remove same_decls.pass.cpp because it fails on OS X and in C++03 mode.

Author: ericwf Date: Fri Oct 9 22:31:23 2015 New Revision: 249938 URL: http://llvm.org/viewvc/llvm-project?rev=249938&view=rev Log: Revert r249931 - Remove same_decls.pass.cpp because it fails on OS X and in C++03 mode. Removed: libcxx/trunk/test/std/depr/depr.c.headers/same_decls.pass.cpp

[libcxx] r249939 - Turn off -pedantic by default when building due to #include_next. :-(

Author: ericwf Date: Fri Oct 9 22:34:52 2015 New Revision: 249939 URL: http://llvm.org/viewvc/llvm-project?rev=249939&view=rev Log: Turn off -pedantic by default when building due to #include_next. :-( Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt URL: http://

Re: r248949 - Don't inherit availability information when implementing a protocol requirement.

Sent from my iPhone > On Oct 9, 2015, at 2:17 PM, Hans Wennborg wrote: > >> On Fri, Oct 9, 2015 at 1:46 PM, Douglas Gregor wrote: >> >>> On Oct 7, 2015, at 11:55 AM, Hans Wennborg wrote: >>> >>> Hi Doug, >>> >>> On Wed, Sep 30, 2015 at 2:27 PM, Douglas Gregor via cfe-commits >>> wrote: >

Re: [PATCH] D13399: [CMake] Bug 14109 - CMake build for compiler-rt should use just-built clang

samsonov accepted this revision. samsonov added a comment. This revision is now accepted and ready to land. Looks pretty good. I'm still not convinced with your -Werror arguments, and will be unavailable during the next week, so feel free to land it, provided we'll return to the discussion later

[PATCH] D13620: Documentation for "Throw by value, catch by reference" check in clang-tidy

randomcppprogrammer created this revision. randomcppprogrammer added reviewers: aaron.ballman, cfe-commits. adds documentation for the check mentioned in the title http://reviews.llvm.org/D13620 Files: docs/clang-tidy/checks/misc-throw-by-value-catch-by-reference.rst Index: docs/clang-tidy/ch