samsonov accepted this revision.
samsonov added a comment.
This revision is now accepted and ready to land.
Looks pretty good. I'm still not convinced with your -Werror arguments, and
will be unavailable during the next week, so feel free to land it, provided
we'll return to the discussion later :)
Thank you!
================
Comment at: runtime/CMakeLists.txt:62
@@ -49,2 +61,3 @@
+ -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
INSTALL_COMMAND ""
STEP_TARGETS configure build
----------------
Why should it be tied to LLVM_ENABLE_WERROR? LLVM_ENABLE_WERROR only makes
sense if host compiler is known to be "good" and we want it to build LLVM w/o
errors. Here, the compiler is *always* good. As for the user, we don't give her
the option to define the compiler that would build compiler-rt: it is set to be
just-built Clang. I can imagine the test case which verifies that just-built
Clang compiles given source file w/o warnings. We can as well keep a large
subproject just-built-Clang clean.
http://reviews.llvm.org/D13399
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
