Re: [PATCH] D13604: Fix to allow C conversions on arguments passed to functions with __attribute__((overloadable)) in C

[Richard Smith via cfe-commits]

rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

Instead of `FixRHS`, I'd prefer either `ConvertRHS` or `PerformConversion` as 
your parameter name. Otherwise, LGTM, thanks!


================
Comment at: lib/Sema/SemaOverload.cpp:1444-1445
@@ -1438,3 +1443,4 @@
+  // abort early. When overloading in C, however, we do permit them.
   if (FromType->isRecordType() || ToType->isRecordType()) {
     if (S.getLangOpts().CPlusPlus)
       return false;
----------------
Fold these two 'if's together.


http://reviews.llvm.org/D13604



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits