[PATCH] D12722: cortex-r5f and cortex-m4f are unknown names for clang

labrinea created this revision. labrinea added reviewers: rengolin, richard.barton.arm. labrinea added a subscriber: cfe-commits. Tests are currently passing but warning messages are suppressed. http://reviews.llvm.org/D12722 Files: test/CodeGen/arm-target-features.c Index: test/CodeGen/arm-t

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

labrinea added a comment. Ping http://reviews.llvm.org/D12633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12722: cortex-r5f and cortex-m4f are unknown names for clang

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. As required by http://reviews.llvm.org/D12692. LGTM, thanks! http://reviews.llvm.org/D12722 ___ cfe-commits mailing list cfe-commits@lists.ll

Re: [PATCH] D12722: cortex-r5f and cortex-m4f are unknown names for clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL247138: [ARM] "cortex-r5f" and "cortex-m4f" are unknown names for clang. (authored by alelab01). Changed prior to commit: http://reviews.llvm.org/D12722?vs=34307&id=34316#toc Repository: rL LLVM htt

r247138 - [ARM] "cortex-r5f" and "cortex-m4f" are unknown names for clang.

Author: alelab01 Date: Wed Sep 9 06:29:06 2015 New Revision: 247138 URL: http://llvm.org/viewvc/llvm-project?rev=247138&view=rev Log: [ARM] "cortex-r5f" and "cortex-m4f" are unknown names for clang. The tests in test/CodeGen/arm-target-features.c are currently passing but warning messages are sup

Re: [PATCH] D12719: ScalarEvolution assume hanging bugfix

sanjoy added a comment. I don't think this is an infinite loop (Piotr, can you please verify this?), it is probably an O(n!) recursion where n == number of the assumptions. ScalarEvolution::isImpliedCond already guards for infinite loops via MarkPendingLoopPredicate. However, if you have assume

Re: [PATCH] D12719: ScalarEvolution assume hanging bugfix

> Both tests are protected by there being exactly one latch in the loop (we > exit early if there's not one latch). I'm not sure what makes the > LoopContinuePredicate check safer? You can have a loop with a single latch but an arbitrary number of assumes (= n). In such a loop, you'll still end u

Re: [PATCH] D12725: [analyzer] A fix for substraction of an integer from a pointer.

NoQ updated this revision to Diff 34320. http://reviews.llvm.org/D12725 Files: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp test/Analysis/ptr-arith.c Index: test/Analysis/ptr-arith.c === --- test/Analysis/ptr-arith.c +++ test/A

MPI-Checker patch for Clang Static Analyzer

Hi, this is a patch to add static analysis functionality for MPI code written in C, in form of a checker to Clang's Static Analyzer. In comparison to the code currently published on GitHub https://github.com/0ax1/MPI-Checker I excluded the unmatched point-to-point call check, unreachable call ch

[PATCH] D12726: [analyzer] A fix for symbolic element region index lifetime.

NoQ created this revision. NoQ added reviewers: zaks.anna, krememek. NoQ added subscribers: cfe-commits, dergachev.a. In Clang Static Analyzer, when the symbol is referenced by an index value of an element region, it does not prevent garbage collection (reaping) of that symbol. Hence, if the ele

Re: [PATCH] D9924: Ignore report when the argument to malloc is assigned known value

hiraditya updated this revision to Diff 34323. hiraditya added a comment. Rebase with latest changes. http://reviews.llvm.org/D9924 Files: lib/StaticAnalyzer/Checkers/MallocOverflowSecurityChecker.cpp test/Analysis/malloc-overflow.c test/Analysis/malloc-overflow2.c Index: test/Analysis/m

Re: Preventing several replacements on a macro call.

+cfe-commits On Tue, Sep 8, 2015 at 6:56 PM, Angel Garcia wrote: > Hi Ted, > > I was working on a clang-tidy check, and today I discovered that it was > unable to do several replacements in different arguments of the same macro > call. At first, I thought it was a bug, and trying to figure out w

r247144 - [Solaris] Use the GCC Installation detector to add the C++ include paths.

Author: rafael Date: Wed Sep 9 08:36:00 2015 New Revision: 247144 URL: http://llvm.org/viewvc/llvm-project?rev=247144&view=rev Log: [Solaris] Use the GCC Installation detector to add the C++ include paths. Patch by Xan López! Added: cfe/trunk/test/Driver/solaris-header-search.cpp Modified:

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

rengolin added inline comments. Comment at: lib/Basic/Targets.cpp:4785 @@ +4784,3 @@ +if (Opts.C99 && !Opts.Freestanding) { + Builder.defineMacro("__ARM_FP_FENV_ROUNDING", "1"); + Builder.defineMacro("__STDC_IEC_559__", "1"); I'm not convinced by the

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

labrinea added inline comments. Comment at: lib/Basic/Targets.cpp:4785 @@ +4784,3 @@ +if (Opts.C99 && !Opts.Freestanding) { + Builder.defineMacro("__ARM_FP_FENV_ROUNDING", "1"); + Builder.defineMacro("__STDC_IEC_559__", "1"); rengolin wrote: > I'm no

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

rcraik updated this revision to Diff 34339. rcraik added a comment. I've updated the message to make it a bit clearer that this is a portability concern. Are there any further concerns with this patch? http://reviews.llvm.org/D10018 Files: include/clang/Basic/DiagnosticGroups.td include/cl

[clang-tools-extra] r247153 - [clang-tidy] Automatically redirect to the new page.

Author: alexfh Date: Wed Sep 9 10:23:39 2015 New Revision: 247153 URL: http://llvm.org/viewvc/llvm-project?rev=247153&view=rev Log: [clang-tidy] Automatically redirect to the new page. Modified: clang-tools-extra/trunk/docs/clang-tidy.rst Modified: clang-tools-extra/trunk/docs/clang-tidy.rs

[PATCH] D12732: Add a deprecation notice to the clang-modernize documentation.

alexfh created this revision. alexfh added reviewers: klimek, revane. alexfh added a subscriber: cfe-commits. Add a deprecation notice to the clang-modernize documentation. Remove the reference to the external JIRA tracker. http://reviews.llvm.org/D12732 Files: docs/clang-modernize.rst Index:

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

rengolin added reviewers: rsmith, t.p.northover. rengolin added a comment. Adding Richard Smith, as he was the one choosing C99/!freestanding for runtime rounding. Comment at: lib/Basic/Targets.cpp:4790 @@ -4779,1 +4789,3 @@ +if (!Opts.C11) + Builder.defineMacro("__SUP

[PATCH] D12734: Another patch for modernize-loop-convert.

angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: cfe-commits, alexfh. 1. Avoid converting loops that iterate over the size of a container and don't use its elements, as this would result in an unused-result warning. 2. Never capture the eleme

[PATCH] D12736: [PATCH] AST traversal from types to decls

aaron.ballman created this revision. aaron.ballman added a reviewer: klimek. aaron.ballman added a subscriber: cfe-commits. Herald added a subscriber: klimek. The AST matching code that traverses from types to decls misses a lot of possible conversions. This patch adds all of the conversions I co

Re: r247049 - Module Debugging: Emit debug type information into clang modules.

> On Sep 8, 2015, at 8:05 PM, David Blaikie wrote: > > > > On Tue, Sep 8, 2015 at 12:20 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Tue Sep 8 14:20:27 2015 > New Revision: 247049 > > URL: http://llvm.org/viewvc/llvm-project?rev=247

Re: [PATCH] D12462: [PATCH] [clang-tidy] Add inconsistent declaration parameter name check

alexfh added a comment. Thank you for the fixes. I really like this way of structuring the warnings more. We might need to polish the text in the messages a bit, and maybe also change the case without definitions, but overall this seems fine. I have a few more comments. Comme

Re: [PATCH] D12624: Top-level anonymous namespaces are missing import DW_TAG_imported_module and nested anonymous namespaces are not

> On Sep 8, 2015, at 3:08 PM, Paul Robinson > wrote: > > probinson added inline comments. > > > Comment at: lib/CodeGen/CGDebugInfo.cpp:3263-3264 > @@ +3262,4 @@ > + const NamespaceDecl *NSDecl = UD.getNominatedNamespace(); > + if (!NSDecl->isAnonymousNamespace() || > +

r247160 - Fix a small bug in clang where generating some temporary files would have an extra period before the extension.

Author: akirtzidis Date: Wed Sep 9 11:48:47 2015 New Revision: 247160 URL: http://llvm.org/viewvc/llvm-project?rev=247160&view=rev Log: Fix a small bug in clang where generating some temporary files would have an extra period before the extension. Patch by Cameron Esfahani! Modified: cfe/t

Re: [PATCH] D12627: Fix a small bug in clang where generating some temporary files would have an extra period before the extension.

Committed in r247160, thanks! > On Sep 3, 2015, at 10:16 PM, Cameron Esfahani wrote: > > dirty created this revision. > dirty added a reviewer: akyrtzi. > dirty added a subscriber: cfe-commits. > > Fix a small bug in clang where generating some temporary files would > have an extra perio

[clang-tools-extra] r247163 - [clang-tidy] Fix PR22785.

Author: alexfh Date: Wed Sep 9 12:06:09 2015 New Revision: 247163 URL: http://llvm.org/viewvc/llvm-project?rev=247163&view=rev Log: [clang-tidy] Fix PR22785. Fix http://llvm.org/PR22785. Bug 22785 - readability-braces-around-statements doesn't work well with macros. http://reviews.llvm.org/D127

Re: r247049 - Module Debugging: Emit debug type information into clang modules.

On Wed, Sep 9, 2015 at 9:26 AM, Adrian Prantl wrote: > > On Sep 8, 2015, at 8:05 PM, David Blaikie wrote: > > > > On Tue, Sep 8, 2015 at 12:20 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: adrian >> Date: Tue Sep 8 14:20:27 2015 >> New Revision: 247049 >>

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

alexfh added a comment. Not sure whether the scripts should go to share/clang or some other place. Sylvestre should know what's the common practice. Also, configure builds are still used for building packages, AFAIU, so they have to be modified as well (preferably, in the same patch). http://

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

Eugene.Zelenko added a comment. On my understanding share contains architecture-independent files. clang-format files installation is also part of CMake build only. http://reviews.llvm.org/D12700 ___ cfe-commits mailing list cfe-commits@lists.llvm.

RE: [PATCH] D12624: Top-level anonymous namespaces are missing import DW_TAG_imported_module and nested anonymous namespaces are not

This seems pretty fine-grained for a CodeGenOpt (not that I've looked there, perhaps there are examples of similarly fine grained things already there?)- I'm curious to understand the preference towards that rather than perhaps the more general "Debugger tuning" sort of thing Paul's implemented/

Re: [PATCH] D11797: [LIbClang] Report the named type for ElaboratedType

skalinichev updated this revision to Diff 34350. skalinichev added a comment. Yes, I've noticed that inconsistency too. But, seems like, this is an unrelated issue: TemplateSpecializationType type for some reasons uses id instead of qid (See also all other tests with templates in print-type.cpp,

Re: [PATCH] D12247: [libc++] remove possible trailing padding from aligned_storage

yiranwang added a comment. Thank you, Eric. Also, could you please help to commit the change? I personally do not have the permissions to change libc++ code, thanks a lot. http://reviews.llvm.org/D12247 ___ cfe-commits mailing list cfe-commits@list

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

ahatanak added a comment. Hal, do you have any thoughts on the points Vasileios brought up? Currently, many of the targets don't guarantee that the realigned stack is at least as aligned as the default alignment required by the ABI. Is this the behavior end-users expect when they use -mstackrea

r247176 - [libclang] Add missing clang_CompileCommand_* functions in libclang.exports.

Author: akirtzidis Date: Wed Sep 9 13:54:16 2015 New Revision: 247176 URL: http://llvm.org/viewvc/llvm-project?rev=247176&view=rev Log: [libclang] Add missing clang_CompileCommand_* functions in libclang.exports. Modified: cfe/trunk/tools/libclang/libclang.exports Modified: cfe/trunk/tools/

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:4320-4325 @@ -4319,2 +4319,8 @@ "number of elements must be either one or match the size of the vector">; +def warn_bitfield_width_longer_than_necessary : Warning< + "size of bit-field %0 (%1

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

nmusgrave updated this revision to Diff 34357. nmusgrave added a comment. - Fixed testing callback emission order to account for vptr. Vptr poisoned after all virtual and member destructors are invoked, in order to prevent a data race an on the virtual function invoked by a class instance. (htt

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

nmusgrave marked an inline comment as done. nmusgrave added a comment. http://reviews.llvm.org/D12712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12571: [Analyzer] Fix assertions in commit r246345 (pr22954).

pgousseau added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:843 @@ +842,3 @@ + if (!Length) +return true; + dcoughlin wrote: > There doesn't seem to be a test that cares about this returning true (as > compared to false). Will

Re: [PATCH] D12462: [PATCH] [clang-tidy] Add inconsistent declaration parameter name check

piotrdz updated this revision to Diff 34358. piotrdz marked 6 inline comments as done. piotrdz added a comment. Again, addressed all review issues. I hope this is the final version http://reviews.llvm.org/D12462 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/Inconsisten

Re: [PATCH] D12462: [PATCH] [clang-tidy] Add inconsistent declaration parameter name check

piotrdz added a comment. @alexfh: here we go again. Any comments? Comment at: clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp:289 @@ +288,3 @@ + +formatDifferingParamsDiagnostic(FormatParamsDiagnosticContext{ +InconsistentDeclaration.Declaration

Re: [PATCH] D12571: [Analyzer] Fix assertions in commit r246345 (pr22954).

pgousseau updated the summary for this revision. pgousseau updated this revision to Diff 34359. pgousseau added a comment. Following Devin's review: Correct test for unknown length and unknown destination buffer. Add comment to 'IsFirstBufInBound' behavior regarding unknown states. Remove comments

PATCH: Expose the 'file' that is associated with a compile database command

Hi, The attached patch exposes the ‘file’ entry in a compilation database command, via the CompileCommand structure. compile_db_file.patch Description: Binary data ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

eugenis added inline comments. Comment at: lib/CodeGen/CGClass.cpp:1685 @@ +1684,3 @@ +// function +Poison(CGF, VTablePtr, PoisonSize); + } Did you mean to move this chunk to the other cleanup class? Is there a test that would fail if vptr is

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

hubert.reinterpretcast added inline comments. Comment at: lib/Sema/SemaDecl.cpp:12613 @@ +12612,3 @@ +FieldTy->isBooleanType() && +Value.getZExtValue() > 1) { + if (FieldName) rsmith wrote: > This will assert if the specified bitfield width do

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

hubert.reinterpretcast added inline comments. Comment at: lib/Sema/SemaDecl.cpp:12586 @@ -12585,3 +12585,3 @@ if (!FieldTy->isDependentType()) { uint64_t TypeSize = Context.getTypeSize(FieldTy); if (Value.getZExtValue() > TypeSize) { rsmith wrote: > I

r247179 - EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)

Author: mehdi_amini Date: Wed Sep 9 15:08:51 2015 New Revision: 247179 URL: http://llvm.org/viewvc/llvm-project?rev=247179&view=rev Log: EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC) From: Mehdi Amini Modified: cfe/trunk/include/clang/Serialization/ASTWriter.

Re: [PATCH] D12128: Generating available_externally vtables bugfix

Prazek accepted this revision. Prazek added a reviewer: Prazek. Prazek added a comment. This revision is now accepted and ready to land. Have to accept revision to close it http://reviews.llvm.org/D12128 ___ cfe-commits mailing list cfe-commits@list

Re: r247179 - EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)

On Wed, Sep 9, 2015 at 1:08 PM, Mehdi Amini via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: mehdi_amini > Date: Wed Sep 9 15:08:51 2015 > New Revision: 247179 > > URL: http://llvm.org/viewvc/llvm-project?rev=247179&view=rev > Log: > EmitRecordWith* API change: takes an ArrayRef ins

Re: r247179 - EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)

On Wed, Sep 9, 2015 at 1:14 PM, David Blaikie via cfe-commits wrote: > > > On Wed, Sep 9, 2015 at 1:08 PM, Mehdi Amini via cfe-commits > wrote: >> >> Author: mehdi_amini >> Date: Wed Sep 9 15:08:51 2015 >> New Revision: 247179 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=247179&view=rev >>

Re: r247179 - EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)

Hi David, Thanks for the review. > On Sep 9, 2015, at 1:14 PM, David Blaikie wrote: > > > > On Wed, Sep 9, 2015 at 1:08 PM, Mehdi Amini via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: mehdi_amini > Date: Wed Sep 9 15:08:51 2015 > New Revision: 247179 > > URL: http:/

Re: r247179 - EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)

On Wed, Sep 9, 2015 at 1:28 PM, Mehdi Amini wrote: > Hi David, > > Thanks for the review. > > > On Sep 9, 2015, at 1:14 PM, David Blaikie wrote: > > > > On Wed, Sep 9, 2015 at 1:08 PM, Mehdi Amini via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: mehdi_amini >> Date: Wed Sep 9

r247183 - Revert "EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)"

Author: mehdi_amini Date: Wed Sep 9 15:35:37 2015 New Revision: 247183 URL: http://llvm.org/viewvc/llvm-project?rev=247183&view=rev Log: Revert "EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)" This reverts commit r247179. From: Mehdi Amini Modified: cfe/trun

Re: r247179 - EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)

> On Sep 9, 2015, at 1:35 PM, David Blaikie wrote: > > > > On Wed, Sep 9, 2015 at 1:28 PM, Mehdi Amini > wrote: > Hi David, > > Thanks for the review. > > >> On Sep 9, 2015, at 1:14 PM, David Blaikie > > wrote: >> >> >> >> On Wed,

r247188 - [MS ABI] Don't crash on references to pointers to members in args

Author: majnemer Date: Wed Sep 9 15:57:59 2015 New Revision: 247188 URL: http://llvm.org/viewvc/llvm-project?rev=247188&view=rev Log: [MS ABI] Don't crash on references to pointers to members in args We know that a reference can always be dereferenced. However, we don't always know the number o

Re: [PATCH] D12453: [CUDA] Allow function overloads based on host/device attributes.

tra updated this revision to Diff 34368. tra added a comment. Implemented pcc@'s suggestion to disallow mixing HD and H/D functions. Removed name mangling as it's no longer needed. Restriction on HD overloading guarantees that we'll emit only one viable function during particular side of compila

r247194 - [Concepts] Add diagnostic; invalid specifier on function or variable concept declaration

Author: nwilson Date: Wed Sep 9 16:48:31 2015 New Revision: 247194 URL: http://llvm.org/viewvc/llvm-project?rev=247194&view=rev Log: [Concepts] Add diagnostic; invalid specifier on function or variable concept declaration Summary: Diagnose variable and function concept declarations when an inva

Re: [PATCH] D12505: [X86] Set MaxVectorAlign for non-Darwin targets as well.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. This seems reasonable to me, I can't see why it wouldn't be ok. Thanks! -eric http://reviews.llvm.org/D12505 ___ cfe-commits mailing list c

Re: r246229 - [X86] Conditionalize Darwin MaxVectorAlign on the presence of AVX.

On Mon, Aug 31, 2015 at 4:03 PM Ahmed Bougacha wrote: > On Thu, Aug 27, 2015 at 7:19 PM, Eric Christopher > wrote: > >> Hi Ahmed, >> >> A quick note: I think this is going to fail in the presence of the target >> attribute. I.e. if someone decorates a function with >> __attribute__((target("avx5

Re: [PATCH] D12505: [X86] Set MaxVectorAlign for non-Darwin targets as well.

echristo added a comment. (This ACK btw means "yes we should do this on all platforms", not that it's necessarily safe on any platform, see my mail on the original thread). -eric http://reviews.llvm.org/D12505 ___ cfe-commits mailing list cfe-comm

r247199 - Generating assumption loads of vptr after ctor call (fixed)

Author: prazek Date: Wed Sep 9 17:20:28 2015 New Revision: 247199 URL: http://llvm.org/viewvc/llvm-project?rev=247199&view=rev Log: Generating assumption loads of vptr after ctor call (fixed) Generating call assume(icmp %vtable, %global_vtable) after constructor call for devirtualization purpose

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

nmusgrave updated this revision to Diff 34373. nmusgrave added a comment. - Cleaned up impl. http://reviews.llvm.org/D12712 Files: lib/CodeGen/CGClass.cpp test/CodeGenCXX/sanitize-dtor-derived-class.cpp test/CodeGenCXX/sanitize-dtor-vtable.cpp Index: test/CodeGenCXX/sanitize-dtor-vtable.

Re: [PATCH] D12725: [analyzer] A fix for substraction of an integer from a pointer.

zaks.anna added a comment. Let's make the test more explicit about what is being tested; for example, void negativeIndex(char *str) { char *ptr = str + 1; *ptr = 'a'; clang_analyzer_eval(*ptr == 'a'); // expected-warning{{TRUE}} ptr = str - 1; clang_analyzer_eval(*ptr == 'a'); // expect

r247203 - convert builtin_unpredictable on a switch into metadata for LLVM

Author: spatel Date: Wed Sep 9 17:39:06 2015 New Revision: 247203 URL: http://llvm.org/viewvc/llvm-project?rev=247203&view=rev Log: convert builtin_unpredictable on a switch into metadata for LLVM Modified: cfe/trunk/lib/CodeGen/CGStmt.cpp cfe/trunk/test/CodeGen/builtin-unpredictable.c

[PATCH] D12739: [CUDA] Allow trivial constructors as initializer for __shared__ variables.

tra created this revision. tra added reviewers: jingyue, eliben, wengxt, jholewinski. tra added a subscriber: cfe-commits. r245786 (D12241) disabled all initializers for __shared__ variables. It also prevents placement of records in __shared__ space as they have constructor as their initializer.

r247204 - thread_local is not implemented for targeting cygwin yet.

Author: chapuni Date: Wed Sep 9 17:51:31 2015 New Revision: 247204 URL: http://llvm.org/viewvc/llvm-project?rev=247204&view=rev Log: thread_local is not implemented for targeting cygwin yet. Modified: cfe/trunk/test/CXX/concepts-ts/dcl.dcl/dcl.spec/dcl.concept/p2.cpp Modified: cfe/trunk/tes

Re: [PATCH] D12739: [CUDA] Allow trivial constructors as initializer for __shared__ variables.

jingyue accepted this revision. jingyue added a comment. This revision is now accepted and ready to land. Thanks for fixing this. http://reviews.llvm.org/D12739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

r247207 - Fix access control for lookups using the Microsoft __super extension.

Author: rjmccall Date: Wed Sep 9 18:04:17 2015 New Revision: 247207 URL: http://llvm.org/viewvc/llvm-project?rev=247207&view=rev Log: Fix access control for lookups using the Microsoft __super extension. rdar://22464808 Added: cfe/trunk/test/SemaCXX/microsoft-super.cpp Modified: cfe/tru

Re: [PATCH] D12471: Correct documentation for numSelectorArgs matcher

kastiglione added a comment. Thank you @klimek. http://reviews.llvm.org/D12471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

nmusgrave marked an inline comment as done. Comment at: lib/CodeGen/CGClass.cpp:1685 @@ -1680,3 +1684,3 @@ // Start sanitizing at this field if (startIndex < 0) startIndex = fieldIndex; compiler-rt/test/msan/dtor-multiple-inherit

Re: [PATCH] D9924: Ignore report when the argument to malloc is assigned known value

zaks.anna added a comment. > > If a' might overflow, then in this case we can emit warning stating that > > the overflow is caused because a' might overflow. > > > I see your point now! I think we should improve the diagnostic that is > produced in this case! How was the following comment

Re: [PATCH] D10414: Attach function attribute "arm-restrict-it" instead of passing arm-restrict-it as a backend-option

ahatanak updated this revision to Diff 34379. ahatanak added a comment. Based on the feedback from reviewers for the llvm patch (http://reviews.llvm.org/D10416), I made changes to fix the handling of -mrestrict-it and -mno-restrict-it in the driver. The driver now passes subtarget feature "rest

r247209 - ARC: Fix the precise-lifetime suppression of returns_inner_pointer

Author: rjmccall Date: Wed Sep 9 18:37:17 2015 New Revision: 247209 URL: http://llvm.org/viewvc/llvm-project?rev=247209&view=rev Log: ARC: Fix the precise-lifetime suppression of returns_inner_pointer receiver extension for message sends via property syntax. rdar://22172983 Modified: cfe/tr

Re: [PATCH] D12462: [PATCH] [clang-tidy] Add inconsistent declaration parameter name check

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good now. Thank you for the hard work! I'll commit the patch for you. http://reviews.llvm.org/D12462 ___ cfe-commits mailing list cfe-comm

[PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

vsk created this revision. vsk added reviewers: majnemer, rjmccall. vsk added a subscriber: cfe-commits. When personality function references were moved from LandingPadInst to Function, we forgot to update SimplifyPersonality(). This is an

Re: [PATCH] D12741: [Clang] Fix Clang-tidy misc-use-override warnings, other minor fixes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D12741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

r247218 - Fix Clang-tidy misc-use-override warnings, other minor fixes

Author: hans Date: Wed Sep 9 19:24:40 2015 New Revision: 247218 URL: http://llvm.org/viewvc/llvm-project?rev=247218&view=rev Log: Fix Clang-tidy misc-use-override warnings, other minor fixes Patch by Eugene Zelenko! Differential Revision: http://reviews.llvm.org/D12741 Modified: cfe/trunk/

Re: [PATCH] D12741: [Clang] Fix Clang-tidy misc-use-override warnings, other minor fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL247218: Fix Clang-tidy misc-use-override warnings, other minor fixes (authored by hans). Changed prior to commit: http://reviews.llvm.org/D12741?vs=34385&id=34393#toc Repository: rL LLVM http://revi

r247222 - Revert r247218: "Fix Clang-tidy misc-use-override warnings, other minor fixes"

Author: hans Date: Wed Sep 9 19:37:18 2015 New Revision: 247222 URL: http://llvm.org/viewvc/llvm-project?rev=247222&view=rev Log: Revert r247218: "Fix Clang-tidy misc-use-override warnings, other minor fixes" Seems it broke the Polly build. From http://lab.llvm.org:8011/builders/perf-x86_64-pen

Re: [PATCH] D12741: [Clang] Fix Clang-tidy misc-use-override warnings, other minor fixes

hans added a comment. It seems this broke the build for some reason. I have reverted it in r247222. Example build breakages: http://lab.llvm.org:8011/builders/perf-x86_64-penryn-O3-polly-fast/builds/11687/steps/compile/logs/stdio, http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/bui

r247228 - Don't crash when emitting a block under returns_nonnull.

Author: rjmccall Date: Wed Sep 9 19:57:46 2015 New Revision: 247228 URL: http://llvm.org/viewvc/llvm-project?rev=247228&view=rev Log: Don't crash when emitting a block under returns_nonnull. rdar://22071955 Added: cfe/trunk/test/CodeGen/sanitize-blocks.c Modified: cfe/trunk/lib/CodeGen/

Re: [PATCH] D12741: [Clang] Fix Clang-tidy misc-use-override warnings, other minor fixes

hans added a comment. In http://reviews.llvm.org/D12741#242907, @hans wrote: > It seems this broke the build for some reason. I have reverted it in r247222. > > Example build breakages: > http://lab.llvm.org:8011/builders/perf-x86_64-penryn-O3-polly-fast/builds/11687/steps/compile/logs/stdio, >

Re: [PATCH] D12741: [Clang] Fix Clang-tidy misc-use-override warnings, other minor fixes

Eugene.Zelenko added a comment. I'm sorry for making trouble. I don't have access to GCC 4.7. 4.8 build looks OK (not completed yet, but LLVM part didn't cause problems). Repository: rL LLVM http://reviews.llvm.org/D12741 ___ cfe-commits mailin

Re: [PATCH] D11857: CFI: Introduce -fsanitize=cfi-icall flag.

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM with a nit Comment at: test/CodeGen/cfi-icall.c:1 @@ +1,2 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux -fsanitize=cfi-icall -fsanitize-trap=cfi-icall -emit-llvm -o - %s

r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

Author: mehdi_amini Date: Wed Sep 9 20:46:39 2015 New Revision: 247233 URL: http://llvm.org/viewvc/llvm-project?rev=247233&view=rev Log: EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC) This reapply a variant commit r247179 after post-commit review from D.Blaikie. Hopefull

Re: r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

On Wed, Sep 9, 2015 at 6:46 PM, Mehdi Amini via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: mehdi_amini > Date: Wed Sep 9 20:46:39 2015 > New Revision: 247233 > > URL: http://llvm.org/viewvc/llvm-project?rev=247233&view=rev > Log: > EmitRecord* API change: accepts ArrayRef instead

Re: [PATCH] D11857: CFI: Introduce -fsanitize=cfi-icall flag.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247238: CFI: Introduce -fsanitize=cfi-icall flag. (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D11857?vs=33175&id=34403#toc Repository: rL LLVM http://reviews.llvm.org/D11857

r247238 - CFI: Introduce -fsanitize=cfi-icall flag.

Author: pcc Date: Wed Sep 9 21:17:40 2015 New Revision: 247238 URL: http://llvm.org/viewvc/llvm-project?rev=247238&view=rev Log: CFI: Introduce -fsanitize=cfi-icall flag. This flag causes the compiler to emit bit set entries for functions as well as runtime bitset checks at indirect call sites.

Re: [PATCH] D11857: CFI: Introduce -fsanitize=cfi-icall flag.

pcc added inline comments. Comment at: test/CodeGen/cfi-icall.c:1 @@ +1,2 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux -fsanitize=cfi-icall -fsanitize-trap=cfi-icall -emit-llvm -o - %s | FileCheck --check-prefix=ITANIUM %s +// RUN: %clang_cc1 -triple x86_64-pc-windows-msv

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

rjmccall added inline comments. Comment at: lib/CodeGen/CGException.cpp:276 @@ +275,3 @@ +llvm::Function *F = dyn_cast(U); +if (!U) return false; + if (!F) You should test this by adding an uncommon use of the personality function. Just declare it as a

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

vsk updated the summary for this revision. vsk updated this revision to Diff 34408. vsk added a comment. Thanks for the review. - Addressed if (!U) bug. - Added test which loads a personality function, confirmed that we crash without the proper `if (!F)' check. http://reviews.llvm.org/D12743

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

hfinkel added a comment. In http://reviews.llvm.org/D11815#242616, @ahatanak wrote: > Hal, do you have any thoughts on the points Vasileios brought up? Currently, > many of the targets don't guarantee that the realigned stack is at least as > aligned as the default alignment required by the ABI

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D11815#243031, @hfinkel wrote: > In http://reviews.llvm.org/D11815#242616, @ahatanak wrote: > > > Hal, do you have any thoughts on the points Vasileios brought up?

Re: [PATCH] D12462: [PATCH] [clang-tidy] Add inconsistent declaration parameter name check

piotrdz added a comment. \o/ Yay! Thanks! http://reviews.llvm.org/D12462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits