eugenis added inline comments.

================
Comment at: lib/CodeGen/CGClass.cpp:1685
@@ +1684,3 @@
+        // function
+        Poison(CGF, VTablePtr, PoisonSize);
+      }
----------------
Did you mean to move this chunk to the other cleanup class?
Is there a test that would fail if vptr is prematurely poisoned? There should 
be one (it's ok if it is only in compiler-rt, this could be hard to test with 
lit over IR).



http://reviews.llvm.org/D12712



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to