zaks.anna added a comment.

Let's make the test more explicit about what is being tested; for example,
void negativeIndex(char *str) {

  char *ptr = str + 1;
  *ptr = 'a';
  clang_analyzer_eval(*ptr == 'a'); // expected-warning{{TRUE}}
  ptr = str - 1;
  clang_analyzer_eval(*ptr == 'a'); // expected-warning{{UNKNOWN}}
  clang_analyzer_eval(*(str + 1) == 'a'); // expected-warning{{TRUE}}
  ptr = str;
  ptr -= 1;
  clang_analyzer_eval(*ptr == 'a'); // expected-warning{{UNKNOWN}}
  ptr = str;
  --ptr;
  clang_analyzer_eval(*ptr == 'a'); // expected-warning{{UNKNOWN}}

}

Otherwise, LGTM


http://reviews.llvm.org/D12725



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to