Re: [PATCH] D5102: [analyzer][Bugfix/improvement] Fix for PR16833

a.sidorin updated this revision to Diff 32664. a.sidorin marked an inline comment as done. a.sidorin added a comment. Remove duplicating assertion. http://reviews.llvm.org/D5102 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h include/clang/StaticAnalyzer/Core/Path

Re: [PATCH] D5102: [analyzer][Bugfix/improvement] Fix for PR16833

a.sidorin marked 8 inline comments as done. a.sidorin added a comment. http://reviews.llvm.org/D5102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12163: [Patch] [Analyzer] BugReporter.cpp:2869: Assertion failed: !RemainingNodes.empty() && "No error node found in the trimmed graph" (PR 24184)

MaggieYi updated this revision to Diff 32671. MaggieYi added a comment. Hi Anna, Many thanks for your comments. I have modified the patch to address your comments. Please let me know what you think. PS: If the updated patch looks good to you, could you please commit it for me (as I do not have

[clang-tools-extra] r245548 - [clang-tidy] Fold the meat of the UseNullPtrCheck into an anonymous namespace.

Author: d0k Date: Thu Aug 20 04:47:06 2015 New Revision: 245548 URL: http://llvm.org/viewvc/llvm-project?rev=245548&view=rev Log: [clang-tidy] Fold the meat of the UseNullPtrCheck into an anonymous namespace. While convenient, RecursiveASTVisitor generates a ridiculous amount of dead template cod

[PATCH] D12186: Fix bug in modernize-loop-convert check.

angelgarcia created this revision. angelgarcia added a reviewer: alexfh. angelgarcia added a subscriber: cfe-commits. angelgarcia changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Remove implicit conversion from nullptr to StringRef. http://re

Re: [PATCH] D12186: Fix bug in modernize-loop-convert check.

bkramer added a subscriber: bkramer. bkramer added a comment. Is this tested? I'd expect a crash when constructing a StringRef implicitly from nullptr. Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:341 @@ -340,3 +340,3 @@ SourceMgr.getFileID(Range.getEnd())) -

Re: [PATCH] D12186: Fix bug in modernize-loop-convert check.

angelgarcia added a comment. It is allowed as long as you specify that the length is 0. assert https://cs.corp.google.com/#piper///depot/google3/third_party/grte/v4_x86/release/usr/grte/v4/include/assert.h&l=85&ct=xref_jump_to_def&cl=GROK&gsn=assert((data https://cs.corp.google.com/#piper///depo

Re: [PATCH] D12186: Fix bug in modernize-loop-convert check.

angelgarcia added a comment. Oooops, copy pasting there was not a good idea. Sorry :( http://reviews.llvm.org/D12186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12186: Fix bug in modernize-loop-convert check.

bkramer added a comment. In http://reviews.llvm.org/D12186#228702, @angelgarcia wrote: > It is allowed as long as you specify that the length is 0. I meant the code before your change, which calls `StringRef(const char *Str)` and completely disallows nullptr. In other words: this change is mis

Re: [PATCH] D12186: Fix bug in modernize-loop-convert check.

angelgarcia added a comment. In http://reviews.llvm.org/D12186#228704, @bkramer wrote: > I meant the code before your change, which calls `StringRef(const char *Str)` > and completely disallows nullptr. In other words: this change is missing a > regression test. You are right, the current tes

r245550 - [OPENMP 4.1] Initial support for modifiers in 'linear' clause.

Author: abataev Date: Thu Aug 20 05:54:39 2015 New Revision: 245550 URL: http://llvm.org/viewvc/llvm-project?rev=245550&view=rev Log: [OPENMP 4.1] Initial support for modifiers in 'linear' clause. OpenMP 4.1 adds 3 optional modifiers to 'linear' clause. Format of 'linear' clause has changed to: `

Re: [clang-tools-extra] r245548 - [clang-tidy] Fold the meat of the UseNullPtrCheck into an anonymous namespace.

Thanks, Benjamin! On Thu, Aug 20, 2015 at 11:47 AM, Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Thu Aug 20 04:47:06 2015 > New Revision: 245548 > > URL: http://llvm.org/viewvc/llvm-project?rev=245548&view=rev > Log: > [clang-tidy] Fold the meat of th

[PATCH] D12192: Add clang support for AAP

edward-jones created this revision. edward-jones added a subscriber: cfe-commits. AAP is a Harvard architecture, with features representative of a large range of deeply embedded microprocessors. It aims to aid the development and maintenance of other out-of-tree deeply embedded systems. http://

Re: [PATCH] D11784: [PATCH] clang-tidy check for incorrect move constructor initializers

alexfh added a comment. In http://reviews.llvm.org/D11784#227939, @aaron.ballman wrote: > Addressed review comments. I re-ran the updated patch against LLVM and Clang, > and there were some more false positives that I would like to address if > possible. It seems my previous run against the sou

r245556 - [OPENMP 4.1] Allow to use 'uval' and 'ref' modifiers for reference types only.

Author: abataev Date: Thu Aug 20 07:15:57 2015 New Revision: 245556 URL: http://llvm.org/viewvc/llvm-project?rev=245556&view=rev Log: [OPENMP 4.1] Allow to use 'uval' and 'ref' modifiers for reference types only. Standard allows to use 'uval' and 'ref' modifiers in 'linear' clause for variables w

Re: [PATCH] D12186: Fix bug in modernize-loop-convert check.

angelgarcia updated this revision to Diff 32688. angelgarcia added a comment. Add a test. http://reviews.llvm.org/D12186 Files: clang-tidy/modernize/LoopConvertCheck.cpp test/clang-tidy/Inputs/modernize-loop-convert/structures.h test/clang-tidy/modernize-loop-convert-extra.cpp Index: tes

Re: [PATCH] D12186: Fix bug in modernize-loop-convert check.

bkramer accepted this revision. bkramer added a reviewer: bkramer. bkramer added a comment. This revision is now accepted and ready to land. LGTM, thanks! http://reviews.llvm.org/D12186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

r245560 - Fix crash with two typos in the arguments of a function

Author: ogoffart Date: Thu Aug 20 08:11:14 2015 New Revision: 245560 URL: http://llvm.org/viewvc/llvm-project?rev=245560&view=rev Log: Fix crash with two typos in the arguments of a function The problem is that the arguments are of TheCall are reset later to the ones in Args, making TypoExpr put

[clang-tools-extra] r245561 - [clang-tidy] Fix bug in modernize-loop-convert check.

Author: alexfh Date: Thu Aug 20 08:18:23 2015 New Revision: 245561 URL: http://llvm.org/viewvc/llvm-project?rev=245561&view=rev Log: [clang-tidy] Fix bug in modernize-loop-convert check. http://reviews.llvm.org/D12186 Patch by Angel Garcia! Modified: clang-tools-extra/trunk/clang-tidy/moder

Re: [PATCH] D12186: Fix bug in modernize-loop-convert check.

alexfh closed this revision. alexfh added a comment. Thanks! Committed revision 245561. http://reviews.llvm.org/D12186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r245562 - Silence a "not all control paths return a value" warning; NFC.

Author: aaronballman Date: Thu Aug 20 08:31:16 2015 New Revision: 245562 URL: http://llvm.org/viewvc/llvm-project?rev=245562&view=rev Log: Silence a "not all control paths return a value" warning; NFC. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: ht

Re: [PATCH] D12180: [clang-tidy] Use a python script instead of a shell script to run clang-tidy tests.

aaron.ballman added a comment. Yay! I'm really excited for this! Unfortunately, it fails all over the place on Windows. The errors are all in the form: 58> 58> FAIL: Clang Tools :: clang-tidy/readability-simplify-bool-expr-chained-conditional-return.cpp (7280 of 23187) 5

Re: [PATCH] D12180: [clang-tidy] Use a python script instead of a shell script to run clang-tidy tests.

chapuni added a comment. Alex, thanks for your working. I tweaked to run on my hosts. - mingw-w64 with Py3.3 - Linux with Py2.7 and Py3.4 My change is here; https://github.com/chapuni/llvm-project/commit/0f4a303bdc7b925f42c0cd48817052d2b49b2234 Could you merge it, please? Com

Re: [PATCH] D12152: [OPENMP] Info about OpenMP Support in Users Manual

kkwli0 added inline comments. Comment at: docs/UsersManual.rst:1860 @@ +1859,3 @@ + +Clang fully implements all of standard OpenMP 3.1 directives and clauses + some +features of OpenMP 4.0, including ``#pragma omp simd``, Clang supports all OpenMP 3.1 directives a

[clang-tools-extra] r245565 - clang-tools-extra/test/lit.cfg: Prune an obsolete feature, python27. Now we requires python>=2.7.

Author: chapuni Date: Thu Aug 20 10:04:32 2015 New Revision: 245565 URL: http://llvm.org/viewvc/llvm-project?rev=245565&view=rev Log: clang-tools-extra/test/lit.cfg: Prune an obsolete feature, python27. Now we requires python>=2.7. clang-tools-extra/test/clang-tidy/clang-tidy-diff.cpp was the on

[clang-tools-extra] r245567 - Tweak clang-tidy-diff.py to pass JSON argument correctly to clang-tidy on win32 arg parser.

Author: chapuni Date: Thu Aug 20 10:04:46 2015 New Revision: 245567 URL: http://llvm.org/viewvc/llvm-project?rev=245567&view=rev Log: Tweak clang-tidy-diff.py to pass JSON argument correctly to clang-tidy on win32 arg parser. - Single quotation is not recognized. - Use """ to pass a double q

[clang-tools-extra] r245566 - Tweak clang-tools-extra/test/clang-tidy/file-filter.cpp to pass on win32.

Author: chapuni Date: Thu Aug 20 10:04:39 2015 New Revision: 245566 URL: http://llvm.org/viewvc/llvm-project?rev=245566&view=rev Log: Tweak clang-tools-extra/test/clang-tidy/file-filter.cpp to pass on win32. FIXME: "-I %S/Inputs/file-filter/system/.." must be redundant. On Win32, file-filter/syst

Re: [PATCH] D11784: [PATCH] clang-tidy check for incorrect move constructor initializers

aaron.ballman added inline comments. Comment at: test/clang-tidy/misc-move-constructor-init.cpp:65 @@ +64,3 @@ +struct K {}; // Has implicit copy and move constructors +struct L : K { + // CHECK: :[[@LINE+1]]:16: warning: move constructor initializes base class by calling a copy

Re: [PATCH] D11784: [PATCH] clang-tidy check for incorrect move constructor initializers

aaron.ballman updated this revision to Diff 32697. aaron.ballman added a comment. In http://reviews.llvm.org/D11784#228764, @alexfh wrote: > In http://reviews.llvm.org/D11784#227939, @aaron.ballman wrote: > > > Addressed review comments. I re-ran the updated patch against LLVM and > > Clang, and

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

fraggamuffin added a comment. Comment at: lib/Parse/ParseDeclCXX.cpp:3011 @@ -3010,3 +3010,3 @@ if (Tok.is(tok::annot_pragma_openmp)) { -ParseOpenMPDeclarativeDirective(); continue; While testing this patch with the latest trunk for my w

Re: [PATCH] D11784: [PATCH] clang-tidy check for incorrect move constructor initializers

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. > With the triviality implementation, I now get zero false positives (and zero > true positives) in the Clang and LLVM source base. Awesome! Thanks for working on this! LGTM http://reviews

[clang-tools-extra] r245571 - Add a new clang-tidy check (misc-move-constructor-init) that diagnoses move constructor initializations that call copy constructors instead of move constructors.

Author: aaronballman Date: Thu Aug 20 10:52:52 2015 New Revision: 245571 URL: http://llvm.org/viewvc/llvm-project?rev=245571&view=rev Log: Add a new clang-tidy check (misc-move-constructor-init) that diagnoses move constructor initializations that call copy constructors instead of move construct

Re: [PATCH] D11784: [PATCH] clang-tidy check for incorrect move constructor initializers

aaron.ballman closed this revision. aaron.ballman added a comment. Closed with commit r245571. http://reviews.llvm.org/D11784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r245560 - Fix crash with two typos in the arguments of a function

It was requested that this be merged to 3.7. Richard: OK for merging? Thanks, Hans On Thu, Aug 20, 2015 at 6:11 AM, Olivier Goffart via cfe-commits wrote: > Author: ogoffart > Date: Thu Aug 20 08:11:14 2015 > New Revision: 245560 > > URL: http://llvm.org/viewvc/llvm-project?rev=245560&view=rev

Re: [PATCH] D12180: [clang-tidy] Use a python script instead of a shell script to run clang-tidy tests.

alexfh updated this revision to Diff 32705. alexfh marked 4 inline comments as done. alexfh added a comment. Addressed review comments. http://reviews.llvm.org/D12180 Files: test/clang-tidy/arg-comments.cpp test/clang-tidy/check_clang_tidy.py test/clang-tidy/google-explicit-constructor.cp

Re: [PATCH] D12180: [clang-tidy] Use a python script instead of a shell script to run clang-tidy tests.

alexfh added inline comments. Comment at: test/clang-tidy/arg-comments.cpp:1 @@ -1,3 +1,2 @@ -// RUN: $(dirname %s)/check_clang_tidy.sh %s misc-argument-comment %t -// REQUIRES: shell +// RUN: $(dirname %s)/check_clang_tidy.py %s misc-argument-comment %t chapuni

Re: [Diffusion] rL245435: clang-tools-extra/test/clang-tidy/readability-identifier-naming.cpp: Appease…

alexfh added a comment. Thanks for the explanation. FTR, this check on line 190 fails with -fdelayed-template-parsing: // CHECK-FIXES: {{^}}GlobalFunction(1, 2);{{$}} Users: chapuni (Author) http://reviews.llvm.org/rL245435 ___ cfe-commit

Re: [Diffusion] rL245435: clang-tools-extra/test/clang-tidy/readability-identifier-naming.cpp: Appease…

On Thu, Aug 20, 2015 at 1:01 PM, Alexander Kornienko via cfe-commits wrote: > alexfh added a comment. > > Thanks for the explanation. > > FTR, this check on line 190 fails with -fdelayed-template-parsing: > > // CHECK-FIXES: {{^}}GlobalFunction(1, 2);{{$}} FWIW, I think there's a checker bu

Re: [PATCH] D12180: [clang-tidy] Use a python script instead of a shell script to run clang-tidy tests.

chapuni accepted this revision. chapuni added a comment. This revision is now accepted and ready to land. Ready to commit regardless of one REQUIRES. Testing Time: 4.73s Expected Passes: 72 Note, llvm-include-order.cpp will XFAIL for targeting msvc. Comment at: test/

Re: [PATCH] D12180: [clang-tidy] Use a python script instead of a shell script to run clang-tidy tests.

aaron.ballman accepted this revision. aaron.ballman added a comment. The latest patch works for me when testing on Windows with MSVC. LGTM, and thank you! http://reviews.llvm.org/D12180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

Re: [PATCH] D12002: Initial WebAssembly support in clang

sunfish marked 2 inline comments as done. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:364 @@ +363,3 @@ +ItaniumCXXABI(CGM, /* UseARMMethodPtrABI = */ true, + /* UseARMGuardVarABI = */ true) {} + jfb wrote: > It's more common to have no spaces fo

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

EricWF added a comment. Gentle ping. There is going to be a couple of days lag time between committing this and it showing up at libcxx.llvm.org/docs. Once it is available at `libcxx.llvm.org/docs` we still have time to review it before we link to it from the homepage. For this reason, and beca

[PATCH] D12200: Add framework for iterative compilation to clang

zoran.jovanovic created this revision. zoran.jovanovic added reviewers: hfinkel, atrick, chandlerc. zoran.jovanovic added subscribers: cfe-commits, yaron.keren, petarj, Atlantic777, Radovan.Obradovic. This patch adds command line option for iterative compilation, as well as the code that invokes

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. Both styles look ok to me, with a slight preference toward matching clang's. Comment at: docs/BuildingLibcxx.rst:56 @@ +55,3 @@ +Mac users, remember to be careful when rep

Re: [PATCH] D12200: Add framework for iterative compilation to clang

zoran.jovanovic added a comment. This patch needs to be applied along with the patch for llvm. See http://reviews.llvm.org/D12199 for more details. As suggested new revision created for this patch, previous patch versions can be found here: http://reviews.llvm.org/D4724 http://reviews.llvm.org/

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

danalbert accepted this revision. danalbert added a comment. I think I prefer the haiku style, but I couldn't give you any concrete reasons for that. http://reviews.llvm.org/D12129 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[clang-tools-extra] r245583 - [clang-tidy] Use a python script instead of a shell script to run clang-tidy tests.

Author: alexfh Date: Thu Aug 20 12:58:07 2015 New Revision: 245583 URL: http://llvm.org/viewvc/llvm-project?rev=245583&view=rev Log: [clang-tidy] Use a python script instead of a shell script to run clang-tidy tests. Summary: Add check_clang_tidy.py script that is functionally identical to the c

Re: [PATCH] D12180: [clang-tidy] Use a python script instead of a shell script to run clang-tidy tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rL245583: [clang-tidy] Use a python script instead of a shell script to run clang-tidy… (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D12180?vs=32705&id=32712#toc Repository: r

Re: [PATCH] D12180: [clang-tidy] Use a python script instead of a shell script to run clang-tidy tests.

alexfh added inline comments. Comment at: test/clang-tidy/google-readability-casting.c:7 @@ -6,3 +6,3 @@ // RUN: clang-tidy --checks=-*,google-readability-casting -header-filter='.*' %t.main_file.cpp -- -I%S -DTEST_INCLUDE -x c++ | FileCheck %s -check-prefix=CHECK-MESSAGES -imp

[clang-tools-extra] r245586 - [clang-tidy] Use check_clang_tidy.py instead of check_clang_tidy.sh by default.

Author: alexfh Date: Thu Aug 20 13:11:13 2015 New Revision: 245586 URL: http://llvm.org/viewvc/llvm-project?rev=245586&view=rev Log: [clang-tidy] Use check_clang_tidy.py instead of check_clang_tidy.sh by default. Modified: clang-tools-extra/trunk/clang-tidy/add_new_check.py Modified: clang-t

[clang-tools-extra] r245587 - [clang-tidy] Mention check_clang_tidy.py instead of check_clang_tidy.sh in the docs.

Author: alexfh Date: Thu Aug 20 13:16:13 2015 New Revision: 245587 URL: http://llvm.org/viewvc/llvm-project?rev=245587&view=rev Log: [clang-tidy] Mention check_clang_tidy.py instead of check_clang_tidy.sh in the docs. Modified: clang-tools-extra/trunk/docs/clang-tidy.rst Modified: clang-too

[PATCH] D12201: [Sparc] Add '-EL' when invoking gcc to link little-endian binaries.

dougk created this revision. dougk added a reviewer: jyknight. dougk added a subscriber: cfe-commits. http://reviews.llvm.org/D12201 Files: lib/Driver/Tools.cpp test/Driver/biarch.c Index: test/Driver/biarch.c === --- test/Drive

Re: [PATCH] D12123: [analyzer] Skip Pre/Post handlers for ObjC calls when receiver is nil.

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Core/CheckerManager.cpp:237 @@ +236,3 @@ +return PreObjCMessageCheckers; +break; + case ObjCMessageVisitKind::Post: nit: remove the break after the return. Comment at: lib/S

r245592 - Revert r245496 "[CUDA] Add appropriate host/device attribute to builtins."

Author: tra Date: Thu Aug 20 13:28:56 2015 New Revision: 245592 URL: http://llvm.org/viewvc/llvm-project?rev=245592&view=rev Log: Revert r245496 "[CUDA] Add appropriate host/device attribute to builtins." It's breaking internal test. Removed: cfe/trunk/test/SemaCUDA/builtins.cu Modified:

Re: [PATCH] D12123: [analyzer] Skip Pre/Post handlers for ObjC calls when receiver is nil.

dcoughlin marked 2 inline comments as done. Comment at: lib/StaticAnalyzer/Core/ExprEngineObjC.cpp:197 @@ +196,3 @@ + // Generate a transition to non-Nil state, dropping any potential + // non-nil flow. + if (notNilState != State) { xazax.hun wrote:

r245595 - [Sparc] Add '-EL' when invoking gcc to link little-endian binaries.

Author: dougk Date: Thu Aug 20 13:32:26 2015 New Revision: 245595 URL: http://llvm.org/viewvc/llvm-project?rev=245595&view=rev Log: [Sparc] Add '-EL' when invoking gcc to link little-endian binaries. Differential Revision: http://reviews.llvm.org/D12201 Modified: cfe/trunk/lib/Driver/Tools.c

Re: [PATCH] D12201: [Sparc] Add '-EL' when invoking gcc to link little-endian binaries.

This revision was automatically updated to reflect the committed changes. Closed by commit rL245595: [Sparc] Add '-EL' when invoking gcc to link little-endian binaries. (authored by dougk). Changed prior to commit: http://reviews.llvm.org/D12201?vs=32715&id=32716#toc Repository: rL LLVM htt

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

EricWF updated this revision to Diff 32718. EricWF marked an inline comment as done. EricWF updated the summary for this revision. EricWF added a comment. Address review comments. http://reviews.llvm.org/D12129 Files: CMakeLists.txt cmake/Modules/HandleOutOfTreeLLVM.cmake cmake/config-ix.

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

EricWF added inline comments. Comment at: docs/BuildingLibcxx.rst:56 @@ +55,3 @@ +Mac users, remember to be careful when replacing the system's libc++. +**Your system will not be able to boot without a functioning libc++.** + jroelofs wrote: > Is there a way to ma

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

samsonov added a comment. Please upload the patch with more context (see http://llvm.org/docs/Phabricator.html). Comment at: tools/clang/include/clang/Driver/Options.td:610 @@ -608,1 +609,3 @@ + Flags<[CC1Option, CoreOption]>, +

Re: [PATCH] D11380: Implement LFTS searchers. Boyer_Moore and Boyer_Moore_Horspool

EricWF added a comment. Added more review comments for the boyer_moore searcher. Comment at: include/experimental/functional:256 @@ +255,3 @@ + +public: // TODO private: +_RandomAccessIterator1 __first_; Is this for testing? Comment

Re: r245560 - Fix crash with two typos in the arguments of a function

LGTM for branch. On Aug 20, 2015 9:47 AM, "Hans Wennborg" wrote: > It was requested that this be merged to 3.7. > > Richard: OK for merging? > > Thanks, > Hans > > On Thu, Aug 20, 2015 at 6:11 AM, Olivier Goffart via cfe-commits > wrote: > > Author: ogoffart > > Date: Thu Aug 20 08:11:14 2015 >

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

jroelofs added inline comments. Comment at: docs/BuildingLibcxx.rst:57 @@ +56,3 @@ + select a safe place to install libc++. + + * ``make install-libcxx install-libcxxabi`` --- Will install the libraries and the headers I feel like a warning is not enough... per

Re: r245595 - [Sparc] Add '-EL' when invoking gcc to link little-endian binaries.

On Thu, Aug 20, 2015 at 06:32:27PM -, Douglas Katzman via cfe-commits wrote: > Modified: cfe/trunk/test/Driver/biarch.c > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/biarch.c?rev=245595&r1=245594&r2=245595&view=diff > ===

[clang-tools-extra] r245600 - Change the test to use the new python script instead of the more verbose RUN line.

Author: aaronballman Date: Thu Aug 20 14:21:07 2015 New Revision: 245600 URL: http://llvm.org/viewvc/llvm-project?rev=245600&view=rev Log: Change the test to use the new python script instead of the more verbose RUN line. Modified: clang-tools-extra/trunk/test/clang-tidy/misc-move-constructo

[libcxx] r245601 - Remove completed items from TODO.TXT

Author: ericwf Date: Thu Aug 20 14:22:35 2015 New Revision: 245601 URL: http://llvm.org/viewvc/llvm-project?rev=245601&view=rev Log: Remove completed items from TODO.TXT Modified: libcxx/trunk/TODO.TXT Modified: libcxx/trunk/TODO.TXT URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/TOD

r245603 - [CMake] Exclude 'bootstrap' target from 'all' where possible.

Author: cbieneman Date: Thu Aug 20 15:12:18 2015 New Revision: 245603 URL: http://llvm.org/viewvc/llvm-project?rev=245603&view=rev Log: [CMake] Exclude 'bootstrap' target from 'all' where possible. EXCLUDE_FROM_ALL in ExternalProject is only available on CMake 3.1 and later. Modified: cfe/tr

r245604 - [CMake] Simplifying logic for USES_TERMINAL on bootstrap targets.

Author: cbieneman Date: Thu Aug 20 15:12:20 2015 New Revision: 245604 URL: http://llvm.org/viewvc/llvm-project?rev=245604&view=rev Log: [CMake] Simplifying logic for USES_TERMINAL on bootstrap targets. In CMake variables that haven't been set are evaluated to empty strings, so we don't need to s

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

silvas added inline comments. Comment at: docs/BuildingLibcxx.rst:57 @@ +56,3 @@ + select a safe place to install libc++. + + * ``make install-libcxx install-libcxxabi`` --- Will install the libraries and the headers jroelofs wrote: > I feel like a warning is n

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

silvas added inline comments. Comment at: docs/BuildingLibcxx.rst:57 @@ +56,3 @@ + select a safe place to install libc++. + + * ``make install-libcxx install-libcxxabi`` --- Will install the libraries and the headers silvas wrote: > jroelofs wrote: > > I feel l

[PATCH] D12209: [libcxx] Remove installation rules on Darwin when it would overwrite the system installation.

EricWF created this revision. EricWF added reviewers: mclow.lists, beanz, jroelofs. EricWF added a subscriber: cfe-commits. On Mac OS X overwriting `/usr/lib/libc++.dylib` can cause your computer to fail to boot. This patch tries to make it harder to do that accidentally. If `CMAKE_SYSTEM_NAME`

r245605 - [Headers][X86] Use __builtin_shufflevector in AVX2 broadcasts.

Author: ab Date: Thu Aug 20 15:27:21 2015 New Revision: 245605 URL: http://llvm.org/viewvc/llvm-project?rev=245605&view=rev Log: [Headers][X86] Use __builtin_shufflevector in AVX2 broadcasts. This lets us optimize them better. We agreed to remove the intrinsics, instead of combining them later, a

Re: [PATCH] D10556: [Headers][X86] Replace avx2.pbroadcast intrinsics with native IR.

This revision was automatically updated to reflect the committed changes. Closed by commit rL245605: [Headers][X86] Use __builtin_shufflevector in AVX2 broadcasts. (authored by ab). Changed prior to commit: http://reviews.llvm.org/D10556?vs=27973&id=32729#toc Repository: rL LLVM http://revi

[PATCH] D12212: [Headers][X86] Add -O0 assembly tests for intrinsics.

ab created this revision. ab added reviewers: spatel, RKSimon. ab added subscribers: cfe-commits, chandlerc, silvas, qcolombet. We agreed in D10555 that, as long as we don't affect -O0 codegen too much, it's OK to use native constructs rather than intrinsics. Let's test that, starting with AVX2

Re: [PATCH] D12209: [libcxx] Remove installation rules on Darwin when it would overwrite the system installation.

jroelofs added a comment. I like it! http://reviews.llvm.org/D12209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r245607 - Fix test on Windows to accept both gcc and gcc.exe.

Author: yrnkrn Date: Thu Aug 20 15:37:58 2015 New Revision: 245607 URL: http://llvm.org/viewvc/llvm-project?rev=245607&view=rev Log: Fix test on Windows to accept both gcc and gcc.exe. Modified: cfe/trunk/test/Driver/biarch.c Modified: cfe/trunk/test/Driver/biarch.c URL: http://llvm.org/vi

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

jmgao updated this revision to Diff 32736. jmgao added a comment. Uploading diff with arcanist. http://reviews.llvm.org/D12181 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CGExpr.cpp lib/CodeGen/CGExprScalar.cpp lib/CodeGen/CodeGenFunction

r245609 - PR24483: Delete some dead/incorrect code that triggered assertions.

Author: rsmith Date: Thu Aug 20 15:45:25 2015 New Revision: 245609 URL: http://llvm.org/viewvc/llvm-project?rev=245609&view=rev Log: PR24483: Delete some dead/incorrect code that triggered assertions. Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp cfe/trunk/test/SemaTemplate/instantiate-va

Re: [PATCH] D12212: [Headers][X86] Add -O0 assembly tests for intrinsics.

RKSimon added a comment. Definitely like this idea - hopefully it'll make it safer to remove unnecessary builtins. Comment at: avx2-builtins-codegen.c:182 @@ -151,1 +181,3 @@ + // FIXME-CHECK-ASM: vpxor %ymm{{.*}} + // FIXME-CHECK-ASM: vandps {{.*}}, %ymm{{.*}} return _mm2

Re: [PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

ismailp updated this revision to Diff 32745. ismailp added a comment. - Renamed `Out` parameter to `Stm`. - Removed assertion that checks whether an ExplodedNode has an edge to itself. - Added '-analyzer-viz-egraph-ubigraph' to an analyzer invocation in a test. http://reviews.llvm.org/D12119 Fi

Re: r245560 - Fix crash with two typos in the arguments of a function

Merged in r245615. Thanks, Hans On Thu, Aug 20, 2015 at 12:13 PM, Richard Smith wrote: > LGTM for branch. > > On Aug 20, 2015 9:47 AM, "Hans Wennborg" wrote: >> >> It was requested that this be merged to 3.7. >> >> Richard: OK for merging? >> >> Thanks, >> Hans >> >> On Thu, Aug 20, 2015 at 6:1

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

On Wed, Aug 19, 2015 at 11:42 AM, Yaron Keren wrote: > Yes, it looks like a legacy issue. Documentation says so: > > *https://gcc.gnu.org/onlinedocs/gcc-4.8.2/gcc/i386-and-x86-64-Options.html > * > > -m96bit-long-double-m1

Re: [PATCH] Fix out-of-bounds array access when setting arm float registers

+Saleem and Renato; maybe you can take a look? On Tue, Aug 18, 2015 at 11:24 AM, Leandro Graciá Gil wrote: > Hi, > > Please find attached a patch fixing an out-of-bounds array access present in > the current libunwind top of tree code. > > The problem is caused by subtracting the wrong base regis

Re: FunctionDecl::getBody() returning nullptr

On Wed, Aug 19, 2015 at 2:52 PM, Aaron Ballman wrote: > On Wed, Aug 19, 2015 at 5:23 PM, Richard Smith > wrote: > > It looks like this would only happen for a late-parsed template that the > > analysis code is checking before it is parsed. Should we really be > running > > these checks at all in

Re: [PATCH] D11194: Instantiate function declarations in instantiated functions.

rsmith accepted this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision is now accepted and ready to land. LGTM with a couple of tweaks. Thanks! Comment at: lib/AST/DeclBase.cpp:276 @@ +275,3 @@ + return false; +LDC = LDC->getParent(); + }

Re: Second Lit tests C++11 compatibility patch: using preprocessor to filter expected-error

On Tue, Aug 18, 2015 at 12:20 PM, Li, Charles via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Justin and Richard, > > >> +// RUN: %clang_cc1 -E -C -P -triple x86_64-apple-darwin10 %s > %t1.c > >> +// RUN: %clang_cc1 -fsyntax-only -verify -triple > >> +x86_64-apple-darwin10 %t1.c > > > I

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

rsmith added a comment. Can you please give a brief description of the motivation for this change? When would it be appropriate to use this rather than `-ftrap-function`? Please also include an update for the Clang documentation to describe the new flag. http://reviews.llvm.org/D12181

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

OK, based on testing, mingw i686 aligns long doubles to 4 bytes: sh-4.3$ cat < a.cpp #include int main() { struct { char c[1]; long double d; } s; std::cout<<&s.c<: > On Wed, Aug 19, 2015 at 11:42 AM, Yaron Keren > wrote: > >> Yes, it looks like a legacy issue. Documentation says

Re: FunctionDecl::getBody() returning nullptr

On Thu, Aug 20, 2015 at 5:18 PM, Richard Smith wrote: > On Wed, Aug 19, 2015 at 2:52 PM, Aaron Ballman > wrote: >> >> On Wed, Aug 19, 2015 at 5:23 PM, Richard Smith >> wrote: >> > It looks like this would only happen for a late-parsed template that the >> > analysis code is checking before it is

r245616 - Do not crash when static analysis encounters a FunctionDecl that has a delayed template parse of its body.

Author: aaronballman Date: Thu Aug 20 16:27:35 2015 New Revision: 245616 URL: http://llvm.org/viewvc/llvm-project?rev=245616&view=rev Log: Do not crash when static analysis encounters a FunctionDecl that has a delayed template parse of its body. Added: cfe/trunk/test/Analysis/delayed-templat

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

> On Aug 19, 2015, at 2:15 PM, Richard Smith wrote: > > rsmith added a subscriber: rsmith. > > > Comment at: include/clang/Frontend/CodeGenOptions.def:164-165 > @@ -163,1 +163,4 @@ > > +CODEGENOPT(DebugTypeExtRefs, 1, 0) ///< Whether or not debug info should > contain > +

r245618 - Revert the 32bit part of r245084; mingw values were correct before it.

Author: yrnkrn Date: Thu Aug 20 16:36:14 2015 New Revision: 245618 URL: http://llvm.org/viewvc/llvm-project?rev=245618&view=rev Log: Revert the 32bit part of r245084; mingw values were correct before it. Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trunk/lib/Basic/Targets.cpp URL

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

aprantl added a comment. Maybe this is missing the point, but a hash collision between module files with different formats should be highly unlikely because we add the module format into the hash. llvm::hash_code Hash = llvm::hash_combine(DirName.lower(), FileName.lower(),

[PATCH] D12215: [UBSan] Add the ability to print more precise error kind in summary line.

samsonov created this revision. samsonov added reviewers: rsmith, pcc. samsonov added a subscriber: cfe-commits. http://reviews.llvm.org/D12215 Files: lib/ubsan/ubsan_checks.inc lib/ubsan/ubsan_diag.cc lib/ubsan/ubsan_diag.h lib/ubsan/ubsan_flags.inc lib/ubsan/ubsan_handlers.cc lib/ub

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

samsonov added a comment. See https://llvm.org/bugs/show_bug.cgi?id=24443 (it's worth including this reference to change description). http://reviews.llvm.org/D12181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

aprantl added inline comments. Comment at: include/clang/Frontend/CodeGenOptions.def:164-165 @@ -163,1 +163,4 @@ +CODEGENOPT(DebugTypeExtRefs, 1, 0) ///< Whether or not debug info should contain + ///< external references to a PCH or module. +

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

On Thu, Aug 20, 2015 at 2:45 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > aprantl added inline comments. > > > Comment at: include/clang/Frontend/CodeGenOptions.def:164-165 > @@ -163,1 +163,4 @@ > > +CODEGENOPT(DebugTypeExtRefs, 1, 0) ///< Whether or no

r245619 - Revert r245344.

Author: eugenis Date: Thu Aug 20 16:47:16 2015 New Revision: 245619 URL: http://llvm.org/viewvc/llvm-project?rev=245619&view=rev Log: Revert r245344. That change is causing strange test failures on Fedora 22 (PR24503), and it does not have any effect with Gold linker anyway (PR15823, https://sour

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

aprantl added a comment. Alright, let's hash it, then. Repository: rL LLVM http://reviews.llvm.org/D11958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r245344 - [sanitizer] Add -lutil to static runtime link flags.

Reverted in r245619. On Wed, Aug 19, 2015 at 10:49 AM, H.J. Lu wrote: > On Tue, Aug 18, 2015 at 1:36 PM, Evgeniy Stepanov via cfe-commits > wrote: >> Author: eugenis >> Date: Tue Aug 18 15:36:11 2015 >> New Revision: 245344 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=245344&view=rev >> Lo

  1   2   >