On Thu, Aug 20, 2015 at 2:45 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote:
> aprantl added inline comments. > > ================ > Comment at: include/clang/Frontend/CodeGenOptions.def:164-165 > @@ -163,1 +163,4 @@ > > +CODEGENOPT(DebugTypeExtRefs, 1, 0) ///< Whether or not debug info should > contain > + ///< external references to a PCH or > module. > + > ---------------- > rsmith wrote: > > Does this flag end up in the module hash? It presumably should do so. > It does not get hashed: > > - If the module has no debug info, then this flag is meaningless, > because it only affects the debug info output. > - If the module has debug info, the module format is "obj" (hence a > different hash) and this flag must be turned on. I will make sure this is > enforced via an assertion. > > [I don't see a point in having "obj" modules without debug info, If we > want these, we'll need to add it to the hash.] > I imagine this will eventually happen when we start putting bitcode and object code in modules (for inline function definitions, for example). > > > > Repository: > rL LLVM > > http://reviews.llvm.org/D11958 > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
