Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-09-10 Thread Nico Weber via cfe-commits
The current status is that this is too slow, so for now the recommendation is to have a case insensitive mount for the files that need it. On Sep 9, 2016 8:18 PM, "John Sheu" wrote: > sheu added a subscriber: sheu. > sheu added a comment. > > I'd be very interested in seeing this patch happen.

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-09-09 Thread John Sheu via cfe-commits
sheu added a subscriber: sheu. sheu added a comment. I'd be very interested in seeing this patch happen. What's the current status here? Also, w.r.t. the cache invalidation problem -- would it be feasible / a good idea to move users of the FileSystem API to VirtualFileSystem, in general? Thi

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-12 Thread Joerg Sonnenberger via cfe-commits
On Fri, Jun 10, 2016 at 10:35:26AM -0700, Hans Wennborg wrote: > On Thu, Jun 9, 2016 at 5:31 PM, Joerg Sonnenberger via cfe-commits > wrote: > > On Wed, Jun 08, 2016 at 01:12:31AM +, Hans Wennborg via cfe-commits > > wrote: > >> There has been a patch for this before (http://reviews.llvm.org/

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-10 Thread Hans Wennborg via cfe-commits
On Thu, Jun 9, 2016 at 5:31 PM, Joerg Sonnenberger via cfe-commits wrote: > On Wed, Jun 08, 2016 at 01:12:31AM +, Hans Wennborg via cfe-commits wrote: >> There has been a patch for this before (http://reviews.llvm.org/D2972), >> but this one is more general, as it works on the virtual filesyst

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-09 Thread Joerg Sonnenberger via cfe-commits
On Wed, Jun 08, 2016 at 01:12:31AM +, Hans Wennborg via cfe-commits wrote: > There has been a patch for this before (http://reviews.llvm.org/D2972), > but this one is more general, as it works on the virtual filesystem > layer, and also supports case-insensitive lookups of parent directories >

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-09 Thread Hans Wennborg via cfe-commits
hans updated this revision to Diff 60220. hans added a comment. Adding the version that caches directory contents. This has the problem the it doesn't play with modules, the rewriter, and possibly others, because they write to the file system without any way for the vfs to find out. I've tried

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-08 Thread Hans Wennborg via cfe-commits
hans added a comment. In http://reviews.llvm.org/D21113#452673, @thakis wrote: > Not sure if we want a flag that adds 50% overhead, no matter how convenient > it might be :-/ I now have a version of the patch that caches directory contents that it lists: real2m31.461s user68m42.09

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-08 Thread Nico Weber via cfe-commits
thakis added a comment. Not sure if we want a flag that adds 50% overhead, no matter how convenient it might be :-/ http://reviews.llvm.org/D21113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-08 Thread Hans Wennborg via cfe-commits
hans added a comment. In http://reviews.llvm.org/D21113#452558, @thakis wrote: > Can you try building a few more files? Say, v8_base? Well, that was depressing: Putting the sdk on a vfat fs: real2m26.077s user68m31.476s sys 1m25.702s Using the flag: real9m5.179s

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-08 Thread Nico Weber via cfe-commits
thakis added a comment. Can you try building a few more files? Say, v8_base? http://reviews.llvm.org/D21113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-08 Thread Hans Wennborg via cfe-commits
hans added a comment. In http://reviews.llvm.org/D21113#452431, @thakis wrote: > For performance: Can you check how build times for some large target in > Chromium on Linux targeting Windows compares with this vs having the sdk in a > fat mount? That would give us some data. I measured compil

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-08 Thread Nico Weber via cfe-commits
thakis added a comment. For performance: Can you check how build times for some large target in Chromium on Linux targeting Windows compares with this vs having the sdk in a fat mount? That would give us some data. The discussion in the include case warning thread sounds like MS might update i

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-08 Thread Hans Wennborg via cfe-commits
hans updated this revision to Diff 60054. hans marked 2 inline comments as done. hans added a comment. Addressing Saleem's comments, and renaming the flag to -fcase-insensitive-paths, since this doesn't apply just to includes, but anything that goes through vfs, including the main source filenam

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-07 Thread Saleem Abdulrasool via cfe-commits
compnerd added a comment. This looks good to me. Thanks for picking this up! And thanks for the perf numbers! Comment at: lib/Basic/VirtualFileSystem.cpp:401 @@ +400,3 @@ +IntrusiveRefCntPtr Base) +: Base(Base) {} + Probably can inline this in the hea

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-07 Thread Hans Wennborg via cfe-commits
hans updated this revision to Diff 59982. hans added a comment. Add --show-includes test. http://reviews.llvm.org/D21113 Files: include/clang/Basic/VirtualFileSystem.h include/clang/Driver/Options.td include/clang/Lex/HeaderSearchOptions.h lib/Basic/VirtualFileSystem.cpp lib/Driver/To