[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG729899f7b6bf: [libunwind] unw_* alias fixes for ELF and Mach-O (authored by rprichard). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

rprichard added a comment. The coff-dwarf.test buildbot failures were fixed by https://github.com/llvm/llvm-project/commit/0fd7c31a098efdfaa5a57dbac6e9c0921b00a999 (on Feb 11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93003/new/ https://revi

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

phosek accepted this revision. phosek added a comment. LGTM I'd also suggest renaming `LIBCXXABI_HERMETIC_STATIC_LIBRARY` and `LIBCXX_HERMETIC_STATIC_LIBRARY` to `LIBCXXABI_HIDE_SYMBOLS` and `LIBCXX_HIDE_SYMBOLS` respectively in a follow up change to maintain consistency. Repository: rG LL

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

steven_wu accepted this revision. steven_wu added a comment. My main concern is just that weak alias for libc++abi that never worked for Darwin :) LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93003/new/ https://reviews.llvm.org/D93003 ___

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

danalbert added a comment. It sounds like everyone is happy here but the tools. Could we get a libunwind reviewer (preferably @compnerd, since his review is the red one) to LGTM this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93003/new/ https:

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

ldionne added a comment. In D93003#2567088 , @steven_wu wrote: > In D93003#2566906 , @rprichard wrote: > >> Maybe this is blocked on someone from Apple reviewing the Mach-O parts? > > This is fine with me for how Ap

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

steven_wu added a comment. In D93003#2566906 , @rprichard wrote: > Maybe this is blocked on someone from Apple reviewing the Mach-O parts? This is fine with me for how Apple builds libunwind. I am not sure if the open source libunwind build for MachO do

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

rprichard added a comment. Maybe this is blocked on someone from Apple reviewing the Mach-O parts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93003/new/ https://reviews.llvm.org/D93003 ___ cfe-commits

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

rprichard updated this revision to Diff 323222. rprichard added a comment. Rebase and fix merge conflict in gn file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93003/new/ https://reviews.llvm.org/D93003 Files: clang/cmake/caches/Fuchsia-stage

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

rprichard updated this revision to Diff 323221. rprichard edited the summary of this revision. rprichard added a comment. Update libunwind/src/BUILD.gn for macro name change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93003/new/ https://reviews.