ldionne added a comment. In D93003#2567088 <https://reviews.llvm.org/D93003#2567088>, @steven_wu wrote:
> In D93003#2566906 <https://reviews.llvm.org/D93003#2566906>, @rprichard wrote: > >> Maybe this is blocked on someone from Apple reviewing the Mach-O parts? > > This is fine with me for how Apple builds libunwind. I am not sure if the > open source libunwind build for MachO do expect different behavior but I > don't think there are other reasonable behaviors. > > I can give my LGTM if @ldionne has no problem with that. Oh, I had missed that. I'm not a libunwind owner, but if Steven says it's good for Apple, then it is. I trust him a lot more than I trust myself in this area. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93003/new/ https://reviews.llvm.org/D93003 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
