phosek accepted this revision. phosek added a comment. LGTM
I'd also suggest renaming `LIBCXXABI_HERMETIC_STATIC_LIBRARY` and `LIBCXX_HERMETIC_STATIC_LIBRARY` to `LIBCXXABI_HIDE_SYMBOLS` and `LIBCXX_HIDE_SYMBOLS` respectively in a follow up change to maintain consistency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93003/new/ https://reviews.llvm.org/D93003 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
