This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0e23fd676c39: [Driver] Add DWARF64 flag: -gdwarf64 (authored
by hoy).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://rev
ayermolo updated this revision to Diff 315495.
ayermolo added a comment.
rebased on latest.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90507/new/
https://reviews.llvm.org/D90507
Files:
clang/include/clang/Basic/CodeGenOptions.def
clang/incl
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90507/new/
https://reviews.llvm.org/D90507
__
ayermolo added a comment.
@dblaikie @MaskRay Anything else do I need to change, all good?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90507/new/
https://reviews.llvm.org/D90507
___
cfe-commits mailing
ayermolo updated this revision to Diff 314413.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90507/new/
https://reviews.llvm.org/D90507
Files:
clang/include/clang/Basic/CodeGenOptions.def
clang/include/clang/Driver/Options.td
clang/lib/CodeGen
ayermolo updated this revision to Diff 313621.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90507/new/
https://reviews.llvm.org/D90507
Files:
clang/include/clang/Basic/CodeGenOptions.def
clang/include/clang/Driver/Options.td
clang/lib/CodeGen
ayermolo added inline comments.
Comment at: clang/test/Driver/debug-options.c:379
+// VALIDT: x86_64
+// RUN: %clang -### -c -gdwarf-5 -gdwarf64 -target VALIDT %s 2>&1 | FileCheck
-check-prefix=GDWARF64_ON %s
+// RUN: %clang -### -c -gdwarf-4 -gdwarf64 -target VALIDT %s 2>&1 | F
MaskRay added inline comments.
Comment at: clang/test/Driver/debug-options.c:379
+// VALIDT: x86_64
+// RUN: %clang -### -c -gdwarf-5 -gdwarf64 -target VALIDT %s 2>&1 | FileCheck
-check-prefix=GDWARF64_ON %s
+// RUN: %clang -### -c -gdwarf-4 -gdwarf64 -target VALIDT %s 2>&1 | Fi
ayermolo updated this revision to Diff 313421.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90507/new/
https://reviews.llvm.org/D90507
Files:
clang/include/clang/Basic/CodeGenOptions.def
clang/include/clang/Driver/Options.td
clang/lib/CodeGen
ayermolo updated this revision to Diff 313412.
ayermolo marked an inline comment as done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90507/new/
https://reviews.llvm.org/D90507
Files:
clang/include/clang/Basic/CodeGenOptions.def
clang/include/
ayermolo updated this revision to Diff 313410.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90507/new/
https://reviews.llvm.org/D90507
Files:
clang/include/clang/Basic/CodeGenOptions.def
clang/include/clang/Driver/Options.td
clang/lib/CodeGen
ikudrin added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4016
+ auto *dwarfArgs =
+ Args.getLastArg(options::OPT_gdwarf64, options::OPT_gdwarf32);
Maybe make this more descriptive?
Comment at: clang/test/Driver/d
ayermolo updated this revision to Diff 312882.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90507/new/
https://reviews.llvm.org/D90507
Files:
clang/include/clang/Basic/CodeGenOptions.def
clang/include/clang/Driver/Options.td
clang/lib/CodeGen
ayermolo updated this revision to Diff 312327.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90507/new/
https://reviews.llvm.org/D90507
Files:
clang/include/clang/Basic/CodeGenOptions.def
clang/include/clang/Driver/Options.td
clang/lib/CodeGen
ayermolo updated this revision to Diff 311764.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90507/new/
https://reviews.llvm.org/D90507
Files:
clang/include/clang/Basic/CodeGenOptions.def
clang/include/clang/Driver/Options.td
clang/lib/CodeGen
MaskRay added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4033
+dwarfArgs->render(Args, CmdArgs);
+ }
+
Delete unneeded braces
http://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loo
ayermolo updated this revision to Diff 311751.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90507/new/
https://reviews.llvm.org/D90507
Files:
clang/include/clang/Basic/CodeGenOptions.def
clang/include/clang/Driver/Options.td
clang/lib/CodeGen
ayermolo updated this revision to Diff 311747.
ayermolo marked 2 inline comments as done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90507/new/
https://reviews.llvm.org/D90507
Files:
clang/include/clang/Basic/CodeGenOptions.def
clang/include/
MaskRay added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4029
+ D.Diag(diag::err_drv_argument_only_allowed_with)
+ << A->getAsString(Args) << "elf output format";
+else
"elf output format" -> "ELF platforms"
ELF is usual
MaskRay added inline comments.
Comment at: clang/test/Driver/debug-options.c:390
+// GDWARF64_OFF: error: invalid argument '-gdwarf64' only allowed with
'DWARFv3 or greater'
+// GDWARF64_32ARCH: error: invalid argument '-gdwarf64' only allowed with '64
bit architecture'
--
MaskRay added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4031
+else
+ CmdArgs.push_back("-gdwarf64");
+ }
Use `render` (see other `render` in the file)
Comment at: clang/test/Driver/debug-options.c:379
+//
+//
-commits@lists.llvm.org
; mask...@google.com ;
ikud...@accesssoftek.com ; bhuvanendra.kum...@amd.com
; mlek...@skidmore.edu ;
blitzrak...@gmail.com ; shen...@google.com
; orlando.hy...@sony.com
Subject: [PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64
dblaikie added inline comments
dblaikie added inline comments.
Herald added a subscriber: hoy.
Comment at: clang/include/clang/Basic/CodeGenOptions.def:35
CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm.
+CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64.
CODEGENOPT(PreserveAsmComments, 1, 1)
ayermolo added inline comments.
Comment at: clang/include/clang/Basic/CodeGenOptions.def:35
CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm.
+CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64.
CODEGENOPT(PreserveAsmComments, 1, 1) ///< -dA, -fno-preserve-as-comme
dblaikie added inline comments.
Comment at: clang/include/clang/Basic/CodeGenOptions.def:35
CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm.
+CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64.
CODEGENOPT(PreserveAsmComments, 1, 1) ///< -dA, -fno-preserve-as-comme
ayermolo added inline comments.
Comment at: clang/include/clang/Basic/CodeGenOptions.def:35
CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm.
+CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64.
CODEGENOPT(PreserveAsmComments, 1, 1) ///< -dA, -fno-preserve-as-comme
dblaikie added inline comments.
Comment at: clang/include/clang/Basic/CodeGenOptions.def:35
CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm.
+CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64.
CODEGENOPT(PreserveAsmComments, 1, 1) ///< -dA, -fno-preserve-as-comme
ayermolo added inline comments.
Comment at: clang/include/clang/Basic/CodeGenOptions.def:35
CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm.
+CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64.
CODEGENOPT(PreserveAsmComments, 1, 1) ///< -dA, -fno-preserve-as-comme
28 matches
Mail list logo
