MaskRay added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4033 + dwarfArgs->render(Args, CmdArgs); + } + ---------------- Delete unneeded braces http://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements ================ Comment at: clang/test/Driver/debug-options.c:378 +// +// RUN: %clang -### -gdwarf-5 -gdwarf64 -target x86_64-linux-gnu %s 2>&1 | FileCheck -check-prefix=GDWARF64_ON %s +// RUN: %clang -### -gdwarf-4 -gdwarf64 -target x86_64-linux-gnu %s 2>&1 | FileCheck -check-prefix=GDWARF64_ON %s ---------------- I'd prefer `x86_64` (generic ELF) to indicate that this is a generic ELF feature, not specific to Linux (i.e. FreeBSD works) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
