ayermolo added inline comments.
================ Comment at: clang/test/Driver/debug-options.c:379 +// VALIDT: x86_64 +// RUN: %clang -### -c -gdwarf-5 -gdwarf64 -target VALIDT %s 2>&1 | FileCheck -check-prefix=GDWARF64_ON %s +// RUN: %clang -### -c -gdwarf-4 -gdwarf64 -target VALIDT %s 2>&1 | FileCheck -check-prefix=GDWARF64_ON %s ---------------- MaskRay wrote: > > // VALIDT: x86_64 > > lit does not replace `VALIDT` with `x86_64`. Do you just want to test > `-target x86_64`? A, you are right. Should have checked lit with -a. I was trying to address: "x86_64-linux-gnu -> x86_64 to make it clear this is a generic ELF behavior (e.g. FreeBSD works)." "Don't repeat -target x86_64-linux-gnu" I guess this only works for --check-prefix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
