[PATCH] D85685: Support dwarf fission for wasm object files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ff28fa6a756: Support dwarf fission for wasm object files (authored by dschuff). Changed prior to commit: https://reviews.llvm.org/D85685?vs=29262

[PATCH] D85685: Support dwarf fission for wasm object files

dschuff updated this revision to Diff 292624. dschuff added a comment. rebase, address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85685/new/ https://reviews.llvm.org/D85685 Files: llvm/lib/MC/WasmObjectWriter.cpp Index: llvm/lib/MC/

[PATCH] D85685: Support dwarf fission for wasm object files

aardappel added inline comments. Comment at: llvm/lib/MC/WasmObjectWriter.cpp:1313 + } + return writeOneObject(Asm, Layout, DwoMode::AllSections); +} Nit picking on this because I can't find anything else to complain about: This line would be more readable insi

[PATCH] D85685: Support dwarf fission for wasm object files

sbc100 accepted this revision. sbc100 added a comment. I don't really grok the `TargetFrameLowering::DwarfFrameBase` part but everything else LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85685/new/ https://reviews.llvm.org/D85685 __

[PATCH] D85685: Support dwarf fission for wasm object files

dschuff added a comment. In D85685#2277998 , @dschuff wrote: > > Yeah, ELF splits ELFWriter out from ELFObjectWriter, and then instantiates it > twice. It's all because ELFObjectWriter has to derive from MCObjectWriter > which was clearly not designe

[PATCH] D85685: Support dwarf fission for wasm object files

dschuff added a comment. In D85685#2275585 , @sbc100 wrote: > Seems reasonable. Do you think this way is cleaner than the way elf does > it? Looks like ELF creates two different ELFWriter inside the > ELFDwoObjectWriter subclass right? Yeah, ELF spl

[PATCH] D85685: Support dwarf fission for wasm object files

sbc100 added a comment. Seems reasonable. Do you think this way is cleaner than the way elf does it? Looks like ELF creates two different ELFWriter inside the ELFDwoObjectWriter subclass right? Are we going need to wasm-ld tests to followup or is this really independent of the linker? =

[PATCH] D85685: Support dwarf fission for wasm object files

dschuff added a comment. OK, I think this is ready to review for real. Can you take another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85685/new/ https://reviews.llvm.org/D85685 ___ cfe-commits