sbc100 added a comment. Seems reasonable. Do you think this way is cleaner than the way elf does it? Looks like ELF creates two different ELFWriter inside the ELFDwoObjectWriter subclass right?
Are we going need to wasm-ld tests to followup or is this really independent of the linker? ================ Comment at: llvm/lib/MC/WasmObjectWriter.cpp:224 class WasmObjectWriter : public MCObjectWriter { - support::endian::Writer W; + support::endian::Writer *W; ---------------- Kind of a same this change means changing so many line in this file .. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85685/new/ https://reviews.llvm.org/D85685 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits