[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

hctim abandoned this revision. hctim added a comment. Abandoning - fixing the underlying issue at D82615 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82249/new/ https://reviews.llvm.org/D82249 ___

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

eugenis added a comment. In D82249#2110054 , @hctim wrote: > In D82249#2109920 , @eugenis wrote: > > > I'm OK with this as a workaround, but it would be more natural to detect > > the unsupported IR pattern in glob

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

hctim added a comment. In D82249#2110010 , @arsenm wrote: > I don't follow. It no longer falls back, so what is the problem? HWASan-globals end up with an address that's outside of the code model (due to the tag), so the normal instruction sequence of `

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

hctim added a comment. In D82249#2109920 , @eugenis wrote: > I'm OK with this as a workaround, but it would be more natural to detect the > unsupported IR pattern in globalisel and fall back instead of disabling it > entirely. Is it difficult to do for s

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

arsenm added a comment. In D82249#2107845 , @hctim wrote: > In D82249#2105036 , @arsenm wrote: > > > Is the fallback not working correctly in this case for some reason? > > > I'm fairly sure that G_GLOBAL_VALUE used

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

eugenis added a comment. LGTM I'm OK with this as a workaround, but it would be more natural to detect the unsupported IR pattern in globalisel and fall back instead of disabling it entirely. Is it difficult to do for some reason? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

hctim added a comment. In D82249#2105036 , @arsenm wrote: > Is the fallback not working correctly in this case for some reason? I'm fairly sure that G_GLOBAL_VALUE used to fallback onto SelectionDAGISel, and that was changed in D78465

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

arsenm added a comment. Is the fallback not working correctly in this case for some reason? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82249/new/ https://reviews.llvm.org/D82249 ___ cfe-commits mail

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

hctim created this revision. hctim added reviewers: pcc, ostannard. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, kristof.beyls, rovka. Herald added projects: clang, Sanitizers, LLVM. HWASan globals instruction selection lowering hasn't been implemented in GlobalISel or FastISe