kadircet added inline comments.
Comment at: clang-tools-extra/clangd/unittests/LSPClient.cpp:65
+
+ void reply(llvm::json::Value ID,
+ llvm::Expected V) override {
sammccall wrote:
> kadircet wrote:
> > put methods before fields
> Done - I don't care
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1229245df7c7: [clangd] Set up machinery for gtests of
ClangdLSPServer. (authored by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77766/new/
htt
sammccall updated this revision to Diff 256449.
sammccall marked 12 inline comments as done.
sammccall added a comment.
Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77766/new/
https://reviews.llvm.org/D77766
Files:
clang
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/unittests/LSPClient.cpp:65
+
+ void reply(llvm::json::Value ID,
+ llvm::Expected V) override {
kadircet wrote:
> put methods before fields
Done - I don't care much, but curious whe
kadircet added a comment.
LGTM, mostly nits.
Unfortunately I don't see any way to make it simpler :/
Comment at: clang-tools-extra/clangd/unittests/ClangdLSPServerTests.cpp:104
+
+MATCHER_P(DiagMessage, M, "") {
+ if (const auto *O = arg.getAsObject()) {
nit:
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov, mgorny.
Herald added a project: clang.
sammccall added a comment.
It seems fairly likely that this is a big complicated thing we end
sammccall added a comment.
It seems fairly likely that this is a big complicated thing we end up using for
1 or 2 tests that are too hard to test with lit but can't be tested at a lower
level than ClangdLSPServer.
Suggestions on how to make it more lightweight would be welcome!
Repository:
r
