kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/LSPClient.cpp:65
+
+ void reply(llvm::json::Value ID,
+ llvm::Expected<llvm::json::Value> V) override {
----------------
sammccall wrote:
> kadircet wrote:
> > put methods before fields
> Done - I don't care much, but curious where this guideline comes from?
> My impression is LLVM puts members at the very top of the class or at the
> very bottom (like google-style).
> DependentSizedArrayType is a random example.
i believe most of the code in LLVM puts the members at the top of the class.
but my impression was in clangd code we tend to put members at the very bottom,
hence i suggested that. personally i actually find having members at the top
more useful.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77766/new/
https://reviews.llvm.org/D77766
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
