sammccall added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/LSPClient.cpp:65
+
+ void reply(llvm::json::Value ID,
+ llvm::Expected<llvm::json::Value> V) override {
----------------
kadircet wrote:
> put methods before fields
Done - I don't care much, but curious where this guideline comes from?
My impression is LLVM puts members at the very top of the class or at the very
bottom (like google-style).
DependentSizedArrayType is a random example.
================
Comment at: clang-tools-extra/clangd/unittests/LSPClient.cpp:68
+ if (V)
+ logBody("reply", *V, /*Send=*/false);
+ std::lock_guard<std::mutex> Lock(Mu);
----------------
kadircet wrote:
> i think logging errors here could help with debugging.
Errors don't have bodies, the mesasge is already logged by clangdlspserver.
Added a comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77766/new/
https://reviews.llvm.org/D77766
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
