[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.h:194 +llvm::SmallVector +explicitReferenceTargets(ast_type_traits::DynTypedNode N, + DeclRelationSet Mask = {}); sammccall wrote: > ilya-biryukov wrote:

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.h:194 +llvm::SmallVector +explicitReferenceTargets(ast_type_traits::DynTypedNode N, + DeclRelationSet Mask = {}); ilya-biryukov wrote: > sammccall wrote:

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.h:194 +llvm::SmallVector +explicitReferenceTargets(ast_type_traits::DynTypedNode N, + DeclRelationSet Mask = {}); ilya-biryukov wrote: > sammccall wrote: > >

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.h:194 +llvm::SmallVector +explicitReferenceTargets(ast_type_traits::DynTypedNode N, + DeclRelationSet Mask = {}); sammccall wrote: > ilya-biryukov wrote:

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.h:194 +llvm::SmallVector +explicitReferenceTargets(ast_type_traits::DynTypedNode N, + DeclRelationSet Mask = {}); ilya-biryukov wrote: > sammccall wrote: > >

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.h:194 +llvm::SmallVector +explicitReferenceTargets(ast_type_traits::DynTypedNode N, + DeclRelationSet Mask = {}); sammccall wrote: > ilya-biryukov wrote:

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.h:194 +llvm::SmallVector +explicitReferenceTargets(ast_type_traits::DynTypedNode N, + DeclRelationSet Mask = {}); ilya-biryukov wrote: > sammccall wrote: > >

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.h:194 +llvm::SmallVector +explicitReferenceTargets(ast_type_traits::DynTypedNode N, + DeclRelationSet Mask = {}); sammccall wrote: > ilya-biryukov wrote:

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.h:194 +llvm::SmallVector +explicitReferenceTargets(ast_type_traits::DynTypedNode N, + DeclRelationSet Mask = {}); ilya-biryukov wrote: > sammccall wrote: > >

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.h:194 +llvm::SmallVector +explicitReferenceTargets(ast_type_traits::DynTypedNode N, + DeclRelationSet Mask = {}); sammccall wrote: > ilya-biryukov wrote:

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.h:194 +llvm::SmallVector +explicitReferenceTargets(ast_type_traits::DynTypedNode N, + DeclRelationSet Mask = {}); ilya-biryukov wrote: > No need to fix this.

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

This revision was automatically updated to reflect the committed changes. Closed by commit rGac3f9e484217: [clangd] Improve documentation for auto and implicit specs (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71596/new/ ht

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov accepted this revision. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:136 HI.Kind = index::SymbolKind::Cl

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60982 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet updated this revision to Diff 234541. kadircet marked 2 inline comments as done. kadircet added a comment. - Document limitation on Mask parameter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71596/new/ https://reviews.llvm.org/D71596 Fi

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:136 HI.Kind = index::SymbolKind::Class; - HI.Definition = "template class vector {}"; - HI.TemplateParameters = { -

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.h:194 +llvm::SmallVector +explicitReferenceTargets(ast_type_traits::DynTypedNode N, + DeclRelationSet Mask = {}); No need to fix this. The name could pro

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60982 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet updated this revision to Diff 234522. kadircet marked 4 inline comments as done. kadircet added a comment. - Expose explicitReferenceTargets Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71596/new/ https://reviews.llvm.org/D71596 Files:

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:188 +// Returns the decl that should be used for querying comments, either from index +// or ast. +const NamedDecl *getDeclForComment(const NamedDecl *D) { NIT: AST ===

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60981 tests passed, 2 failed and 727 were skipped. failed: Clangd Unit Tests._/ClangdTests/Hover.DocsFromMostSpecial failed: lit.lit/shtest-format.py {icon check-circle color=green} clang-tidy: pass. {icon ch

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet updated this revision to Diff 234514. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments - Extend handling to: - var and function templates - non-auto case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:191 + // attached to that. + if (auto *CTSD = llvm::dyn_cast(D)) { +if (!CTSD->isExplicitInstantiationOrSpecialization()) You might need to do the same for specializations o

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60982 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:188 +// returns D. +const NamedDecl *getExplicitSpec(const NamedDecl *D) { + if (auto *CTSD = llvm::dyn_cast(D)) { kadircet wrote:

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet updated this revision to Diff 234487. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71596/new/ https://reviews.llvm.org/D71596 Files: clang-tools-ex

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:188 +// returns D. +const NamedDecl *getExplicitSpec(const NamedDecl *D) { + if (auto *CTSD = llvm::dyn_cast(D)) { ilya-biryukov wrote: > kadircet wrote: > > ilya-biryukov wrote: > >

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:188 +// returns D. +const NamedDecl *getExplicitSpec(const NamedDecl *D) { + if (auto *CTSD = llvm::dyn_cast(D)) { kadircet wrote: > ilya-biryukov wrote: > > What's the purpose o

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:188 +// returns D. +const NamedDecl *getExplicitSpec(const NamedDecl *D) { + if (auto *CTSD = llvm::dyn_cast(D)) { ilya-biryukov wrote: > Wh

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:188 +// returns D. +const NamedDecl *getExplicitSpec(const NamedDecl *D) { + if (auto *CTSD = llvm::dyn_cast(D)) { What's the purpose of this function? I don't think its descript

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60981 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifac

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet updated this revision to Diff 234293. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71596/new/ https://reviews.llvm.org/D71596 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/unitt

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60980 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifac

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet updated this revision to Diff 234288. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71596/new/ https://reviews.llvm.org/D71596 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/unitt

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Clangd didn't fill documentation for `auto` when it wasn't available in index. Also it wasn't showing any documenta