ilya-biryukov added inline comments.
================
Comment at: clang-tools-extra/clangd/FindTarget.h:194
+llvm::SmallVector<const NamedDecl *, 1>
+explicitReferenceTargets(ast_type_traits::DynTypedNode N,
+ DeclRelationSet Mask = {});
----------------
No need to fix this.
The name could probably be better, but we can fix this later. Don't have any
good ideas.
================
Comment at: clang-tools-extra/clangd/FindTarget.h:195
+explicitReferenceTargets(ast_type_traits::DynTypedNode N,
+ DeclRelationSet Mask = {});
} // namespace clangd
----------------
Could you document `Mask` can't have `TemplatePattern` and
`TemplateInstantiation` bits?
================
Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:136
HI.Kind = index::SymbolKind::Class;
- HI.Definition = "template <typename T> class vector {}";
- HI.TemplateParameters = {
- {std::string("typename"), std::string("T"), llvm::None},
- };
+ HI.Definition = "template <> class vector<int> {}";
}},
----------------
Is this the intended behavior?
I would've interepreted `Definition` as something that was written in the
source code, but this one here is definitely synthesized by the compiler.
I'm happy to go either way, just wanted to make sure this is our conscious
choice and understand why we're doing this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71596/new/
https://reviews.llvm.org/D71596
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
