kadircet marked an inline comment as done.
kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/Hover.cpp:188
+// returns D.
+const NamedDecl *getExplicitSpec(const NamedDecl *D) {
+ if (auto *CTSD = llvm::dyn_cast<ClassTemplateSpecializationDecl>(D)) {
----------------
ilya-biryukov wrote:
> What's the purpose of this function?
> I don't think its description has semantic meaning in C++, "implicit
> instantiations" do not have an "explicit specialization"...
>
> It seems to be doing something to change a decl into something that could be
> used to query the index. If that's the case, we could probably have a name
> that's closer to the described goal.
yeah naming is hard :/
it is not just something that can be used to query index, but also for AST, as
the decl of instantiation doesn't contain comments attached to specialization.
this is basically returning the explicit specialization used to instantiate `D`.
any suggestions for the name ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71596/new/
https://reviews.llvm.org/D71596
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
