This revision was automatically updated to reflect the committed changes.
Closed by commit rGc547c22f1897: [NFC] ASSERT_EQ before accessing items in
containers (authored by kbobyrev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70528/new/
https://
kbobyrev updated this revision to Diff 231046.
kbobyrev added a comment.
Rebase on top of master.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70528/new/
https://reviews.llvm.org/D70528
Files:
clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
clang-tools-extra/clangd/unitte
kbobyrev updated this revision to Diff 230417.
kbobyrev marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70528/new/
https://reviews.llvm.org/D70528
Files:
clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
clang-tools-extra/clangd/unittests/Diagno
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:713
+if (D.Fixes.size() != 1) {
+ ADD_FAILURE() << "D.Fixes.size() != 1";
+}
add `continue`!
CHANGES SINCE LAST ACTION
https://reviews.llvm.o
kbobyrev updated this revision to Diff 230416.
kbobyrev marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70528/new/
https://reviews.llvm.org/D70528
Files:
clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
clang-tools-extra/clangd/unittests/Diagno
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM, but please update the other diff as well!
Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:712
for (const auto &D : Parsed.getDiagno
kbobyrev updated this revision to Diff 230412.
kbobyrev marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70528/new/
https://reviews.llvm.org/D70528
Files:
clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
clang-tools-extra/clangd/unittests/Diagno
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:1877
-EXPECT_EQ(Results.Completions.size(), 1u);
+ASSERT_EQ(Results.Completions.size(), 1u);
EXPECT_THAT(Results.Completions.front().CompletionTokenRange,
kbobyrev created this revision.
kbobyrev added a reviewer: ilya-biryukov.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous.
Herald added a project: clang.
As discussed offline, `ASSERT_EQ` should be used to check if the cont
