ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM, but please update the other diff as well!
================
Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:712
for (const auto &D : Parsed.getDiagnostics()) {
- EXPECT_EQ(D.Fixes.size(), 1u);
+ ASSERT_EQ(D.Fixes.size(), 1u);
EXPECT_EQ(D.Fixes[0].Message,
----------------
Same here, actually. We should not break out of the loop.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70528/new/
https://reviews.llvm.org/D70528
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
