This revision was automatically updated to reflect the committed changes.
Closed by commit rGc547c22f1897: [NFC] ASSERT_EQ before accessing items in
containers (authored by kbobyrev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70528/new/
https://reviews.llvm.org/D70528
Files:
clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
Index: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
+++ clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
@@ -709,7 +709,10 @@
auto Parsed = TU.build();
for (const auto &D : Parsed.getDiagnostics()) {
- EXPECT_EQ(D.Fixes.size(), 1u);
+ if (D.Fixes.size() != 1) {
+ ADD_FAILURE() << "D.Fixes.size() != 1";
+ continue;
+ }
EXPECT_EQ(D.Fixes[0].Message,
std::string("Add include \"a.h\" for symbol X"));
}
Index: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
+++ clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
@@ -1874,7 +1874,10 @@
Annotations TestCode(Text);
auto Results = completions(Server, TestCode.code(), TestCode.point());
- EXPECT_EQ(Results.Completions.size(), 1u);
+ if (Results.Completions.size() != 1) {
+ ADD_FAILURE() << "Results.Completions.size() != 1";
+ continue;
+ }
EXPECT_THAT(Results.Completions.front().CompletionTokenRange,
TestCode.range());
}
Index: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
+++ clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
@@ -709,7 +709,10 @@
auto Parsed = TU.build();
for (const auto &D : Parsed.getDiagnostics()) {
- EXPECT_EQ(D.Fixes.size(), 1u);
+ if (D.Fixes.size() != 1) {
+ ADD_FAILURE() << "D.Fixes.size() != 1";
+ continue;
+ }
EXPECT_EQ(D.Fixes[0].Message,
std::string("Add include \"a.h\" for symbol X"));
}
Index: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
+++ clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
@@ -1874,7 +1874,10 @@
Annotations TestCode(Text);
auto Results = completions(Server, TestCode.code(), TestCode.point());
- EXPECT_EQ(Results.Completions.size(), 1u);
+ if (Results.Completions.size() != 1) {
+ ADD_FAILURE() << "Results.Completions.size() != 1";
+ continue;
+ }
EXPECT_THAT(Results.Completions.front().CompletionTokenRange,
TestCode.range());
}
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
