[PATCH] D69329: [clangd] abort if shutdown takes more than a minute.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bda5f20674d: [clangd] abort if shutdown takes more than a minute. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D69329?vs=226135&id=226148#toc Repository: rG LLVM Github

[PATCH] D69329: [clangd] abort if shutdown takes more than a minute.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Sorry I somehow missed the fact that I was a reviewer :D LGTM Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:219 + // destroyed first, to ensure worker threads

[PATCH] D69329: [clangd] abort if shutdown takes more than a minute.

ilya-biryukov added a reviewer: ilya-biryukov. ilya-biryukov added a comment. Adding myself to the reviewers since I've already looked at it. Unless anyone objects. Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:219 + // destroyed first, to ensure worker threads don't

[PATCH] D69329: [clangd] abort if shutdown takes more than a minute.

merge_guards_bot added a comment. Build result: fail - 59568 tests passed, 1 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69329: [clangd] abort if shutdown takes more than a minute.

sammccall updated this revision to Diff 226135. sammccall added a comment. change timeout to 5 min Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69329/new/ https://reviews.llvm.org/D69329 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp cla

[PATCH] D69329: [clangd] abort if shutdown takes more than a minute.

merge_guards_bot added a comment. Build result: fail - 59551 tests passed, 1 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69329: [clangd] abort if shutdown takes more than a minute.

ilya-biryukov added a comment. Not sure 60 is enough, e.g. building a preamble can often take more than a minute and the users will see clangd crashing for (seemingly) no reason on shutdown. In the long run, we should probably attempt to cancel long-running operations within a much shorter time

[PATCH] D69329: [clangd] abort if shutdown takes more than a minute.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman, jkorous, MaskRay. Herald added a project: clang. A certain class of bug (e.g. infloop on an AST worker thread) currently means clangd never terminates, even if t