[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay added a comment. see D69854: [clang-format] [RELAND] Remove the dependency on frontend Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68969/new/ https://reviews.llvm.org/D68969 ___

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay added a comment. In D68969#1733946 , @thakis wrote: > The revert message said: > > Vlad Tsyrklevich via cfe-commits > Tue, Oct 29, 1:51 PM (7 days ago) > to via, mydeveloperday > > I've reverted this commit as it was causing UBSan

[PATCH] D68969: [clang-format] Remove the dependency on frontend

thakis added a subscriber: vlad.tsyrklevich. thakis added a comment. The revert message said: Vlad Tsyrklevich via cfe-commits Tue, Oct 29, 1:51 PM (7 days ago) to via, mydeveloperday I've reverted this commit as it was causing UBSan failures on the ubsan bot. These failures looked l

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay added a comment. In D68969#1732489 , @thakis wrote: > Since this was reverted: are you looking into relanding this? I'm not totally sure how they reproduced the UBSAN issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68969: [clang-format] Remove the dependency on frontend

thakis added a comment. Since this was reverted: are you looking into relanding this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68969/new/ https://reviews.llvm.org/D68969 ___ cfe-commits mailing li

[PATCH] D68969: [clang-format] Remove the dependency on frontend

This revision was automatically updated to reflect the committed changes. MyDeveloperDay marked an inline comment as done. Closed by commit rGec66603ac7ea: [clang-format] Remove the dependency on frontend (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:356 + + StringRef Line(StartBuf, (EndBuf - StartBuf) - 1); + klimek wrote: > - 1 is to exclude the \n I'd assume? corr

[PATCH] D68969: [clang-format] Remove the dependency on frontend

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Comment at: clang/tools/clang-format/ClangFormat.cpp:356 + + StringRef Line(StartBuf, (EndBuf - StartBuf) - 1); + - 1 is to exclude the \n I'd assume

[PATCH] D68969: [clang-format] Remove the dependency on frontend

thakis added a comment. klimek: ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68969/new/ https://reviews.llvm.org/D68969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay updated this revision to Diff 225455. MyDeveloperDay added a comment. Update out by one errors and unused variables CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68969/new/ https://reviews.llvm.org/D68969 Files: clang/tools/clang-format/CMakeLists.txt clang/tools/cla

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:351 + SourceLocation LineBegin = Sources.translateFileLineCol( + FileEntryPtr.get(), PLoc.getLine() - 1, 0); + SourceLoca

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. Comment at: clang/tools/clang-format/ClangFormat.cpp:345 if (WarnFormat && !NoWarnFormat) { +ArrayRef> Ranges; for (const auto &R : Replaces) { klimek wrote: > Looks u

[PATCH] D68969: [clang-format] Remove the dependency on frontend

klimek added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:345 if (WarnFormat && !NoWarnFormat) { +ArrayRef> Ranges; for (const auto &R : Replaces) { Looks unused? Comment at: clang/tools/clang-format/ClangFo

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay updated this revision to Diff 225320. MyDeveloperDay added a comment. Remove need to split lines or search for `\n` General Algorithm 1. take Location of Replacement line and column 2. make a new SourceLocation of line and column =0 (beginning of that replacement line) 3. make a

[PATCH] D68969: [clang-format] Remove the dependency on frontend

klimek added a comment. In D68969#1709696 , @MyDeveloperDay wrote: > In D68969#1709321 , @klimek wrote: > > > My intuitive solution would have been to get the char* for the start and > > end-location and then sear

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay added a comment. In D68969#1709321 , @klimek wrote: > My intuitive solution would have been to get the char* for the start and > end-location and then search forward and backwards for \n. I may need to, it feels slow for large files which

[PATCH] D68969: [clang-format] Remove the dependency on frontend

klimek added a comment. My intuitive solution would have been to get the char* for the start and end-location and then search forward and backwards for \n. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68969/new/ https://reviews.llvm.org/D68969 __

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: thakis, klimek, mitchell-stellar. MyDeveloperDay added projects: clang, clang-format. Herald added a subscriber: mgorny. Address review comments from D68554: [clang-format] Proposal for clang-format to give compiler style warni