klimek added a comment. In D68969#1709696 <https://reviews.llvm.org/D68969#1709696>, @MyDeveloperDay wrote:
> In D68969#1709321 <https://reviews.llvm.org/D68969#1709321>, @klimek wrote: > > > My intuitive solution would have been to get the char* for the start and > > end-location and then search forward and backwards for \n. > > > I may need to, it feels slow for large files which I suspect is in the > splitting, which will be mostly unnecessary. It's a weird trade-off: for lots of lines, the inside-out algorithm will be better, but if we have a very very long line with lots of warnings, the inside-out algorithm will be quadratic. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68969/new/ https://reviews.llvm.org/D68969 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
