thakis added a subscriber: vlad.tsyrklevich. thakis added a comment. The revert message said:
Vlad Tsyrklevich via cfe-commits <cfe-commits@lists.llvm.org> Tue, Oct 29, 1:51 PM (7 days ago) to via, mydeveloperday I've reverted this commit as it was causing UBSan failures on the ubsan bot. These failures looked like: llvm/lib/Support/SourceMgr.cpp:440:48: runtime error: pointer index expression with base 0x000000000000 overflowed to 0xfffffffffffffffa Looking at a backtrace, this line was reached from the `Diags.print(nullptr, llvm::errs(), (ShowColors && !NoShowColors));` call introduced in this change. Is that enough to see what's wrong? If not, @vlad.tsyrklevich , can you give repro steps for that ubsan failure that made you revert ec66603 in efed314 <https://reviews.llvm.org/rGefed314118c7c287a71b8a8d67953a98d8a718d5>? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68969/new/ https://reviews.llvm.org/D68969 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
