Re: [PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

Hi Louis, ARM and AArch64 libcxx bots are still broken after this commit (host compiler is clang-8), logs are available here: http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux/builds/3143 Cheers, Yvan On Mon, 28 Sep 2020 at 23:44, Louis Dionne via Phabricator via cfe-com

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

rsmith added a comment. In D68364#2299336 , @ldionne wrote: > In D68364#2294569 , @jwakely wrote: > >> I don't think your implementation is valid. I think P0784 only allows >> new-expressions and calls to `std::all

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

ldionne added a comment. In D68364#2294569 , @jwakely wrote: > In D68364#2293971 , @leonardchan > wrote: > >> Is there a recommended way for working around this? We're using GCC 10.2.1. >> Thanks. > > I don't thin

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

jwakely added a comment. In D68364#2293971 , @leonardchan wrote: > Is there a recommended way for working around this? We're using GCC 10.2.1. > Thanks. I don't think your implementation is valid. I think P0784 only allows new-expressions and calls to `

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

leonardchan added a comment. Hi. Our GCC builders are failing with [182/12433] CXX kernel-x64-gcc/obj/kernel/lib/ktl/ktl.dummy-new.cc.o FAILED: kernel-x64-gcc/obj/kernel/lib/ktl/ktl.dummy-new.cc.o /b/s/w/ir/k/fuchsia/prebuilt/third_party/goma/linux-x64/gomacc ../../prebuilt/third_party/gc

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0724f8bf47f8: [libc++] Implement C++20's P0784 (More constexpr con

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

jwakely added inline comments. Comment at: libcxx/include/new:243 # ifdef _LIBCPP_HAS_NO_BUILTIN_OVERLOADED_OPERATOR_NEW_DELETE return ::operator new(__size, __align_val); # else ldionne wrote: > jwakely wrote: > > jwakely wrote: > > > ldionne wrote: > > >

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

jwakely added inline comments. Comment at: libcxx/include/new:243 # ifdef _LIBCPP_HAS_NO_BUILTIN_OVERLOADED_OPERATOR_NEW_DELETE return ::operator new(__size, __align_val); # else jwakely wrote: > ldionne wrote: > > This breaks GCC (as of GCC 9). I don't kn

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

ldionne accepted this revision as: libc++. ldionne added a comment. I'll go ahead and ship this even though I know it will cause problems on GCC. Comment at: libcxx/include/new:243 # ifdef _LIBCPP_HAS_NO_BUILTIN_OVERLOADED_OPERATOR_NEW_DELETE return ::operator new(__size,

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

jwakely added inline comments. Comment at: libcxx/include/new:243 # ifdef _LIBCPP_HAS_NO_BUILTIN_OVERLOADED_OPERATOR_NEW_DELETE return ::operator new(__size, __align_val); # else ldionne wrote: > This breaks GCC (as of GCC 9). I don't know what mechanism G

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

ldionne updated this revision to Diff 293429. ldionne added a comment. Add some tests from D69134 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68364/new/ https://reviews.llvm.org/D68364 Files: libcxx/docs/Feat

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

ldionne added a subscriber: jwakely. ldionne added inline comments. Comment at: libcxx/include/new:243 # ifdef _LIBCPP_HAS_NO_BUILTIN_OVERLOADED_OPERATOR_NEW_DELETE return ::operator new(__size, __align_val); # else This breaks GCC (as of GCC 9). I don't k

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

rsmith added inline comments. Comment at: libcxx/include/version:254 // # define __cpp_lib_concepts 201806L +# define __cpp_lib_constexpr_dynamic_alloc 201907L // # define __cpp_lib_constexpr_misc 201811L --

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

ldionne added inline comments. Comment at: libcxx/include/version:254 // # define __cpp_lib_concepts 201806L +# define __cpp_lib_constexpr_dynamic_alloc 201907L // # define __cpp_lib_constexpr_misc 201811L -

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

rsmith added inline comments. Comment at: libcxx/include/version:254 // # define __cpp_lib_concepts 201806L +# define __cpp_lib_constexpr_dynamic_alloc 201907L // # define __cpp_lib_constexpr_misc 201811L --

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

ldionne added a comment. In D68364#2280187 , @rsmith wrote: > The mechanism by which this interacts with Clang looks good to me. Excellent. > I've not done any detailed analysis to check all the functions made > `constexpr` by P0784 are handled by this

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

rsmith added a comment. The mechanism by which this interacts with Clang looks good to me. I've not done any detailed analysis to check all the functions made `constexpr` by P0784 are handled by this patch, though. Comment at: libcxx/include/version:254 // # define __cpp_lib