jwakely added inline comments.

================
Comment at: libcxx/include/new:243
 # ifdef _LIBCPP_HAS_NO_BUILTIN_OVERLOADED_OPERATOR_NEW_DELETE
     return ::operator new(__size, __align_val);
 # else
----------------
jwakely wrote:
> ldionne wrote:
> > This breaks GCC (as of GCC 9). I don't know what mechanism GCC uses to tie 
> > into constexpr allocation, so I don't know what the fix is.
> > 
> > @jwakely Can you throw some hints at me?
> GCC 9 doesn't support constexpr allocation at all.
GCC 9 doesn't support constexpr allocation at all. You can use 
`__cpp_constexpr_dynamic_alloc` to test for the feature.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68364/new/

https://reviews.llvm.org/D68364

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to