[PATCH] D61835: Extract ASTDumper to a header file

This revision was automatically updated to reflect the committed changes. Closed by commit rC361034: Extract ASTDumper to a header file (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D61835?vs=199179&id=200038#toc Repository: rC Clang CHANGES SINCE

[PATCH] D61835: Extract ASTDumper to a header file

steveire added a comment. Great, thanks. I'm going to investigate whether we can move the `dump` method implementations to their respective class files, and then look into a rename for this to `StreamNodeDumper` or so (name tbd). Repository: rC Clang CHANGES SINCE LAST ACTION https://rev

[PATCH] D61835: Extract ASTDumper to a header file

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D61835#1505388 , @steveire wrote: > In D61835#1505314 , @aaron.ballman > wrote: > > > In D618

[PATCH] D61835: Extract ASTDumper to a header file

steveire added a comment. In D61835#1505314 , @aaron.ballman wrote: > In D61835#1505280 , @steveire wrote: > > > In D61835#1505228 , @aaron.ballman > > wrote: > > > > > In

[PATCH] D61835: Extract ASTDumper to a header file

aaron.ballman added a comment. In D61835#1505280 , @steveire wrote: > In D61835#1505228 , @aaron.ballman > wrote: > > > In D61835#1505202 , @steveire > > wrote: > > > > > 3

[PATCH] D61835: Extract ASTDumper to a header file

steveire added a comment. In D61835#1505228 , @aaron.ballman wrote: > In D61835#1505202 , @steveire wrote: > > > 3. Anyone who wants traversal in the same way that dumping is done and who > > needs to call API on

[PATCH] D61835: Extract ASTDumper to a header file

aaron.ballman added a comment. In D61835#1505202 , @steveire wrote: > In D61835#1505151 , @aaron.ballman > wrote: > > > In D61835#1505048 , @steveire > > wrote: > > > > > T

[PATCH] D61835: Extract ASTDumper to a header file

steveire added a comment. In D61835#1505151 , @aaron.ballman wrote: > In D61835#1505048 , @steveire wrote: > > > The users of the follow-up patch > > https://reviews.llvm.org/D61837#change-x5mxz9Lpijjs need that

[PATCH] D61835: Extract ASTDumper to a header file

aaron.ballman added a comment. In D61835#1505048 , @steveire wrote: > In D61835#1504663 , @aaron.ballman > wrote: > > > I'm not certain where you're planning to go with this change (or is this > > the only change

[PATCH] D61835: Extract ASTDumper to a header file

steveire added a comment. In D61835#1504663 , @aaron.ballman wrote: > I'm not certain where you're planning to go with this change (or is this the > only change you're trying to make in this area?), so it's a bit hard to > evaluate this patch. Can you e

[PATCH] D61835: Extract ASTDumper to a header file

aaron.ballman added a comment. I'm not certain where you're planning to go with this change (or is this the only change you're trying to make in this area?), so it's a bit hard to evaluate this patch. Can you explain a bit more about what you're ultimately trying to accomplish? It might help i

[PATCH] D61835: Extract ASTDumper to a header file

steveire updated this revision to Diff 199179. steveire added a comment. Format Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61835/new/ https://reviews.llvm.org/D61835 Files: include/clang/AST/ASTDumper.h lib/AST/ASTDumper.cpp Index: lib/AST/ASTDumper.cpp

[PATCH] D61835: Extract ASTDumper to a header file

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. This class has member APIs which are useful to clients. Make it possible to use those APIs without adding them to dump() member functions. Doing so doe