[PATCH] D60193: [OpenCL] Added addrspace_cast operator

mantognini added inline comments. Comment at: clang/include/clang-c/Index.h:2057 + */ + CXCursor_CXXAddrspaceCastExpr = 129, + hans wrote: > Anastasia wrote: > > hans wrote: > > > akyrtzi wrote: > > > > Hi Anastasia, apologies for not catching this earlier, bu

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

hans added a subscriber: tstellar. hans added inline comments. Comment at: clang/include/clang-c/Index.h:2057 + */ + CXCursor_CXXAddrspaceCastExpr = 129, + Anastasia wrote: > hans wrote: > > akyrtzi wrote: > > > Hi Anastasia, apologies for not catching this ea

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia added inline comments. Comment at: clang/include/clang-c/Index.h:2057 + */ + CXCursor_CXXAddrspaceCastExpr = 129, + hans wrote: > akyrtzi wrote: > > Hi Anastasia, apologies for not catching this earlier, but libclang is > > intended to keep a stable

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

mantognini added a comment. I've put up https://reviews.llvm.org/D90385 as a fix for this issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60193/new/ https://reviews.llvm.org/D60193 ___ cfe-commits m

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

hans added inline comments. Comment at: clang/include/clang-c/Index.h:2057 + */ + CXCursor_CXXAddrspaceCastExpr = 129, + akyrtzi wrote: > Hi Anastasia, apologies for not catching this earlier, but libclang is > intended to keep a stable ABI and changing the e

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

arphaman added a comment. This warrants a revert since it's breaking ABI compatibility for our libclang's users. @Anastasia will you be able to take a look at this soon? I plan on reverting this patch in a couple of weeks if the issue is still unresolved. Repository: rG LLVM Github Monorepo

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

akyrtzi added inline comments. Herald added a subscriber: dexonsmith. Comment at: clang/include/clang-c/Index.h:2057 + */ + CXCursor_CXXAddrspaceCastExpr = 129, + Hi Anastasia, apologies for not catching this earlier, but libclang is intended to keep a stable

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6a237f2046a: [OpenCL] Added addrspace_cast operator in C++ mode. (authored by Anastasia). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60193?vs=263085&id=264581#toc

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/SemaOpenCLCXX/addrspace_cast.cl:19-24 +template +void test_temp(__global int *par) { + T *var1 = addrspace_cast(par); + __private T *va

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia updated this revision to Diff 263085. Anastasia added a comment. - Improved behavior by allowing casting between equivalent types. - Improved formatting. - Improved tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60193/new/ https://reviews.llvm.org/D60193 Files: clang/

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia marked 3 inline comments as done. Anastasia added inline comments. Comment at: clang/test/SemaOpenCLCXX/addrspace_cast.cl:19-24 +template +void test_temp(__global int *par) { + T *var1 = addrspace_cast(par); + __private T *var2 = addrspace_cast<__private T *>(par); +

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

mantognini added a comment. Thanks for your clarifications and updates. Just one tiny question about a test file, but otherwise LGTM. Comment at: clang/test/SemaOpenCLCXX/addrspace_cast.cl:19-24 +template +void test_temp(__global int *par) { + T *var1 = addrspace_cast(par);

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia marked 4 inline comments as done. Anastasia added inline comments. Comment at: lib/Sema/SemaCast.cpp:279 + case tok::kw_addrspace_cast: +if (!TypeDependent) { + Op.CheckAddrspaceCast(); mantognini wrote: > Still learning here, so could you/som

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia added a comment. In D60193#1549806 , @mantognini wrote: > When compiling this I get the following warning: > > clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:1213:10: warning: enumeration > value 'CXXAddrspaceCastExprClass' not handled in switch

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia updated this revision to Diff 262479. Anastasia added a subscriber: jeroen.dobbelaere. Anastasia added a comment. Herald added subscribers: martong, arphaman. Sorry for long latency. I have rebased the patch to the current master and addressed the comments from @mantognini too. CHANGE

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia added a comment. Ping! I would appreciate any feedback to this change please. Thanks you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60193/new/ https://reviews.llvm.org/D60193 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: include/clang/Basic/TokenKinds.def:564 +// OpenCL addrspace_cast operator +KEYWORD(addrspace_cast , KEYOPENCLCXX) + If I mark it as CXX keyword this will make it

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia created this revision. Anastasia added reviewers: rjmccall, ebevhan. Herald added a subscriber: yaxunl. This change adds extra cast operator `addrspace_cast` described earlier in this RFC: http://lists.llvm.org/pipermail/cfe-dev/2018-December/060546.html This operator is intended for c