[PATCH] D55650: [clangd] Fix an assertion failure in background index.

This revision was automatically updated to reflect the committed changes. Closed by commit rL349144: [clangd] Fix an assertion failure in background index. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://revi

[PATCH] D55650: [clangd] Fix an assertion failure in background index.

hokein marked an inline comment as done. hokein added a comment. Thanks for the review. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55650/new/ https://reviews.llvm.org/D55650 ___ cfe-commits mailing l

[PATCH] D55650: [clangd] Fix an assertion failure in background index.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clangd/index/Background.cpp:384 Action->EndSourceFile(); + if (Clang->hasDiagnostics() && + Clang->getDiagnostics().hasUncompilableErro

[PATCH] D55650: [clangd] Fix an assertion failure in background index.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clangd/index/Background.cpp:384 Action->EndSourceFile(); + if (Clang->hasDiagnostics() && + Clang->getDiagnostics().hasUncompilableErrorOccurred()) { kadircet wrote: > The

[PATCH] D55650: [clangd] Fix an assertion failure in background index.

kadircet added a comment. Ah you are right, the Optional.. Thanks! Comment at: clangd/index/Background.cpp:384 Action->EndSourceFile(); + if (Clang->hasDiagnostics() && + Clang->getDiagnostics().hasUncompilableErrorOccurred()) { Then don't need to keep

[PATCH] D55650: [clangd] Fix an assertion failure in background index.

hokein updated this revision to Diff 178203. hokein marked 5 inline comments as done. hokein added a comment. Keep the old behavior. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55650/new/ https://reviews.llvm.org/D55650 Files: clangd/index/Back

[PATCH] D55650: [clangd] Fix an assertion failure in background index.

hokein added a comment. In D55650#1329692 , @kadircet wrote: > I think the description is misleading, you are saying that we were triggering > an assertion and you are fixing that. But in reality, we were not triggering > any assertions, this patch is ad

[PATCH] D55650: [clangd] Fix an assertion failure in background index.

kadircet added a comment. I think the description is misleading, you are saying that we were triggering an assertion and you are fixing that. But in reality, we were not triggering any assertions, this patch is adding the assertions right? Comment at: clangd/index/Background.

[PATCH] D55650: [clangd] Fix an assertion failure in background index.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. When indexing a file which contains an uncompilable error, we will trigger an assertion failure -- the IndexFileIn data is not set, but we access them in th